Google Git
Sign in
chromium / chromium / src / eed10f07153f2aaf0cce41645e1258753819af1e
commiteed10f07153f2aaf0cce41645e1258753819af1e[log] [tgz]
authorEugene But <eugenebut@google.com>Tue Jan 08 20:28:47 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jan 08 20:28:47 2019
tree2b2f254859f1fe54b0bd73d339d5bc56576827db
parent63b5bedbe67e0c0caeecbc780b6aa1422f8b7c10 [diff]
Use DidFinishNavigation in TextToSpeechPlaybackController.

Deprecated NavigationItemCommitted was repaced with DidFinishNavigation.

DidFinishNavigation is called when navigation is committed, replaced or
aborted. NavigationItemCommitted is called when navigation is committed.
For TextToSpeechPlaybackController it's ok to stop playback if the
navigation was replaced or aborted. So this CL should not lead to any
functional changes.

Bug: 781534
Change-Id: I7e288c6adf9ffb8c635c9d85d9c5bc1d51138a80
Reviewed-on: https://chromium-review.googlesource.com/c/1398502
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620859}
2 files changed
tree: 2b2f254859f1fe54b0bd73d339d5bc56576827db
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .