Google Git
Sign in
chromium / chromium / src / eef6caef5b84e632e27867618d3e3e77d0aee29d
commiteef6caef5b84e632e27867618d3e3e77d0aee29d[log] [tgz]
authorGreg Thompson <grt@chromium.org>Mon Jan 21 18:03:17 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 21 18:03:17 2019
treed5a283113cec4e9ca9c36ae3e7dab2ece78b4184
parent9db0419223cc52d9f2bb05c4c0ae1a9995a8f437 [diff]
Deflake WMITest tests.

These tests were reaching through a ComPtr to call Release on underlying
interface pointers. This is a no-no, as the ComPtr still thinks it's
holding a ref on the interface and will Release again in its dtor. This
is a crashtrocity. This here CL changes such calls to the Reset method
on the ComPtr itself, which does what the test actually intended:
releases the ref held on the interface pointer and forgets about it.

BUG=923562
R=gab@chromium.org

Change-Id: Ie7276f868e88eb63e19605d877fc5c9373564fbf
Reviewed-on: https://chromium-review.googlesource.com/c/1424942
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624616}
1 file changed
tree: d5a283113cec4e9ca9c36ae3e7dab2ece78b4184
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .