)]}' { "commit": "ef70f2711132b50919d5797de39d5b1893517ca7", "tree": "e4cbf802acbc4b17b271a40afbe0acadeaa2820c", "parents": [ "f1b5a26838cdbfdef0fa2a4ce8c4d2112ec03bc7" ], "author": { "name": "Xiaocheng Hu", "email": "xiaochengh@chromium.org", "time": "Tue Jul 17 15:21:03 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jul 17 15:21:03 2018" }, "message": "Make TextIterator abort when ::first-letter contains multiple leading spaces\n\nWhen TextIterator is passed with iteration range fulled contained in\nthe leading collapsed whitespaces of ::first-letter, it currently doesn\u0027t\nstop in the first letter part, but advances to remaining text with\ninvalid parameters.\n\nThis patch fixes it by fixing an existing stop condition:\n- Old condition: stop if the current text box starts at iteration range end\n- New condition: stop if the current text box start at or after the\n iteration range end. The condition is also written in a more intuitive\n way.\n\nCq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng\nChange-Id: I2768d41ec5e792353023ca77749575383020ae18\nReviewed-on: https://chromium-review.googlesource.com/1137697\nReviewed-by: Yoshifumi Inoue \u003cyosin@chromium.org\u003e\nCommit-Queue: Xiaocheng Hu \u003cxiaochengh@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#575644}", "tree_diff": [ { "type": "modify", "old_id": "def66a7d5cf34f8395bf5265007cbec9a72bc21d", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/editing/iterators/text_iterator_test.cc", "new_id": "2221e11d9b33476134aff2c2d0b4a5843b2e932f", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/editing/iterators/text_iterator_test.cc" }, { "type": "modify", "old_id": "ef3e3a2823efce09c1859c664f22ce57d0e9a7cd", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/editing/iterators/text_iterator_text_node_handler.cc", "new_id": "1513e70cc41ec3d2d953c64c82361848154adb27", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/editing/iterators/text_iterator_text_node_handler.cc" } ] }