commit efad090bb9b9a7e115c9075e2118e4979b0a6ad3
author Bret Sepulveda <bsep@chromium.org> Fri Mar 15 23:54:39 2019
committer Commit Bot <commit-bot@chromium.org> Fri Mar 15 23:54:39 2019
tree 7098c0199cf2940016aa8780b2a827377579b354
parent 0acdcbb8df1a5202af4a95b4bc21b2bd8d4bb00e

Various refactoring in TabStripModel tests.

This patch refactors tab_strip_model_unittest.cc and some associated
files in several ways:
* Removes ChromeRenderViewHostTestHarness as a superclass of
  TabStripModelTest. Only one test was relying on anything other than
  TestingProfile; those dependencies are all made explicit. This
  speeds up the suite by about 30% (~5000 ms runtime vs. ~7000ms
  before this patch).
* Changes TestTabStripModelDelegate::RunUnloadListenerBeforeClosing to
  return false, and deletes subclasses that exist solely to override
  that method (all of them, except TabStripDummyDelegate, which is
  renamed to UnloadListenerTabStripModelDelegate).
* Moved several helper classes to be defined immediately before the
  test that uses them.
* Deletes member variables from MockTabStripModelObserver, which are
  unused.
* Fixes lint errors and cleans up unused includes.

Change-Id: I3d70fd3c6013ea06b17146f8f551bb12510fadf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515904
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641358}