tree d670857216b77b7e1c43cacbe419ec877e2b4ea2
parent b280541f94c26df6e367df76f7c1eb101fc7a97a
author Xianzhu Wang <wangxianzhu@chromium.org> 1635276794 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1635276794 +0000

Use std::max and std::min in gfx::(Point|Size|Vector2d)[F]::SetTo(Max|Min)

We used code like a <= b ? a : b instead of std::max/min because the
former performed better than the latter at the time.

Now generated code [1] shows that the compiler can generate better
code with std::max and std::min for these functions for x86_64.

Performance tests with this CL on different platforms seem to show more
slight progressions than regressions (see the pinpoint links in the
change log in the gerrit page of this CL), but the changes might be
just noise because repeated runs on the same platform with the same
benchmark show different results.

At least with std::min/std::max the code is shorter and is more
readable.

[1] https://docs.google.com/document/d/1ve9-XUWc5J_R9SLPDuENHDY_WiP2AEq2O_l7JH0fAEE/edit#

Bug: 738465
Change-Id: Ieb3000c9c1a4a7f04540e5a4a252ed86b3864e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243704
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935090}