Google Git
Sign in
chromium / chromium / src / f6f996d261ec55f7b27f6c129a33c28f18fd1560
commitf6f996d261ec55f7b27f6c129a33c28f18fd1560[log] [tgz]
authorKent Tamura <tkent@chromium.org>Fri Apr 26 02:34:21 2019
committerCommit Bot <commit-bot@chromium.org>Fri Apr 26 02:34:21 2019
tree2e7a43f679ac8bcb1254380edb77348ed3a7f9a3
parent1f66030f01556063757e131985de756a2650b409 [diff]
TEXTAREA: Fix selectionStart and selectionEnd after setting value while parsing TEXTAREA children.

We checked IsFinishedParsingChildren() in SetValueCommon() in order to
avoid changing selection repeatedly while parsing. It caused this bug,
and the check is unnecessary now because parsing TEXTAREA children
doesn't move selectionStart/End to the end of the value since
crrev.com/653487.

Bug: 822639
Change-Id: Ic4353c8cac372da1fc964f51576b306b240ae6b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583172
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654325}
2 files changed
tree: 2e7a43f679ac8bcb1254380edb77348ed3a7f9a3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .