commit | f162267af39b682ab9754e0c02f58c5060d7761c | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Tue Apr 02 06:13:13 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Apr 02 06:13:13 2019 |
tree | 5216b88e0ec3d84767d5b6907ba2b617d19a8cc3 | |
parent | 4e74931cb43be8b664e4da5d67853d448baa62d3 [diff] |
Corrected dependency for mojo type Clipboard The header used was not publically reachable via ui/base so the dependency needs to be a bit more precise. The exact error message from gn check --check-generated: ERROR at //out/Default/gen/third_party/blink/public/mojom/clipboard/clipboard.mojom.h:48:11: Can't include this header from here. - #include "ui/base/clipboard/clipboard_types.h" ^---------------------------------- The target: //third_party/blink/public/mojom:mojom_platform is including a file from the target: //ui/base/clipboard:clipboard_types It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //third_party/blink/public/mojom:mojom_platform --> //ui/base:base --[private]--> //ui/base/clipboard:clipboard_types Bug: 938893 Change-Id: Ica45c5a6710f55f5ee4394a1b2c82fd3a6536531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547729 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#646680}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .