Google Git
Sign in
chromium / chromium / src / f207ec9653d036442e5738a4740b04506d7fe346
commitf207ec9653d036442e5738a4740b04506d7fe346[log] [tgz]
authorJay Harris <harrisjay@chromium.org>Mon Jan 21 03:25:21 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 21 03:25:21 2019
tree1d37208c00ce72a4df584d46bf6fde8087a3f37d
parentd0e9b098e5f320f919460df29a6110cfade58031 [diff]
Adds a separator between custom tab bar and title, based on UX feedback.

Previously, a similar separator was drawn. However, this separator
was always shown (when the theme color was white-ish), and the desired
behavior is to *only* render the separator when the custom tab bar
is visible AND the custom tab bar is white-ish.

This CL will cause a 15% black separator to be drawn at the top of the
custom tab bar, blended with the apps theme color, so it looks like
the separator is drawn onto the title bar.

Bug: 918788
Change-Id: Iba020fe4f059558fe355d18236d5226d35f3a2aa
Reviewed-on: https://chromium-review.googlesource.com/c/1414535
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624514}
2 files changed
tree: 1d37208c00ce72a4df584d46bf6fde8087a3f37d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .