commit | 1de6cac58d76702e4af9293459859639883c40e4 | [log] [tgz] |
---|---|---|
author | David Black <dmblack@google.com> | Fri Apr 19 22:36:35 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Apr 19 22:36:35 2019 |
tree | 493ba936a2beb59510a3201cf1bf8aff1d79fef7 | |
parent | 7a281343ffbccad662f6d3dce487f40bc926de1a [diff] |
Attempt to fix crash in Assistant UI close sequence. I was unable to reproduce the crash, but based on the stack trace in crbug/952996, my understanding of the cause is: (1) User attempts to close Assistant UI via caption bar while animation is in progress. (2) This triggers an animation abort to occur which fires an animation ended callback in UiElementContainerView. (3) UiElementContainerView currently only handles the case where an animation end occurs due to a new Assistant response being queued for display. (4) We attempt to access the queued Assistant response and crash. Since (1) will ultimately result in the entire Assistant view hierarchy being destroyed, the cleanest way to handle this is to just prevent (3) - (4) from accessing invalid state. Bug: 952996 Change-Id: I056df562a21f18ae032beaeb46fc637ecef21c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574743 Reviewed-by: Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#652668}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .