commit f4b05fb3713b702691d4bfa8f58fba75db3ca807
author Gyuyoung Kim <gyuyoung@igalia.com> Fri Feb 22 08:25:25 2019
committer Commit Bot <commit-bot@chromium.org> Fri Feb 22 08:25:25 2019
tree f475f746a7746646683bfdebcb32ae7c2f406551
parent 8f69d9cfbaadee9a83fb30e674aeaa24d8c0e962

BlinkMemoryMgt: Annotate the classes of svg and testing of renderer/core with the macros of Allocator

The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects
with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/svg
and //blink/renderer/core/testing have not yet been allocated with them so far.
So their uses of non-garbage-collected objects should be restricted to cases where
the garbage collector can discover their references. The macros of Allocator will be
useful for the non-garbage-collected objects to avoid unintended allocations.

After some analyzes, it was concluded that for the case of the Commands, and SimPage
classes, they make sense to use DISALLOW_NEW because they have been used as a member
variable with a reference.

In SVGPathQuery class case, they make sense to use STACK_ALLOCATED
because they have been used in function without new allocation or smart pointers.

Bug: 919389
Change-Id: I1230ae019a0ce9f6548c4d71deba5c1da4ae60f3
Reviewed-on: https://chromium-review.googlesource.com/c/1481149
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634577}