commit | f4da398d29d532c95bc47fd444245e307a66a9fd | [log] [tgz] |
---|---|---|
author | Alan Cutter <alancutter@chromium.org> | Wed Feb 06 06:51:40 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 06 06:51:40 2019 |
tree | 6a66cd3ddd6fa6af71853fa587f85323a9268841 | |
parent | 35c1ccda58f302915decbb16bb179a78c0d4996c [diff] |
Fix inconsistent title bar theme usage when GTK theme is set This CL ensures we consistently use GTK theme colours for PWA windows. Before this change the title bar colour would use the GTK theme but the title text would not; resulting in unreadable text for dark GTK themes. This CL adds BrowserFrame::ShouldIgnoreTheme() as an equivalent to BrowserNonClientFrameView::ShouldPaintAsThemed(). The latter cannot be used everywhere due to initialisation order dependencies. Deduping these functions is done in a separate CL https://chromium-review.googlesource.com/c/chromium/src/+/1453217 in the interest of keeping this CL merge friendly. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=378056&signed_aid=KLS7LkKg4N2vijhbrVDErQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=378057&signed_aid=_AbZIHu6j7Hwm57_i9KhRA==&inline=1 Bug: 927381 Change-Id: I308d8c3c0606cb54ba708cee1ec89a620c1f9d6c Reviewed-on: https://chromium-review.googlesource.com/c/1453558 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#629488}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .