commit | f5c8fc6129f2560d40385d19bdc076580cdfbcd0 | [log] [tgz] |
---|---|---|
author | Kelvin Jiang <kelvinjiang@chromium.org> | Thu Mar 14 01:54:57 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Mar 14 01:54:57 2019 |
tree | 36b49fdf0c52f080bdf109f8833d26f8bc72b32d | |
parent | b7ee01cc2ead713d0f91319adce6b648745006ca [diff] |
[Extensions] Convert activity args in the stream to a list This CL displays the list of arguments used for the activity's API call in an ordered list instead of a whole JSON string. This improves readability and achieves feature parity with the Chrome Apps & Extensions Developer Tool (aka Platform App.) This CL also replaces all "<arg_url>" placeholders with the activity's specified argUrl in the same fashion as the Platform App. To ensure that the expanded arguments list is not too long, only the first "level" of the arguments array is parsed into the list. Nested objects/arrays are kept as strings. Known issues: The UI still looks janky when a nested object is large as it can take up many lines. The Platform App deals with this by stretching it out to 1 line, which... has its own problems. One way to address this would be to add a "see more" button/prompt and only show a part of the nested object initially. Screenshot: crbug.com/932768#c7 Bug: 932768 Change-Id: I51276196d09d463126aff6471c7e51d6064c2e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497326 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640584}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .