commit | f60bc42e73d321c81ec137009e89b4441f3d06a2 | [log] [tgz] |
---|---|---|
author | David Bokan <bokan@chromium.org> | Tue Nov 13 18:06:27 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Nov 13 18:06:27 2018 |
tree | f95502a54520d728799ce4c4f3f2463417d08bbf | |
parent | 45a86ad0b78f2c2951156f402785725fba02bed5 [diff] |
[root-scroller] Fix crash when considering plugin Root scroller shouldn't consider plugins. However, the current method of getting the scrollable area would check for a local frame and try to convert its view to a LocalFrameView. In the case of a plugin, the ContentFrame()->IsLocalFrame may return true but the EmbededContentView is a PluginView rather than a LocalFrameView. This CL cleans up these checks by looking exclusively at the EmbeddedContentView since that's all we care about. Bug: 903440 Change-Id: I7f172559321ecb4777e1fd85ed63f105798df257 Reviewed-on: https://chromium-review.googlesource.com/c/1330330 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607651}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .