commit f676aa95fc9a2927f001d34ccaefdb72937da661
author Eugene But <eugenebut@chromium.org> Wed Mar 11 07:54:11 2020
committer Commit Bot <commit-bot@chromium.org> Wed Mar 11 07:54:11 2020
tree 981217e8295bf01687045f4f2be4bbf6e0e1830a
parent 4c0d8ce28fbe5980900386cdb894787f5bbf432b

Fix crashes in AutofillControllerTest.KeyValueFocusChange

The test is likely crashing because of out of bounds exception. Using
ASSERT_EQ instead of EXPECT_EQ should stop the test before accessing
invalid index.

This CL does not fix the failing test, it just replaces crash with
a graceful failure.

Bug: 1060251
Change-Id: I214a4aae84274f5c191ad665c906743cc3f856d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094709
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749079}

ios/chrome/browser/autofill/autofill_controller_unittest.mm

diff --git a/ios/chrome/browser/autofill/autofill_controller_unittest.mm b/ios/chrome/browser/autofill/autofill_controller_unittest.mm
index 0965e1c..1d1bf3a 100644
--- a/ios/chrome/browser/autofill/autofill_controller_unittest.mm
+++ b/ios/chrome/browser/autofill/autofill_controller_unittest.mm
@@ -601,7 +601,7 @@
   // Focus the dummy field and confirm no suggestions are presented.
   ExecuteJavaScript(@"document.forms[0].dummy.focus()");
   WaitForSuggestionRetrieval(/*wait_for_trigger=*/YES);
-  EXPECT_EQ(0U, [suggestion_controller() suggestions].count);
+  ASSERT_EQ(0U, [suggestion_controller() suggestions].count);
 
   // Enter 'B' in the dummy field and confirm no suggestions are presented.
   ExecuteJavaScript(@"event = document.createEvent('TextEvent');");
@@ -609,7 +609,7 @@
       @"event.initTextEvent('textInput', true, true, window, 'B');");
   ExecuteJavaScript(@"document.forms[0].dummy.dispatchEvent(event);");
   WaitForSuggestionRetrieval(/*wait_for_trigger=*/YES);
-  EXPECT_EQ(0U, [suggestion_controller() suggestions].count);
+  ASSERT_EQ(0U, [suggestion_controller() suggestions].count);
 
   // Enter 'B' in the greeting field and confirm that one suggestion ("Bonjour")
   // is presented.
@@ -620,7 +620,7 @@
       @"event.initTextEvent('textInput', true, true, window, 'B');");
   ExecuteJavaScript(@"document.forms[0].greeting.dispatchEvent(event);");
   WaitForSuggestionRetrieval(/*wait_for_trigger=*/YES);
-  EXPECT_EQ(1U, [suggestion_controller() suggestions].count);
+  ASSERT_EQ(1U, [suggestion_controller() suggestions].count);
   FormSuggestion* suggestion = [suggestion_controller() suggestions][0];
   EXPECT_NSEQ(@"Bonjour", suggestion.value);
 }