tree 88d805ed9099bfdec3721813e626e81936d016cc
parent 2a0793c9027d9430b1c25aa37041579673cb3e8d
author Stefano Duo <stefanoduo@google.com> 1727132196 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1727132196 +0000

Revert "Account for position and limit when creating spans out of ByteBuffers"

This reverts commit 6f2bae751df2a100973e99a14b0737e77e9e2270.

Reason for revert: breaks tabs restoration https://chromium-review.googlesource.com/c/chromium/src/+/5776110/comment/45ebf524_57fc2617/

Original change's description:
> Account for position and limit when creating spans out of ByteBuffers
>
> ByteBuffer#{get, put} work on the current ByteBuffer#position(): writing a single byte will put it as "position" within the ByteBuffer, then increment position by one (read does the same but returns the byte instead of writing it). As such, the native layer should do the same: if we're reading from a ByteBuffer in native, we should read the same way Java would; from position, until limit.
>
> I'm not sure if this is an existing issue within Chrome (maybe all ByteBuffers there ends up always having position == 0 and limit == size), but extending MaybeJavaByteBufferToMutableSpan to take this into account would allow Cronet to make use of these utilities.
>
> Note: There is no JNI function to directly fetch the position and limit of a ByteBuffer (like one can do for data and size). As such, we need
> to tell jni_zero to generate bindings for ByteBuffer.
>
> Bug: 41488662, b:358568022
> Change-Id: I38eb668af549ce73de4157816510cb287eae5945
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776110
> Owners-Override: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Stefano Duo <stefanoduo@google.com>
> Reviewed-by: Etienne Dechamps <edechamps@google.com>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1355831}

Bug: 41488662, b:358568022
Change-Id: Ib440e2a31c9a0819e42feca78f9463c611a26d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5882433
Auto-Submit: Stefano Duo <stefanoduo@google.com>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1359051}