commit | f866e172a0be9ac564adb481d91deb567676847a | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Tue Apr 16 15:22:49 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Apr 16 15:22:49 2019 |
tree | a39f815a307d430c839b80af587bb6789f329c08 | |
parent | 5eba140c8b9d401b0ad6e0deba6c8309115c1246 [diff] |
Include headers, not cc files A test included a cc file which results in duplicate symbols in the build which then broke certain builds. Most builds were ok because linkers have the optimization to ignore obj files which are not referenced by anything else. If anything in the obj file is referenced everything changes though, and everything in the obj file is considered. Change-Id: I2ce961e341952847b20410746b58094ea9d7a3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566309 Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#651277}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .