tree 9ed21d791b5fd868a7413d78071b62c58e23f9dc
parent fc89f37fcdf2d5a890e3c8c506e38152cfbe6bf3
author Thomas Lukaszewicz <tluk@chromium.org> 1724041291 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1724041291 +0000

[lens] Prevent crash navigating to lens WebUI in browser tab

LensUntrustedUI currently assumes that the LensOverlayControllerGlue
has been set on the WebContents hosting the WebUI when it's loaded.

The glue is set when creating the overlay view however it is not done
for browser tab WebContents objects. This results in invariant
violations and segfault crashes when loading lens in a browser tab.

The ideal behavior would be to suppress loading WebUI in unsupported
contexts, however the existing WebUI machinery makes this difficult.

Follow up work will tighten restrictions on WebUI instantiation and
improve context guarantees.

Bug: 360710001, 360724768
Change-Id: Ief01d04747aa06aaf1e9b58fe44a0d6a6def012f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5793562
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1343326}