Google Git
Sign in
chromium / chromium / src / f92da6993e45b28a7e0c82b1aed89aae95f72931
commitf92da6993e45b28a7e0c82b1aed89aae95f72931[log] [tgz]
authorJose Dapena Paz <jdapena@igalia.com>Wed Jun 17 22:57:35 2020
committerCommit Bot <commit-bot@chromium.org>Wed Jun 17 22:57:35 2020
tree66a010581e54964fec6a06051becf0ef4049beaf
parent6e93b5dcbb6ab5458b160870cc2f664f0db9e5d2 [diff]
GCC: remove noexcept declaration in CrossVariantMojoAssociatedReceive/Remote

It breaks compilation of blink::WebServiceRegistrationObjectInfo that includes
WebServiceWorkerObjectInfo instance. This one uses default move constructor
without noexcept declaration, but has as members CrossVariantMojoAssociatedReceive
and CrossVariantMojoAssociatedRemote with noexcept declaration in move constructor.
declared noexcept.

As resolved in other places, noexcept is not really much useful with -fno-exception
and our codebase is not prepare to add it consistently. Clang will not report
exception declaration incompatibilities in case -fno-exception is used, but GCC
fails.

Bug: 819294
Change-Id: Id5c46c271a8a92352d769de9c3c263d3dce4c9c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247791
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779526}
1 file changed
tree: 66a010581e54964fec6a06051becf0ef4049beaf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.