commit | fa697bc2152cac2195356446de838270ccc964a6 | [log] [tgz] |
---|---|---|
author | Christy Chen <chrche@microsoft.com> | Wed Jun 26 19:31:24 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 26 19:31:24 2019 |
tree | 761c878011eda7236147d02e3f3d65e87dc92f13 | |
parent | c835718deb920504253ac99226de48879e55c756 [diff] |
DevTools: work around rjsmin issue to fix Audits frontpage bug 972969 In previous change https://chromium-review.googlesource.com/c/chromium/src/+/1600375, some strings are wrapped inside placeholders ${} in string literals for localization purposes. However, rjsmin couldn't process nested string literals properly so the white-spaces after commas or periods would get trimmed off. It causes the issue where words cannot break to the next line when Audits page resized, and leaves unwanted extra space. This change works around the issue by pulling the string with comma out to a variable to prevent nested string literal. Before fix: https://imgur.com/uMjr5Bp After fix: https://imgur.com/a/X5wq6Xo More details on the rjsmin issue: https://bugs.chromium.org/p/chromium/issues/detail?id=973285 Bug: 972969 Change-Id: I4b4cf243df0ce74c400e488f6c6b98595cf4ecca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655913 Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#672610}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .