tree 725110a670059ccd113331ccd7f94b2ec5d1b816
parent 34e2f2bc71a925b0158b2f2faa828708851fb092
author Benoit Lize <lizeb@chromium.org> 1717661172 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1717661172 +0000

Revert "Reland "[Insets] Attach InsetObserver directly to ActivityWindowAndroid""

This reverts commit e1180f7d09784ccd680d8d02c64f0236bf208a08.

Reason for revert: Suspected cause for test failure, crbug.com/345372444

Original change's description:
> Reland "[Insets] Attach InsetObserver directly to ActivityWindowAndroid"
>
> This is a reland of commit 384890b3adf44d85a0dbedfc45b542c7bdca95eb
>
> PS1 is the original change.
>
> The main issue with the patchset is it introduced b/344959459. The root
> cause of the bug was holding RootView caused GC to fail for WebView. A
> fix was proposed here and has been folded into this CL.
> https://chromium-review.googlesource.com/c/chromium/src/+/5598361
>
> However, there is still the issue that we probably shouldn't create the
> InsetObserver for WebView in the first place so this CL also addresses
> that by lazily instantiating it only when needed.
>
> I'll land this and then reland the follow-up change after a day so we
> don't need to chain the reverts again.
>
> Original change's description:
> > [Insets] Attach InsetObserver directly to ActivityWindowAndroid
> >
> > Rework the lifecycle of InsetObserver to be tied to
> > ActivityWindowAndroid.
> >
> > Precursor to landing:
> > https://chromium-review.googlesource.com/c/chromium/src/+/5580959
> >
> > Bug: 343224210
> > Change-Id: I15fabd91e614fd690c31ddba8641da9720d073ed
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5589447
> > Reviewed-by: Theresa Sullivan <twellington@chromium.org>
> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> > Reviewed-by: Ted Choc <tedchoc@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1309960}
>
> Include-Ci-Only-Tests: true
> Bug: 343224210
> Change-Id: I439e5d41187b50e75c014232c581597042108946
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5597547
> Reviewed-by: Theresa Sullivan <twellington@chromium.org>
> Reviewed-by: Bo Liu <boliu@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1310765}

Bug: 343224210, 345372444
Change-Id: I747b94bd4b537d4c28f3936ccff2c4e6dbea133c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5602672
Auto-Submit: Benoit Lize <lizeb@chromium.org>
Owners-Override: Benoit Lize <lizeb@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Benoit Lize <lizeb@chromium.org>
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1311116}