commit | c4d373fb500eee7010d0f674b2ec0da2b3ac0e8e | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Fri Oct 12 16:13:11 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 12 16:13:11 2018 |
tree | 3754cf056c90d0d5fac6f13876efcc96d11723d7 | |
parent | a46ef58bc631f6cac042c61c492a88a618141aa8 [diff] |
Remove special-code for replaced content inside out-of-flow. Remove some special-code to resolve the logical height of percent-based replaced content whose containing block was an out-of-flow object with auto height and non-auto top/bottom. This caused problems for LayoutNG, which typically hasn't stored the new heights on the containing blocks at the time of calculating the height of some child (so attempting to calculate anything based on the ancestor layout objects during layout won't work in NG). If we just remove the special-code, and fall back to calling ContainingBlockLogicalHeightForContent() further down, that method will honor the containing block logical height override (which NG has calculated and set before entering the legacy replaced content object). For legacy layout, we'll eventually bump into more or less identical (to what I'm removing here) special-code in AvailableLogicalHeightUsing() anyway. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I78636cce88bd66e625925b79e19183d4653f32fe Reviewed-on: https://chromium-review.googlesource.com/c/1278865 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#599240}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .