commit | fc82a9b25bfe303434842973712bfb2773b3c707 | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Wed Jan 09 18:50:38 2019 |
committer | Findit <findit-for-me@appspot.gserviceaccount.com> | Wed Jan 09 18:50:38 2019 |
tree | 440cd08c624d0cef0053bce97760d5849b6bfb35 | |
parent | c301d11bc17d7ed21d81927dfc14ade33b3c2512 [diff] |
Revert "Added a check for an selected image when toggling the editor" This reverts commit 07d0aa4c7e0b5622ed434a29ec1f863b9fb6d4c4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 621191 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDdkMGFhNGM3ZTBiNTYyMmVkNDM0YTI5ZWMxZjg2M2I5ZmI2ZDRjNAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/18392 Sample Failed Step: non_single_process_mash_browser_tests Sample Flaky Test: GalleryBrowserTest.DeleteImageWhileEditingOnDrive Original change's description: > Added a check for an selected image when toggling the editor > > This provides a non-null check for the assert call. When the assert > call was being invoked with a null value, the edit mode was not being > toggled. Adding this in should allow deleting a single image to toggle > the edit mode to off. > > Bug: 912489 > Change-Id: I88cfa830d9780a5f1da94710939d4243f231aa2b > Reviewed-on: https://chromium-review.googlesource.com/c/1388812 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Alexander Nohe <nohe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621191} Change-Id: I232da9107f44addfa135131b0010cc2f68edf4f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912489, 920299 Reviewed-on: https://chromium-review.googlesource.com/c/1403352 Cr-Commit-Position: refs/heads/master@{#621243}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .