Sync removal of mojo remote with destruction of MediaSessionController

As discussed in [1], with the recent migration of legacy IPC messages
we could get into a race condition between the point where the mojo
remote for the media::mojom::MediaPlayer interface associated to a
specific media player gets removed from the map owned by MWCO, and
when exactly the MediaSessionController associated to the same media
player gets destroyed, which is leading to crashes.

To fix this, let's remove the OnMediaDestroyed() legacy IPC message and
handle that event via the disconnect handler for the mojo remote in MWCO
associated to the media player being destroyed, and move the logic from
MWCO::OnMediaDestroyed() in there.

Note that this is also in line with the proposed design in [2], where
it was already proposed to remove this message in favour of the handler.

[1] https://crrev.com/c/2596148/5#message-b8c571524e046ccf53a53c811da629c98c849a0b
[2] https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E

TBR=mlamouri@chromium.org

Bug: 1157572,1157239,1157263,1157241,1039252
Change-Id: I79b9d9cd3e65881db4826b0d058a530d6d249a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596148
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838819}
6 files changed
tree: 011da8b33c5da51c29a983998f16b2b1d5c76bce
  1. .clang-format
  2. .clang-tidy
  3. .eslintrc.js
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. .gn
  8. .vpython
  9. .vpython3
  10. .yapfignore
  11. AUTHORS
  12. BUILD.gn
  13. CODE_OF_CONDUCT.md
  14. DEPS
  15. DIR_METADATA
  16. ENG_REVIEW_OWNERS
  17. LICENSE
  18. LICENSE.chromium_os
  19. OWNERS
  20. PRESUBMIT.py
  21. PRESUBMIT_test.py
  22. PRESUBMIT_test_mocks.py
  23. README.md
  24. WATCHLISTS
  25. android_webview/
  26. apps/
  27. ash/
  28. base/
  29. build/
  30. build_overrides/
  31. buildtools/
  32. cc/
  33. chrome/
  34. chromecast/
  35. chromeos/
  36. cloud_print/
  37. codelabs/
  38. codereview.settings
  39. components/
  40. content/
  41. courgette/
  42. crypto/
  43. dbus/
  44. device/
  45. docs/
  46. extensions/
  47. fuchsia/
  48. gin/
  49. google_apis/
  50. google_update/
  51. gpu/
  52. headless/
  53. infra/
  54. ios/
  55. ipc/
  56. jingle/
  57. media/
  58. mojo/
  59. native_client_sdk/
  60. net/
  61. pdf/
  62. ppapi/
  63. printing/
  64. remoting/
  65. rlz/
  66. sandbox/
  67. services/
  68. skia/
  69. sql/
  70. storage/
  71. styleguide/
  72. testing/
  73. third_party/
  74. tools/
  75. ui/
  76. url/
  77. weblayer/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.