tree 011da8b33c5da51c29a983998f16b2b1d5c76bce
parent 9b4e0898f5fc55acf0bed548fb0c96ef27f8b777
author Mario Sanchez Prada <mario@igalia.com> 1608627281 +0000
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1608627281 +0000

Sync removal of mojo remote with destruction of MediaSessionController

As discussed in [1], with the recent migration of legacy IPC messages
we could get into a race condition between the point where the mojo
remote for the media::mojom::MediaPlayer interface associated to a
specific media player gets removed from the map owned by MWCO, and
when exactly the MediaSessionController associated to the same media
player gets destroyed, which is leading to crashes.

To fix this, let's remove the OnMediaDestroyed() legacy IPC message and
handle that event via the disconnect handler for the mojo remote in MWCO
associated to the media player being destroyed, and move the logic from
MWCO::OnMediaDestroyed() in there.

Note that this is also in line with the proposed design in [2], where
it was already proposed to remove this message in favour of the handler.

[1] https://crrev.com/c/2596148/5#message-b8c571524e046ccf53a53c811da629c98c849a0b
[2] https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E

TBR=mlamouri@chromium.org

Bug: 1157572,1157239,1157263,1157241,1039252
Change-Id: I79b9d9cd3e65881db4826b0d058a530d6d249a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596148
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838819}