[Minibranch] Revert "[url_fixer] Use string_view instead of const string parameter." This reverts commit 84c0276cc6f49fd047fb763efade9f4df3de4f22. Reason for revert: The Suspect CL https://chromium-review.googlesource.com/q/I06fe9bd459d516508bea2ba60434b1e1ccedfac8 is highly likely the cause of the crash. Please see the crash report http://crash/3b8cc7a091742d56. Rebase the Revert CL on top of main branch with conflicts allowed option to prevent false positive merge conflicts. Original change's description: > [url_fixer] Use string_view instead of const string parameter. > > This allows avoiding unnecessary string copies. `.substr()`, > `.remove_prefix()`, and `.remove_suffix()` on string_views just update > the view boundaries instead of making string copies or changing memory. > > Low-Coverage-Reason: TRIVIAL_CHANGE to prefs_util.cc > > Change-Id: I06fe9bd459d516508bea2ba60434b1e1ccedfac8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7363419 > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Jeffrey Yu <yuje@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1565047} (cherry picked from commit 985ddb3bce02c3bbf7755fbc36fd961c165fb92e) Bug: 474893357, 483672730 Change-Id: I57161f902551a209617ff141d9a9d64e503e1eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7430079 Auto-Submit: Jeffrey Yu <yuje@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1568341} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7566293 Commit-Queue: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Reviewed-by: Harry Souders <harrysouders@google.com> Cr-Commit-Position: refs/branch-heads/7632_45@{#3} Cr-Branched-From: 7ad2aeb6be38786b2bf653d667d3df01e68d3c40-refs/branch-heads/7632@{#1825} Cr-Branched-From: 0bbdf2913883391365383b0a5dfe7bf9fd1a5213-refs/heads/main@{#1568190}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.