[M148] Revert "[fixit] Make bookmark bar visible on custom NTPs" Original change's description: > Revert "[fixit] Make bookmark bar visible on custom NTPs" > > This reverts commit 1c9353d22624f0a689dd1956279da89cdbc4109d. > > Reason for revert: User feedback (crbug.com/510370818) > > Original change's description: > > [fixit] Make bookmark bar visible on custom NTPs > > > > Bug: 491027414 > > Change-Id: I894fc33f75c298090b4b0bb5edcc50ec21e2f141 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7670040 > > Reviewed-by: Foromo Daniel Soromou <koretadaniel@chromium.org> > > Reviewed-by: Kaan Alsan <alsan@chromium.org> > > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > > Commit-Queue: Dmytro Yeroshkin <yeroshkin@chromium.org> > > Reviewed-by: David Pennington <dpenning@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1600583} > > Bug: 491027414 > Change-Id: Ida752b7998567a60c4c177c2e6e62e8be1a1252f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7837269 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Foromo Daniel Soromou <koretadaniel@chromium.org> > Commit-Queue: Dmytro Yeroshkin <yeroshkin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1628808} (cherry picked from commit 01e71df4e1d99410aea55f76cf8589c74bd686e1) Bug: 512504985,491027414 Change-Id: Ida752b7998567a60c4c177c2e6e62e8be1a1252f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7857449 Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/7778@{#3196} Cr-Branched-From: 77f495ee216d4c3cc784d33658bad4778c0680ee-refs/heads/main@{#1610480}
diff --git a/chrome/browser/ui/bookmarks/BUILD.gn b/chrome/browser/ui/bookmarks/BUILD.gn index 687063f..c5dd24f 100644 --- a/chrome/browser/ui/bookmarks/BUILD.gn +++ b/chrome/browser/ui/bookmarks/BUILD.gn
@@ -66,7 +66,6 @@ "//chrome/app:command_ids", "//chrome/browser:browser_features", "//chrome/browser/bookmarks", - "//chrome/browser/extensions", "//chrome/browser/prefs", "//chrome/browser/profiles:profile", "//chrome/browser/renderer_host",
diff --git a/chrome/browser/ui/bookmarks/bookmark_bar_controller.cc b/chrome/browser/ui/bookmarks/bookmark_bar_controller.cc index 70f0ba6c1..06717f9d 100644 --- a/chrome/browser/ui/bookmarks/bookmark_bar_controller.cc +++ b/chrome/browser/ui/bookmarks/bookmark_bar_controller.cc
@@ -6,7 +6,6 @@ #include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/defaults.h" -#include "chrome/browser/extensions/extension_url_overrides.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/search/search.h" #include "chrome/browser/tab_group_sync/tab_group_sync_service_factory.h" @@ -50,11 +49,7 @@ if (entry->IsInitialEntry()) { entry = web_contents->GetController().GetVisibleEntry(); } - GURL url = entry->GetURL(); - // Attempt reverse lookup of the url in case an extension overrode the new tab - // page. This function updates the url parameter in place. - ExtensionUrlOverrides::HandleChromeURLOverrideReverse( - &url, web_contents->GetBrowserContext()); + const GURL& url = entry->GetURL(); return NewTabUI::IsNewTab(url) || NewTabPageUI::IsNewTabPageOrigin(url) || NewTabPageThirdPartyUI::IsNewTabPageOrigin(url) || search::NavEntryIsInstantNTP(web_contents, entry);