commit | d271db3d0bb86df90ff694cb48ebc73ea2771352 | [log] [tgz] |
---|---|---|
author | Peter Wen <wnwen@chromium.org> | Wed Apr 27 21:12:52 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Wed Apr 27 21:27:01 2022 |
tree | da4722cf2e30adb27cbfc3bb951f7cd78eacfd2b | |
parent | 7c961465c1f49c45da41bb462fb92c1b879e95c3 [diff] |
Android: Depend on build_java explicitly This CL moves build_java from being a public_dep of base_java to a regular dep. This means other targets that need to depend on build_java must do so explicitly. Since build_java and base_java are not closely related, this de-coupling (and when jni annotations are similarly moved) will reduce the number of targets that depend on base_java only for its annotations, thus speeding up builds when making changes to base_java. By using dep_operations.py, this CL avoided adding build_java to 224+ targets that already depended on base_java across 194 files. There are more opportunities to remove unnecessary dependencies on build_java, but that is left for future CLs in order to prioritize removing build_java from base_java's public_deps. Initial estimate (after jni_java is similarly moved out of public_deps) is that we can remove more than 265+ dependencies on base_java across ~153 files. Bug: 1038372 Change-Id: Ia5acc70af449f10363bd7e123473e0823ce31bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3606468 Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Owners-Override: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/main@{#996885} NOKEYCHECK=True GitOrigin-RevId: 494cdd47f9446588db75588b8f2f266d66beb786
This folder contains a shim layer between the public frameworks APIs (android.webkit.*
) and WebView's implementation, and allows them to (mostly) not directly depend on each other.
//android_webview/java/
must not depend on this directory.