commit | 612c9f8264842362e42a335343afe1754fdf8fba | [log] [tgz] |
---|---|---|
author | François Doray <fdoray@chromium.org> | Tue Jun 21 21:56:59 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Wed Jun 22 08:28:16 2022 |
tree | 28c9d12788ca117f146c87174a03d426b7db5e73 | |
parent | 5c07539baa1232c83e8add11dcaca8019e265cbb [diff] |
[base] Don't expect CFRunLoop timer to fire at the expected time on iOS. Occasionnally, the expectation that TimeTicks::Now() is greater than or equal to the desired run time when MessagePumpCFRunLoopBase::RunDelayedWorkTimer() fires fails. The "LOG_FATAL" crash key indicates that it may fire up to 0.5ms too early. Firing too early is not ideal for power consumption (we're waking up the CPU when no work is ready) but the task system is resilient to this situation, so this CL removes the expectation on iOS as a quick fix. As a next step, we migrate TimeTicks::Now() from clock_gettime(CLOCK_MONOTONIC) to clock_gettime_nsec_np(CLOCK_UPTIME_RAW) on iOS and see if it fixes this issue. Fixed: 1337336 Change-Id: I4718dea035c866d0663e0003bf06869046866162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715218 Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Auto-Submit: Francois Pierre Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016393} NOKEYCHECK=True GitOrigin-RevId: 65c861095f647084be761f91d47f8aba5fa4f2af
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE
is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests
target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.