| commit | 8df65eb6a0eeecb76c0876cd1a046ad4d9661c42 | [log] [tgz] |
|---|---|---|
| author | mikt <mikt@google.com> | Fri Sep 22 03:36:12 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Sep 22 03:58:03 2023 |
| tree | a3ae70173fdf5efd4ae39327f2c7912b9e65b0cf | |
| parent | d2f14d3d610cc502f95217a7b951681fbb2970c9 [diff] |
[EnumSet/BRP] Fix dangling pointer in 'enum_set.h' It is unclear why this was previously marked as dangling, but since dangling error is no longer reproducible, we can remove the marker. It appears that an inappropriate use of 'enum_set.h' existed but has now been removed. Bug: 1291138 Change-Id: I310915abd88737e7530aecaf6f97374f3a881437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4880729 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mikihito Matsuura <mikt@google.com> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1200023} NOKEYCHECK=True GitOrigin-RevId: 21bba97b54893898821d33b4a59cfa23e3fb3d1e
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
thread_local, the implementation in //base, the POSIX/WinAPI directly)Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.