Android: Clean up baseline.xml for downstream

Fix lint errors/warnings for all downstream files. This paves the way
for upstream and downstream monochrome bundle targets to generate the
same baseline.xml file.

Add support to ignore @VisibleForTesting(otherwise = ...) annotations
in presubmit and fix a few presubmit errors along the way.

Tbr: No functional changes in components/ and net/
Bug: 1111363
Change-Id: Ia3752c9a775a5ad0dedc10d415376c264d2575fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330332
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795062}
GitOrigin-RevId: 6367b887a32c955c80b1ad082ce87c0d7478bc52
2 files changed
tree: 89dcfab7a6136ea076079b57a18ef7784b0c56f3
  1. .gitignore
  2. .style.yapf
  3. BUILD.gn
  4. OWNERS
  5. OWNERS.setnoparent
  6. OWNERS.status
  7. README.md
  8. android/
  9. apple/
  10. apply_locales.py
  11. args/
  12. build-ctags.sh
  13. build_config.h
  14. buildflag.h
  15. buildflag_header.gni
  16. check_gn_headers.py
  17. check_gn_headers_unittest.py
  18. check_gn_headers_whitelist.txt
  19. check_return_value.py
  20. chromeos/
  21. ciopfs.sha1
  22. cipd/
  23. clobber.py
  24. compiled_action.gni
  25. compute_build_timestamp.py
  26. config/
  27. copy_test_data_ios.py
  28. cp.py
  29. detect_host_arch.py
  30. dir_exists.py
  31. docs/
  32. dotfile_settings.gni
  33. download_nacl_toolchains.py
  34. env_dump.py
  35. extract_from_cab.py
  36. extract_partition.py
  37. find_depot_tools.py
  38. find_isolated_tests.py
  39. fix_gn_headers.py
  40. fuchsia/
  41. gdb-add-index
  42. get_landmines.py
  43. get_symlink_targets.py
  44. gn_helpers.py
  45. gn_helpers_unittest.py
  46. gn_run_binary.py
  47. install-build-deps-android.sh
  48. install-build-deps.sh
  49. install-chroot.sh
  50. internal/
  51. ios/
  52. lacros/
  53. landmine_utils.py
  54. landmines.py
  55. linux/
  56. locale_tool.py
  57. mac/
  58. mac_toolchain.py
  59. nocompile.gni
  60. noop.py
  61. partitioned_shared_library.gni
  62. precompile.cc
  63. precompile.h
  64. print_python_deps.py
  65. protoc_java.py
  66. protoc_java.pydeps
  67. redirect_stdout.py
  68. rm.py
  69. run_swarming_xcode_install.py
  70. sample_arg_file.gn
  71. sanitize-mac-build-log.sed
  72. sanitize-mac-build-log.sh
  73. sanitize-win-build-log.sed
  74. sanitize-win-build-log.sh
  75. sanitizers/
  76. shim_headers.gni
  77. skia_gold_common/
  78. swarming_xcode_install.py
  79. symlink.gni
  80. symlink.py
  81. timestamp.gni
  82. toolchain/
  83. tree_truth.sh
  84. update-linux-sandbox.sh
  85. util/
  86. vs_toolchain.py
  87. whitespace_file.txt
  88. win/
  89. write_build_date_header.py
  90. write_buildflag_header.py
  91. xcode_binaries.yaml
README.md

About

//build contains:

  • Core GN templates and configuration
  • Core Python build scripts

Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium, v8, etc), it should be kept as self-contained as possible by not referring to files outside of it. Some exceptions exist (//testing, select //third_party subdirectories), but new dependencies tend to break these other projects, and so should be avoided.

Changes to //build should be landed in the Chromium repo. They will then be replicated to the stand-alone build repo by the gsubtreed tool. Note: You can find all directories already available through gsubtreed in the list of all chromium repos.

Contents

  • //build/config - Common templates via .gni files.
  • //build/toolchain - GN toolchain definitions.
  • Other .py files - Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.

Files referenced by //.gn:

  • //build/BUILDCONFIG.gn - Included by all BUILD.gn files.
  • //build/secondary - An overlay for BUILD.gn files. Enables adding BUILD.gn to directories that live in sub-repositories.
  • //build_overrides - Refer to //build_overrides/README.md.

Docs