commit | 63ea6845d13a944c37bd7a89246677865de905f9 | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Fri Jun 21 23:42:59 2019 |
committer | Findit <findit-for-me@appspot.gserviceaccount.com> | Fri Jun 21 23:42:59 2019 |
tree | 2f3bb7e76ed23fce33dbbb3a25d9c2d4b0a831de | |
parent | a9bf5bbe868e6dbff5fdbb6d938a6121ccc10c0a [diff] |
Revert "[build] Cleanup for specifying [min|target|max]SdkVersion in GN" This reverts commit 07f70727879b890bcdb8183036e895de375ca695. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 671446 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzA3ZjcwNzI3ODc5Yjg5MGJjZGI4MTgzMDM2ZTg5NWRlMzc1Y2E2OTUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-archive-rel/1542 Sample Failed Step: compile Original change's description: > [build] Cleanup for specifying [min|target|max]SdkVersion in GN > > crrev/c/1650265 enforced setting [min|target|max]SdkVersion in GN. > However, this is to strict for some dependencies, e.g. WebRTC. > Therefore, relax rules so that you can specify the SDK versions in both > GN and the AndroidManifest.xml. And the build system will assert that > these values match. > > + Update some SDK versions that had been changed inadvertently in > crrev/c/1650265. > > TBR=tedchoc@chromium.org,torne@chromium.org > > Bug: 891996 > Bug: 977417 > Bug: 977328 > Change-Id: I89b944c1f73a35ba8fcdafdf4bdf62508759811e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660361 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671446} Change-Id: I06e05d04cf5e8cbc4c663bd6a5ebfda1ba0b2b3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672178 Cr-Original-Commit-Position: refs/heads/master@{#671461} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 92e53a6ae0cee9a38f96eb1926cccfa4027db9d4