Revert "[build] Treat libc++ include dir as a system include path on Windows"
This reverts commit 0d1f027d1387f27e7abb4d3e4ed988d4abe45a88.
Reason for revert: Breaks building without hermetic MSVC
toolchain, see https://crbug.com/1338539
Original change's description:
> [build] Treat libc++ include dir as a system include path on Windows
>
> We already do this on non-Windows using the -isystem flag. While MSVC
> doesn't really have an equivalent flag, clang-cl does: -imsvc.
>
> This has two effects:
>
> - It suppresses warnings originating from files included via this
> path. The reasoning is that code in system headers in not under the
> developer's control.
>
> - Headers included via this path are not reported as dependencies via
> the /showIncludes:user flag (similar to -MD on non-Windows),
> reducing the amount of data Ninja has to parse and store in the
> .ninja_deps file. Instead, the dependency on a certain libc++
> revision is encoded via a command-line argument
> (-DCR_LIBCXX_REVISION).
>
> The later point would also have prevented triggering a Ninja bug when
> a path in .ninja_deps changed from a directory to regular file after a
> libc++ roll+revert (see crbug).
>
> Bug: 1337238
> Change-Id: Ibc7a5855e208e602065f7767cda812117ab9b792
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714251
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1016076}
Bug: 1337238
Change-Id: I46d59c93078b68df83698b09fa7a76bc5437cbe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715836
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1016856}
NOKEYCHECK=True
GitOrigin-RevId: 573716f476051b202966cddee0b2692c3b6f8260
1 file changed
