commit | 1bce48e202a9ecd1f74aa13f406328112fd3e122 | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Fri May 20 01:48:07 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Fri May 20 02:08:13 2022 |
tree | defc16398d411debd7092acf377c96c91d4b9b2d | |
parent | 77b330769fdab606a667e4e6f701e78d34d9e7ca [diff] |
Revert "Android: Make TrichromeLibrary.apk have no classes.dex" This reverts commit b1e26665ad91606db1ade9fe8f021ef7dbbe879a. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision b1e26665ad91606db1ade9fe8f021ef7dbbe879a as the culprit for failures in the continuous build including: Sample Failed Build: https://ci.chromium.org/b/8813697873572499617 Sample Failed Step: compile If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2Fb1e26665ad91606db1ade9fe8f021ef7dbbe879a&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+b1e26665ad91606db1ade9fe8f021ef7dbbe879a Original change's description: > Android: Make TrichromeLibrary.apk have no classes.dex > > Moves NativeLibraries class from the library to chrome/webview apks. > > This will allow better R8 optimization of the class, and should also > hopefully result in better performance since the library should no > longer need to be included in classloader lookups. > > Bug: 1319967 > Change-Id: I2c5908e6c575c9bce8c606506779e7db89f3269a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3650992 > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1005425} Change-Id: Ief1ae992169e351c2f70dcb6da8adb234e5106a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1319967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3656342 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Owners-Override: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#1005577} NOKEYCHECK=True GitOrigin-RevId: 293df39872b775e1223c86c1a6863f50f06c4fbc