Revert "Reland "Reland "[AndroidUnwinder] Flip use_android_unwinder_v2 flag"""

This reverts commit 92392812db0d2c59f97b35b33e14fae92e131f1e.

Reason for revert:
Potentially cause a crash. Need to further monitor Android crashes, as this CL is very likely not causing the crash directly. (stack profiling is not enabled in DEV channel, but we are getting crashes there).

Original change's description:
> Reland "Reland "[AndroidUnwinder] Flip use_android_unwinder_v2 flag""
>
> This reverts commit 36602b51665850498b2f75ee6287b868cd077bd5.
>
> Reason for revert:
> Test build dependency issue fixed in
> https://chromium-review.googlesource.com/c/chromium/src/+/3585824.
>
> Previously StackSamplingProfilerTests were crashing because the unwind
> asset was not listed as the test build dependency.
>
> Original change's description:
> > Revert "Reland "[AndroidUnwinder] Flip use_android_unwinder_v2 flag""
> >
> > This reverts commit 38e5d798e2769b9dad7d35fdbc8ccea1cb5d0298.
> >
> > Reason for revert: Broke StackSamplingProfilerTest
> >
> > Original change's description:
> > > Reland "[AndroidUnwinder] Flip use_android_unwinder_v2 flag"
> > >
> > > This reverts commit 75fd1337a0b0ddb277a4e5ad431f7353b55c0e25.
> > >
> > > Reland the flagflip.
> > >
> > > This CL keeps the generation of the original unwind asset so that
> > > heap profiler does not crash.
> > >
> > > Original change's description:
> > > > Revert "[AndroidUnwinder] Flip use_android_unwinder_v2 flag"
> > > >
> > > > This reverts commit e4892541b5ef9009e8465fe8464c3a3792f1e2c8.
> > > >
> > > > Reason for revert:
> > > > The heap profiler still uses old unwind asset. Stop generating the
> > > > old unwind asset causes heap profiler to crash.
> > > >
> > > > Original change's description:
> > > > > [AndroidUnwinder] Flip use_android_unwinder_v2 flag
> > > > >
> > > > > This CL flips the use_android_unwinder_v2 flag to let thread profiler
> > > > > use android v2 unwinder by default.
> > > > >
> > > > > Under local testing, the v2 unwinder has success rate
> > > > > (busy / (busy + failed)):
> > > > > - 87.5% (process periodic collection)
> > > > > - 80.4% (process start up)
> > > > >
> > > > > Bug: 1240698
> > > > > Change-Id: I92037cf9859d87fb775563affd680177946d5ce6
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3573465
> > > > > Reviewed-by: Mike Wittman <wittman@chromium.org>
> > > > > Reviewed-by: Amy Huang <akhuang@google.com>
> > > > > Commit-Queue: Charlie Hu <chenleihu@google.com>
> > > > > Cr-Commit-Position: refs/heads/main@{#989669}
> > > >
> > > > Bug: 1314378, 1240698
> > > > Change-Id: Id8ef8b164a5830fa8cbe02cca59e54382d88317f
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > >
> > > Bug: 1314378, 1240698
> > > Change-Id: If33196fec09215e8f65693368c8f8c1cf57aea34
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3579628
> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > > Commit-Queue: Charlie Hu <chenleihu@google.com>
> > > Reviewed-by: Mike Wittman <wittman@chromium.org>
> > > Cr-Commit-Position: refs/heads/main@{#991712}
> >
> > Bug: 1314378, 1240698, 1315817
> > Change-Id: Iaded179e48d4821d2fd32cc7f4607560df6b0cc0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3578226
> > Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Owners-Override: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#991864}
>
> Bug: 1240698
> Change-Id: I8ea74eb26a981b8455c5cf4fdf8766d3590e5cd9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3585931
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Charlie Hu <chenleihu@google.com>
> Cr-Commit-Position: refs/heads/main@{#994842}

Bug: 1322114, 1240698
Change-Id: I0ab9d778d9ddceb6f798e210f6f4f5ab607c0f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3650940
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/main@{#1004865}
NOKEYCHECK=True
GitOrigin-RevId: d188a3471cf477540d475604118a3b82cc975a17
1 file changed