commit | 4725d9f97e3b455c3a99ac156605173a9ab90cae | [log] [tgz] |
---|---|---|
author | Takashi Sakamoto <tasak@google.com> | Fri Jun 07 02:24:59 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jun 07 02:24:59 2019 |
tree | 18bc03aa57740f5a9f9882bd67cfb2fe97b2f410 | |
parent | 412a5ef60fcdafaeee0b02b261b5a022e4b3a2d8 [diff] |
Reland "Use explicit path for libtool rather than implicit invocation of xcrun." This reverts commit 6f979049822acf3e4cde9b34f5dcfeb8e94745e5. Reason for revert: This doesn't cause compile failure. I have to revert https://chromium-review.googlesource.com/c/chromium/src/+/1649054 Original change's description: > Revert "Use explicit path for libtool rather than implicit invocation of xcrun." > > This reverts commit 1f49775ab209ba5668029cdffe63f40ce5e98668. > > Reason for revert: causes compile failure on Mac ASan 64 Builder > https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/84739 > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8911354223898031376/+/steps/compile/0/stdout > > > Original change's description: > > Use explicit path for libtool rather than implicit invocation of xcrun. > > > > libtool is part of the default path at /usr/bin/libtool. That binary is just a > > shim that calls out to xcrun to find the actual libtool. If we're using hermetic > > xcode, then we can explicitly specify the path to avoid invoking xcrun. > > > > Bug: 971452 > > Change-Id: If9344a244160ccc43895cf913d48f9c9a44ac5d9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648836 > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Erik Chen <erikchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#666906} > > TBR=dpranke@chromium.org,erikchen@chromium.org > > Change-Id: I0cdc4acdff512213116ecd872230b6d7b634b865 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 971452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647598 > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#666983} TBR=dpranke@chromium.org,tasak@google.com,erikchen@chromium.org Change-Id: I1180b957926016864fcb83f351985ce6ec4fb8bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 971452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647600 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Original-Commit-Position: refs/heads/master@{#666985} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 20fb0ca2321693ac194b9efd7c83d8a4b856fdb4