commit | 21de45622cf9440245ea655fe74d1048bb09321a | [log] [tgz] |
---|---|---|
author | Andrew Grieve <agrieve@chromium.org> | Thu Aug 10 16:54:08 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 10 16:54:08 2017 |
tree | 25a237de2356ede0f833d0e1fec19626f9629610 | |
parent | f213759b3a8c6943300cb3bf0b189f6eda6592b9 [diff] |
Speed up "gn gen" by ~65ms for non-mac host_os By skipping an xcode-specific exec_script(). Discovered via "gn gen --tracelog=gn.trace" Bug: 748851 Change-Id: I7d7d1f636e90d4842758d94a1b327622bb9f5edc Reviewed-on: https://chromium-review.googlesource.com/609163 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493431} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: d04b06a98e44e072075b11777984d67a2e9b3099
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.