| commit | 24615fd7491a57d2d9ba6b7240bb7a15e537047d | [log] [tgz] |
|---|---|---|
| author | Austin Eng <enga@chromium.org> | Thu Apr 21 21:09:39 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Apr 21 21:22:01 2022 |
| tree | 7e186ad40cb6b1e27696b4e8f6eefb19b76df219 | |
| parent | 123cfb1d9d02b9ad2c32c2a731b85736d78f15bc [diff] |
Set dawn_angle_dir to //third_party/angle If this isn't set, there's no libEGL so glfwCreateWindow fails and may sometimes kill the test bot running dawn_end2end_tests. It's probably desirable to set `dawn_angle_dir` in Chromium builds for WebGPU compat as well. Bug: dawn:1375 Change-Id: I7693b7d80ca99527930dd082ed9e453d10c4b708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597108 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/main@{#994903} NOKEYCHECK=True GitOrigin-RevId: 9206c52e29504b97a2bbe1709209e3e495a9a335
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.