commit | a46260f99bb4b12f4fa73e1a08b7c8812d54ba3a | [log] [tgz] |
---|---|---|
author | dsinclair <dsinclair@chromium.org> | Fri Apr 29 02:25:33 2016 |
committer | Commit bot <commit-bot@chromium.org> | Fri Apr 29 02:27:20 2016 |
tree | cca6c5412b98b1fc7903c42fd6ca8baa2cda259f | |
parent | bab0eea0cf5f7ae68b661eacd8b9c792bf19e8ae [diff] |
Revert of Add PDFium build_overrides (patchset #5 id:100001 of https://codereview.chromium.org/1923343002/ ) Reason for revert: Broke fuzzer bots. Original issue's description: > Add PDFium build_overrides > > This CL adds the build override settings so we can enable XFA in GN builds > in the future. > > BUG=chromium:62400 TBR=thakis@chromium.org,tsepez@chromium.org,thestig@chromium.org,dpranke@chromium.org,aizatsky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:62400 Review-Url: https://codereview.chromium.org/1933583002 Cr-Original-Commit-Position: refs/heads/master@{#390577} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: e43a2442a5e5e1000021caf9f692b69208e1e53c
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.