| commit | a76f3039114050a0fb131a683b45f115190bd9cd | [log] [tgz] |
|---|---|---|
| author | Sami Kyostila <skyostil@chromium.org> | Thu May 07 11:17:58 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu May 07 11:17:58 2020 |
| tree | 7dda8e7afdf92d1c1d46b9e657b385c71890a5aa | |
| parent | 36b29739d6b50d6fe9c17d0dcce0650404c45131 [diff] |
build_overrides: Add V8 build override for using Perfetto from Chromium This patch adds a build override for telling V8 to use the Perfetto client library built by Chromium instead of trying to build an independent copy. The feature flag (use_perfetto_client_library) is defaulted to false in V8 and overridden here when Chromium is also using Perfetto's client library[1]. Corresponding V8 change: https://chromium-review.googlesource.com/c/v8/v8/+/2182637 Bug: b/155075662 [1] https://docs.google.com/document/d/1f7tt4cb-JcA5bQFR1oXk60ncJPpkL02_Hi_Bc6MfTQk/ Change-Id: Iabdeec5fe957934dc0e3bb0364c5272a818415ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184572 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#766369} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 6d86ca61f15f73ddb68abe73663486c352bcfa09
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.