commit | b26af8e466b9b3faa8629cd68d4e5c83cc3ccf8b | [log] [tgz] |
---|---|---|
author | Mirko Bonadei <mbonadei@chromium.org> | Thu Jun 11 19:39:29 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jun 11 19:39:29 2020 |
tree | d2e2c578358ddccefc6aac54d47ff55b6fe90416 | |
parent | da4cd51b41879a3c11204f87a6a1d55af7f1a6d2 [diff] |
Move enable_base_tracing/use_perfetto_client_library to build_overrides. This will allow projects that use //base to override these two GN args in an easier way (//build_overrides/build.gni instead of gn args). Bug: 1093406 Change-Id: I26d012732a428798a28e43726ce0abba54b3dd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241123 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#777444} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: b79aad6eb7b8c4376eddf884e95b6467230c24d7
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.