| commit | bdc63834a87046de85f73725341381dd11ba6d89 | [log] [tgz] |
|---|---|---|
| author | Prudhvi Kumar Bommana <pbommana@google.com> | Thu Apr 08 04:29:41 2021 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Apr 08 04:34:08 2021 |
| tree | d7d96ddd15f7859bb3c6f75eb794fbb433d207a3 | |
| parent | ac5696da816fc35117009b9f9891b586f0e5dd7c [diff] |
Revert "Reland: DEPS: recursedeps into Dawn to get Tint" This reverts commit 2c526a7b10f74f174521e6b667eb92aa7cf95225. Reason for revert: crbug.com/1196923#c2 Original change's description: > Reland: DEPS: recursedeps into Dawn to get Tint > > Reland after changes in Dawn that only deps on vulkan-deps if > dawn_standalone is True. > > Sheriffs: If this commit is in the regression range of an official > builder gclient flatten failure, it is the most likely culprit. > > Dawn and Tint are intrinsically linked as they implement both sides of > WebGPU: the API side and the shading language side. To ease the > development workflow of Tint, make Chromium recursedeps into Dawn. > > Without this CL changes in Tint rolled into Dawn aren't usable until > they are also rolled in Chromium (Dawn CQ runs Chromium-based tests). > > Bug: tint:700 > Bug: chromium:1195554 > Change-Id: Iffb54ac167a4abc51e51548ba1e89f39f2f13aa2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2809396 > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Auto-Submit: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#870047} Bug: tint:700 Bug: chromium:1195554 Change-Id: I8674af26feb2a4f45020e4af2d12d44630db6edc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812759 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Michael Moss <mmoss@chromium.org> Owners-Override: Prudhvi Kumar Bommana <pbommana@google.com> Auto-Submit: Prudhvi Kumar Bommana <pbommana@google.com> Commit-Queue: Prudhvi Kumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/heads/master@{#870365} GitOrigin-RevId: d58b015c2e29236ba2b9cdd3389c8aa52e23dccf
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.