| commit | d215f78f974469b7d259bdfe0731417fd4688c76 | [log] [tgz] |
|---|---|---|
| author | Findit <findit-for-me@appspot.gserviceaccount.com> | Wed Dec 16 22:59:56 2020 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Dec 16 23:07:38 2020 |
| tree | d6dcb3f9722766ed3af3c4216c89ce68c201ced1 | |
| parent | 59ab009b3258018620e8c997c812d7dd0e01bf69 [diff] |
Revert "Re-land "Use new vulkan-deps repo for all Vulkan dependencies."" This reverts commit 595ea7d15c33f6f456687f8b65d188977aeffaab. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 837732 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU5NWVhN2QxNWMzM2Y2ZjQ1NjY4N2Y4YjY1ZDE4ODk3N2FlZmZhYWIM Sample Failed Build: https://ci.chromium.org/b/8860720074507463920 Sample Failed Step: compile Original change's description: > Re-land "Use new vulkan-deps repo for all Vulkan dependencies." > > Re-land includes missing headers directory. > > This replaces several grouped dependencies with one meta-repo. > The meta-repo will allow us to group multiple inter-dependent > deps rolls into one single roll. This solves the problem of > separate rollers breaking because of the inter-dependencies. > It also allows ANGLE and Chrome to share common bits like the > README and .gitignore files. > > Bug: angleproject:5390 > Bug: 1153258 > Change-Id: I22cefb1bfeeec656c2dbb173701a87a6db9cb8ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593888 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Auto-Submit: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837732} Change-Id: I8f225478f447b3be0bf0bc9eed4106516027e3d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596423 Cr-Commit-Position: refs/heads/master@{#837791} GitOrigin-RevId: 6d4a1eaa39d7962b7942f7649163452f880ab508
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.