| commit | f3f03a8bf07df428116319b0ed5c88ca2c00ef99 | [log] [tgz] |
|---|---|---|
| author | Nicolas Capens <nicolascapens@google.com> | Wed Apr 06 15:56:55 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Apr 06 16:05:28 2022 |
| tree | 676d96e5585f86285e17052720af33317646f859 | |
| parent | 9f95e948208c22df416593c24b628e4ddf4fb2ac [diff] |
Remove swiftshader_spirv_tools_dir SwiftShader now uses an independent build of SPIRV-Tools dependencies, like in other environments. Bug: b/158002593 Change-Id: I7ec5aac25c002cc5ff4d4e39bcd196ce58e55b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3572785 Auto-Submit: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Arthur Eubanks <aeubanks@google.com> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/main@{#989451} NOKEYCHECK=True GitOrigin-RevId: f0331b71d310261db79dfe9009b70a308bed0691
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.