commit | f71475dc279b7c02af18bb67dde2682c6f2fbba3 | [log] [tgz] |
---|---|---|
author | martiniss <martiniss@chromium.org> | Wed Jun 21 18:12:06 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 21 18:12:06 2017 |
tree | 9204448186c28e4daac2dba0877c23f9bd035743 | |
parent | 99daf733168a829245cb5839d4a8945cc7ace010 [diff] |
Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (patchset #2 id:20001 of https://codereview.chromium.org/2950933003/ ) Reason for revert: Broke mac builders on chromium.perf: https://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/102244 Original issue's description: > mac: Roll hermetic toolchain to Xcode 8.3.2. > > Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the > 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. > > To support machines running macOS versions < 10.12, but don't require building > targets, this CL also: > * Does not download the hermetic toolchain if the macOS version does not > support the toolchain version. > * Does not allow building targets with the default hermetic toolchain if the > macOS version does not support the toolchain version. > > BUG=624049 > > Review-Url: https://codereview.chromium.org/2950933003 > Cr-Commit-Position: refs/heads/master@{#481225} > Committed: https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e9ceb72d29c8e TBR=dpranke@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624049 Review-Url: https://codereview.chromium.org/2949043002 Cr-Original-Commit-Position: refs/heads/master@{#481241} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 81095e19266ad3da6479a5889793842fe49a437b
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.