buildtools: remove libc++abi from buildtools/DEPS
libcxxabi_revision was in both DEPS and buildtools/DEPS. After this
change, it's only in DEPS.
Chromium's //build uses libc++abi on several platforms, so if your
project depses in //build, it will now have to also deps in libc++abi
explicitly. Edit your toplevel DEPS file to have something like
'libcxxabi_revision': '6918862bfc2bff22b45058fac22b1596c49982fb',
in its `vars =` section, and an entry similar to
'src/buildtools/third_party/libc++abi/trunk':
Var('chromium_git') +
'/external/github.com/llvm/llvm-project/libcxxabi.git' + '@' +
Var('libcxxabi_revision'),
in its `deps =` section. Adopt to your project's style as you like.
(Maybe you don't want an explicit variable for the revision, maybe
your toplevel directory is not called "src", maybe
chromium.googlesource.com is known by something other than
chromium_git.)
The BUILD.gn file for libc++ remains in buildtools, so you likely want
to configure your project's autoroller that rolls transitive chromium
deps like //build, //buildtools to also roll libcxxabi_revision to
what's in Chromium's deps.
As far as I can tell, all projects have a way to do this already one way or
another (autoroller configs support this via the 'transitive' child of
'dep'; v8 should use what it uses for icu
https://chromium-review.googlesource.com/c/v8/v8/+/2703456/2/DEPS, angle what
it uses for testing/
https://chromium-review.googlesource.com/c/angle/angle/+/2711724/2/DEPS,
etc).
This is another step towards removing buildtools/DEPS and
makes it possible to set up an autoroller for libc++abi for chromium.
Bug: 1182719,1177288
Change-Id: I3d1b4d0089531b32598efd479e56ccfd694fc715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729355
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859124}
GitOrigin-RevId: 83e2f2247e455b668e378e5cb30ba236127fb556
1 file changed
