Make --enable-benchmarking not affect metrics recording.

Previously, it would cause metrics to be in a special mode
where metrics are recorded but never reported, which caused
unbounded accumulation of data, such as user actions, in the
UMA protos. This test-only mode didn't seem necessary, so
removing it.

This also allowed a bunch of simplification, by removing a
client interface and its implementation, moving a switch to the
metrics component and removing some ios versions of the code.

BUG=730091

Review-Url: https://codereview.chromium.org/2933953002
Cr-Original-Commit-Position: refs/heads/master@{#479511}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de445d97963c2efe33e244fa60678173a6a3c2c8
2 files changed
tree: 52ec626c2296206ab33479e447aa15c19de30396
  1. gpu/
  2. leak_detector/
  3. net/
  4. profiler/
  5. proto/
  6. public/
  7. serialization/
  8. ui/
  9. BUILD.gn
  10. call_stack_profile_collector.cc
  11. call_stack_profile_collector.h
  12. call_stack_profile_metrics_provider.cc
  13. call_stack_profile_metrics_provider.h
  14. call_stack_profile_metrics_provider_unittest.cc
  15. call_stack_profile_params.cc
  16. call_stack_profile_params.h
  17. child_call_stack_profile_collector.cc
  18. child_call_stack_profile_collector.h
  19. child_call_stack_profile_collector_unittest.cc
  20. clean_exit_beacon.cc
  21. clean_exit_beacon.h
  22. client_info.cc
  23. client_info.h
  24. cloned_install_detector.cc
  25. cloned_install_detector.h
  26. cloned_install_detector_unittest.cc
  27. daily_event.cc
  28. daily_event.h
  29. daily_event_unittest.cc
  30. data_use_tracker.cc
  31. data_use_tracker.h
  32. data_use_tracker_unittest.cc
  33. DEPS
  34. drive_metrics_provider.cc
  35. drive_metrics_provider.h
  36. drive_metrics_provider_android.cc
  37. drive_metrics_provider_ios.mm
  38. drive_metrics_provider_linux.cc
  39. drive_metrics_provider_mac.mm
  40. drive_metrics_provider_unittest.cc
  41. drive_metrics_provider_win.cc
  42. enabled_state_provider.cc
  43. enabled_state_provider.h
  44. environment_recorder.cc
  45. environment_recorder.h
  46. environment_recorder_unittest.cc
  47. execution_phase.cc
  48. execution_phase.h
  49. file_metrics_provider.cc
  50. file_metrics_provider.h
  51. file_metrics_provider_unittest.cc
  52. histogram_encoder.cc
  53. histogram_encoder.h
  54. histogram_encoder_unittest.cc
  55. log_decoder.cc
  56. log_decoder.h
  57. log_store.h
  58. machine_id_provider.h
  59. machine_id_provider_stub.cc
  60. machine_id_provider_win.cc
  61. machine_id_provider_win_unittest.cc
  62. metrics_log.cc
  63. metrics_log.h
  64. metrics_log_manager.cc
  65. metrics_log_manager.h
  66. metrics_log_manager_unittest.cc
  67. metrics_log_store.cc
  68. metrics_log_store.h
  69. metrics_log_store_unittest.cc
  70. metrics_log_unittest.cc
  71. metrics_log_uploader.h
  72. metrics_pref_names.cc
  73. metrics_pref_names.h
  74. metrics_provider.cc
  75. metrics_provider.h
  76. metrics_reporting_default_state.cc
  77. metrics_reporting_default_state.h
  78. metrics_reporting_service.cc
  79. metrics_reporting_service.h
  80. metrics_rotation_scheduler.cc
  81. metrics_rotation_scheduler.h
  82. metrics_scheduler.cc
  83. metrics_scheduler.h
  84. metrics_service.cc
  85. metrics_service.h
  86. metrics_service_accessor.cc
  87. metrics_service_accessor.h
  88. metrics_service_client.cc
  89. metrics_service_client.h
  90. metrics_service_unittest.cc
  91. metrics_state_manager.cc
  92. metrics_state_manager.h
  93. metrics_state_manager_unittest.cc
  94. metrics_switches.cc
  95. metrics_switches.h
  96. metrics_upload_scheduler.cc
  97. metrics_upload_scheduler.h
  98. OWNERS
  99. persisted_logs.cc
  100. persisted_logs.h
  101. persisted_logs_metrics.h
  102. persisted_logs_metrics_impl.cc
  103. persisted_logs_metrics_impl.h
  104. persisted_logs_unittest.cc
  105. persistent_system_profile.cc
  106. persistent_system_profile.h
  107. persistent_system_profile_unittest.cc
  108. README
  109. reporting_service.cc
  110. reporting_service.h
  111. single_sample_metrics.cc
  112. single_sample_metrics.h
  113. single_sample_metrics_factory_impl.cc
  114. single_sample_metrics_factory_impl.h
  115. single_sample_metrics_factory_impl_unittest.cc
  116. stability_metrics_helper.cc
  117. stability_metrics_helper.h
  118. stability_metrics_helper_unittest.cc
  119. stability_metrics_provider.cc
  120. stability_metrics_provider.h
  121. stability_metrics_provider_unittest.cc
  122. system_memory_stats_recorder.h
  123. system_memory_stats_recorder_linux.cc
  124. system_memory_stats_recorder_win.cc
  125. test_enabled_state_provider.cc
  126. test_enabled_state_provider.h
  127. test_metrics_log_uploader.cc
  128. test_metrics_log_uploader.h
  129. test_metrics_provider.cc
  130. test_metrics_provider.h
  131. test_metrics_service_client.cc
  132. test_metrics_service_client.h
  133. url_constants.cc
  134. url_constants.h
  135. version_utils.cc
  136. version_utils.h