)]}' { "log": [ { "commit": "b4920ae7d336a0293f27577faf92ea79e4b5bc76", "tree": "62c92bafc674be86ff60e2e78e8b7eaafbf5c0c2", "parents": [ "9d51cad31a4e7e7653ff22322a318fe3c4143005" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Tue Aug 20 15:38:30 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 20 15:45:47 2024" }, "message": "spanification: Refresh `#pragma allow_unsafe_buffers`.\n\nThis patch was fully automated using script:\nhttps://paste.googleplex.com/5614491201175552\n\nThis is a \"refresh\" upon previously approved directories. This is\nmostly //chrome, because enabling the warning got reverted just before I\nwent on vacation, and new occurrences got added:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/5767579\n\nSee internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nBug: 40285824\nChange-Id: I402573ae6e9bd1c01939e06210b4141dfe79bc6f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5797215\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1344165}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 68107b0f4208791b0ad0fc0e423aca63c9a6dbf6\n" }, { "commit": "9d51cad31a4e7e7653ff22322a318fe3c4143005", "tree": "9e7b023d66281a76e64a7d516a730260c6b9ecab", "parents": [ "289111b7b4ae1ab492a41e24dc7da3a778ba4849" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Jul 18 17:01:38 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 18 17:19:18 2024" }, "message": "spanification: Add `#pragma allow_unsafe_buffers` to courgette/*\n\nThis is a preparation to fix each files.\nThis CL has no behavior changes.\n\nThis patch was fully automated using script:\nhttps://paste.googleplex.com/5614491201175552\n\nNote that in patchset2, change to:\n/build/config/unsafe_buffers_paths.txt\nwas reverted. Indeed, running too many (~3) CQ run touching this file is\nmaking the builder cache much slower. I will bundle every change to this\nfile in a subsequent CL. I will limit myself to 1-2 CQ run per day.\n\nSee internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nBug: 351564777\nChange-Id: I2c7622a6bafb3fc098c28c46388fefaa5064815d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5717874\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1329640}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d606dd9df2451a80555255f8c4cfa548663bd635\n" }, { "commit": "289111b7b4ae1ab492a41e24dc7da3a778ba4849", "tree": "143d0ec7f27e5f5bc757808ef857526f6baf55aa", "parents": [ "ab4ba794d76f2711fe0d41f5e79be327b6ac19cb" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Tue Jul 09 20:36:56 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 09 20:44:59 2024" }, "message": "Remove experimental annotation #11 #cleanup\n\nRemove annotations on raw_ptr that was meant to be temporary.\nThis is a #cleanup\nPatchset 1 was auto generated. Please review the diff.\n\nBundleId: 11\nAX-Relnotes: n/a\nCq-Include-Trybots: luci.chromium.try:linux-asan-dbg,mac-asan-rel,win-asan,win-official,android-official;luci.chrome.try:chromeos-betty-pi-arc-chrome\nBug: 326876092\nChange-Id: I77ce46b689d6d58bf978aaaeb982f796798602ab\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5678993\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1325109}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 68399397bdd2a55d45bc864d520ed1287c27acd1\n" }, { "commit": "ab4ba794d76f2711fe0d41f5e79be327b6ac19cb", "tree": "8910033ab0664e8c4d8694403fc14b92d3ac36d9", "parents": [ "ac395e11682189678206cbf8210e127c6ca3b6ec" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Wed May 29 16:10:43 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 29 16:19:37 2024" }, "message": "Reland \"Rewrite previously excluded raw_ptr fields\"\n\nThis is a reland of commit 8a98a9bad2a2f3fc9a7a8e34092e95b6d4705b2a\n\nPatchSet1 is the original change\nLater patchsets are additional fixes.\n\nThe initial change was reverted due to compilation failure detected on\n`linux-asan-media-v8-arm-rel`. This is due to `off_t` type being\n`long long` in this configuration and due to raw_ptr not allowing\npointer arithmetic with such types.\n\nOriginal change\u0027s description:\n\u003e Rewrite previously excluded raw_ptr fields\n\u003e\n\u003e This rewrites pointers to byte buffers that were accidentally skipped by\n\u003e the rewriter. In addition to skipping string literals, the rewriter was\n\u003e wrongly skipping byte buffers.\n\u003e\n\u003e DanglingUntriaged-notes: Annotating pre-existing dangling pointers.\n\u003e Bug: 331840473\n\u003e Change-Id: I1845d17a5edffeeb94150e17afb2166b889f4c9d\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497157\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Owners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Reviewed-by: Frank Liberato \u003cliberato@chromium.org\u003e\n\u003e Reviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Commit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1306660}\n\nBug: 331840473\nChange-Id: I0a4222f60804e528db3ace4a3d637d6d08f1994d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5575382\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Frank Liberato \u003cliberato@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1307468}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f5d8b7440713112f54f04fd94180897c76497422\n" }, { "commit": "ac395e11682189678206cbf8210e127c6ca3b6ec", "tree": "b8412e1881cd1152f52a6e7a89fc1474ff2d231a", "parents": [ "26974c86df7d163f4c6b99bc08ba1d3569aae8a4" ], "author": { "name": "luci-bisection@appspot.gserviceaccount.com", "email": "luci-bisection@appspot.gserviceaccount.com", "time": "Tue May 28 10:14:07 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 28 10:20:45 2024" }, "message": "Revert \"Rewrite previously excluded raw_ptr fields\"\n\nThis reverts commit 8a98a9bad2a2f3fc9a7a8e34092e95b6d4705b2a.\n\nReason for revert:\nLUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8746706113493454977\n\nSample failed build: https://ci.chromium.org/b/8746706113493454977\n\nIf this is a false positive, please report it at http://b.corp.google.com/createIssue?component\u003d1199205\u0026description\u003dAnalysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5497157\u0026format\u003dPLAIN\u0026priority\u003dP3\u0026title\u003dWrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8746706113493454977\u0026type\u003dBUG\n\nOriginal change\u0027s description:\n\u003e Rewrite previously excluded raw_ptr fields\n\u003e\n\u003e This rewrites pointers to byte buffers that were accidentally skipped by\n\u003e the rewriter. In addition to skipping string literals, the rewriter was\n\u003e wrongly skipping byte buffers.\n\u003e\n\u003e DanglingUntriaged-notes: Annotating pre-existing dangling pointers.\n\u003e Bug: 331840473\n\u003e Change-Id: I1845d17a5edffeeb94150e17afb2166b889f4c9d\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497157\n\u003e Reviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Owners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\n\u003e Reviewed-by: Frank Liberato \u003cliberato@chromium.org\u003e\n\u003e Reviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\n\u003e Commit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1306660}\n\u003e\n\nBug: 331840473\nChange-Id: Ibea32e36178bd8161e69855ab9194d2f65fba677\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5573454\nBot-Commit: luci-bisection@appspot.gserviceaccount.com \u003cluci-bisection@appspot.gserviceaccount.com\u003e\nCommit-Queue: luci-bisection@appspot.gserviceaccount.com \u003cluci-bisection@appspot.gserviceaccount.com\u003e\nOwners-Override: luci-bisection@appspot.gserviceaccount.com \u003cluci-bisection@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1306670}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1c7549731b0de0e41f52b32c7a60ee50c39cf763\n" }, { "commit": "26974c86df7d163f4c6b99bc08ba1d3569aae8a4", "tree": "8910033ab0664e8c4d8694403fc14b92d3ac36d9", "parents": [ "d23361bcdf007ea2b224ba9dad8ac6a05c0d4e5e" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Tue May 28 09:17:01 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 28 09:24:47 2024" }, "message": "Rewrite previously excluded raw_ptr fields\n\nThis rewrites pointers to byte buffers that were accidentally skipped by\nthe rewriter. In addition to skipping string literals, the rewriter was\nwrongly skipping byte buffers.\n\nDanglingUntriaged-notes: Annotating pre-existing dangling pointers.\nBug: 331840473\nChange-Id: I1845d17a5edffeeb94150e17afb2166b889f4c9d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497157\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Frank Liberato \u003cliberato@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1306660}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8a98a9bad2a2f3fc9a7a8e34092e95b6d4705b2a\n" }, { "commit": "d23361bcdf007ea2b224ba9dad8ac6a05c0d4e5e", "tree": "b8412e1881cd1152f52a6e7a89fc1474ff2d231a", "parents": [ "ee484f3c101657558a83a67e84930486db9e99b7" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Thu May 16 23:41:33 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 16 23:50:19 2024" }, "message": "Use NOTREACHED_IN_MIGRATION() in the rest of src/\n\nThis was generated by replacing \" NOTREACHED()\" with\n\" NOTREACHED_IN_MIGRATION()\" and running git cl format.\n\nThis prepares for making NOTREACHED() [[noreturn]] alongside\nNotReachedIsFatal migration of existing inventory.\n\nthird_party/crashpad is still excluded, needs to be changed upstream.\n\nBug: 40580068\nChange-Id: Ia5dbaddf53dba2fedefb67f1d428e8b24e9edffe\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545021\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nAuto-Submit: Peter Boström \u003cpbos@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1302314}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7843eba21442cc636a76d546ca6ea69aacfd621f\n" }, { "commit": "ee484f3c101657558a83a67e84930486db9e99b7", "tree": "47f5c0653af4eced7caa16478ff130d43a2b9071", "parents": [ "8400710843d51024378d7b2a33f2061d8d324785" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Mon Feb 26 10:21:17 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 26 10:44:46 2024" }, "message": "Extend MiraclePtr coverage to more containers\n\nThis rewrites the following containers:\nstd::list, std::unordered_set, base::flat_set, std::stack, std::queue.\n\nThis patch was generated by running\n./tools/clang/rewrite_templated_container_fields/rewrite-multiple-platforms.sh\n\nBinary size increase:\nThe increase is only (~9.5kB) above the per-patch limit (+16kB). This\nis not a lot given the size of the rewrite. Increase of around 500kb was\napproved for MiraclePtr.\n\nAX-Relnotes: n/a.\nBinary-Size: See commit description.\nBug: 325302189\nChange-Id: I969ae345ef6d6117d5c1773773be913197ca2e73\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5306923\nReviewed-by: Kentaro Hara \u003charaken@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1265100}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a56154dd81e4679712422ac6eed2c9581cb51ab0\n" }, { "commit": "8400710843d51024378d7b2a33f2061d8d324785", "tree": "b2ed72615768573e341792200ac167254608657c", "parents": [ "99416a5cb6df1a28febe5241afb663efd9ccfaf6" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Fri Feb 09 14:01:52 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 09 14:08:59 2024" }, "message": "Rewrite std::set\u003cT*\u003e into std::set\u003craw_ptr\u003cT, SetExperimental\u003e\u003e\n\nThis patch was generated by running\n./tools/clang/rewrite_templated_container_fields/rewrite-multiple-platforms.sh\n\nAX-Relnotes: n/a.\nBug: 41486235\nChange-Id: If9280b93e10508add3c9842f2b2ae190bb65c364\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272231\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1258472}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 133b2d903fa57cfda1317bc589b349cf4c284b7c\n" }, { "commit": "99416a5cb6df1a28febe5241afb663efd9ccfaf6", "tree": "d4ca238c31d24a89a6d30562104fc8791672273f", "parents": [ "31c422fa4ccc7ed6dd7cc73887d535d68e5d8524" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Thu Jan 04 20:32:28 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 04 20:41:22 2024" }, "message": "Replace logging::LOG_VERBOSE with LOGGING_\n\nOld alias is deprecated. Will be removed in a separate CL to avoid\nbroader rollbacks in case I missed one or this is inadvertently used\noutside src/.\n\nBug: 849450\nChange-Id: I68a93545c5fee4fda1833e3e28e47907bb0af1da\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5168977\nAuto-Submit: Peter Boström \u003cpbos@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1243086}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cc8bffa406e0fcd70f57118828805b9a5104f030\n" }, { "commit": "31c422fa4ccc7ed6dd7cc73887d535d68e5d8524", "tree": "10a4fe77e6793ce74eadecb1a8021e6d624e40d3", "parents": [ "28f4a2a04f197d8561d76fd1b77bfbfa5a0b9b1e" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Wed Dec 20 19:29:35 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 20 19:47:24 2023" }, "message": "Rewrite vector\u003cT*\u003e into vector\u003craw_ptr\u003cT, VectorExperimental\u003e\u003e\n\nSee chromium-dev announcement:\nhttps://groups.google.com/a/chromium.org/g/chromium-dev/c/sKckMpzHQgY/m/M3SWxEg3AQAJ?utm_medium\u003demail\u0026utm_source\u003dfooter\n\nCode review:\n- First patch: Automatic rewrite\n- Later patches: Manual fixes\n\nThe automatic rewrite used the script:\n./tools/clang/rewrite_templated_container_fields/rewrite-multiple-platforms.sh\n\nBinary size increase:\nThe increase is only 33% (+5kB) above the per-patch limit (+16kB). This\nis not a lot given the size of the rewrite. Increase of around 500kb was\napproved for MiraclePtr.\n\nAX-Relnotes: n/a.\nBinary-Size: See commit description.\nBug: 1432993\nChange-Id: I8dfc4c2b274b724b99cf408f010da5c821edae9c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5140028\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1239777}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e63cbaf6fdcfdac0f04883d956b00e83330bd0a2\n" }, { "commit": "28f4a2a04f197d8561d76fd1b77bfbfa5a0b9b1e", "tree": "023f9ab162da47172af4be24ad89007c5ce07b10", "parents": [ "61bdefb0fed799eddd4c16d1e7ab6532d52d8051" ], "author": { "name": "Ho Cheung", "email": "uioptt24@gmail.com", "time": "Thu Oct 19 14:05:38 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 19 14:11:45 2023" }, "message": "[base] Rename DIR_SOURCE_ROOT to DIR_SRC_TEST_DATA_ROOT\n\nBug: 1264897\nChange-Id: I8946189f4cf2ad19dfd6cc73df97cbd645e2d417\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4952181\nReviewed-by: Finnur Thorarinsson \u003cfinnur@chromium.org\u003e\nReviewed-by: Michael Lippautz \u003cmlippautz@chromium.org\u003e\nCommit-Queue: Ho Cheung \u003cuioptt24@gmail.com\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1212132}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e63a0e8aaf7e8246de5c93f582204cde04474de0\n" }, { "commit": "61bdefb0fed799eddd4c16d1e7ab6532d52d8051", "tree": "d2af5d11bf0b46fbf473896da0183370b3587493", "parents": [ "4be30bd365910a908af7e9bcbeb7d700307ff6a5" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Tue Sep 19 00:10:00 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 19 00:16:41 2023" }, "message": "Ban raw_ptr\u003cT\u003e::operator[] under enable_pointer_arithmetic_trait_check.\n\nTreat operator[] the same as, say, operator+\u003d when the specific\nBUILDFLAG is set.\n\n-- fix instances thus uncovered.\n\nChange-Id: Ic436875af87b0ca922b5e344753cc8a6acee4aa5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4834929\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1198100}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d83ed1b22705801b8e6d171a46735034430ec420\n" }, { "commit": "4be30bd365910a908af7e9bcbeb7d700307ff6a5", "tree": "5c1b3aa86fd9a6c8b7a6c69d4ca76c7a62352dbd", "parents": [ "7a3c3a70f4216d1163f9c347b41df1eae2c08f64" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Thu Aug 03 17:11:07 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 03 17:28:49 2023" }, "message": "Ban [w]ctype.h: courgette/\n\nBug: 1361094\nChange-Id: I2fcf44bee7c60b8035cd36ca8c07e250a1cbf9bb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4749519\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1179105}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f3ee66317a9c9d19af1c30b580eb115f7867e1c9\n" }, { "commit": "7a3c3a70f4216d1163f9c347b41df1eae2c08f64", "tree": "14dc98b6ae0d545e2f565dec0836f1b3422f9327", "parents": [ "f51f672a20348497ecf57f2473e0908d2f829551" ], "author": { "name": "Anne Redulla", "email": "aredulla@google.com", "time": "Fri Jul 07 03:12:39 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 07 03:28:37 2023" }, "message": "[ssci] Add Shipped field to READMEs\n\nThis CL adds the Shipped field and updates the\nLicense File field in Chromium READMEs within the\ndirectory /courgette.\n\nSee the LSC doc at go/lsc-chrome-metadata.\n\nThis CL was uploaded by git cl split.\n\nR\u003dhuangs@chromium.org\n\nBug: b:285450740\nChange-Id: Ibd17e694f5b7aa08b853fc0f4ce4417d71eddc71\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4656604\nCommit-Queue: Anne Redulla \u003caredulla@google.com\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1166995}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b19e1a54775fcc8e7dd7bffc24ca94c91220db8f\n" }, { "commit": "f51f672a20348497ecf57f2473e0908d2f829551", "tree": "c4b1093df4f873613faabb3c103ee7e482e65d09", "parents": [ "13e232701b9c7445d60131cd55a18bcc28ccdeba" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Jun 01 15:02:25 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 01 15:09:44 2023" }, "message": "DanglingPointer: annotate for unittests base+linux [1/N]\n\nThe DanglingPointerDetector is configured only when the test enters the\nContentMain function. See https://crbug.com/1400059\n\nI would like to configure it no matter the kind of test. For this to\nhappen, we need to annotate every pre-existing dangling pointers.\n\nThis patch annotates the ones you can find by running targets depending\non the GoogleTest library.\n\nStatistic:\n\nThis adds 1776 new DanglingUntriaged. Among them:\n- 1288 are in unittests.\n- 488 are in implementation.\n\nTo produce those numbers, I used the command:\n```bash\ngit diff annotate-linux origin/main -- \"*test*\" | grep \"DanglingUntriaged\" | wc -l\n```\n\nThis patch has been generated by:\n\n1. Apply the \"auto-annotator\" patch:\n https://chromium-review.googlesource.com/c/chromium/src/+/4474553\n\n2. Compile the compiler again:\n ```bash\n ./tools/clang/scripts/build.py\n ```\n\n3. List and run all the targets. You can use a bash script like:\n https://docs.google.com/document/d/1AMMERcqy0eafFWopUCHYsIKIKEp3J8DFxqW9UIbzIHo\n\n4. Concatenate output, filter by \"Found dangling ptr\", sort, remove\n duplicate.\n\n5. Apply the rewriter script from:\n https://github.com/ArthurSonzogni/chrome-dangling-ptr-apply-edit\n\n6. Revert the \"auto-annotate\" patch.\n\n7. Apply `git cl format`\n\nAX-Relnotes: n/a.\nBug: chromium:1400059\nChange-Id: I217d5c0b925da5176fc53baf95919a3690f1e9a3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4570424\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1151859}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e98d214c48dd94a2b4363b384e952a32258b9487\n" }, { "commit": "13e232701b9c7445d60131cd55a18bcc28ccdeba", "tree": "b850a91a5fcde930f2a9f39baa22e15e7625051a", "parents": [ "9affbf48e9f1712e60299d8bdb40294192452b7a" ], "author": { "name": "Claudio DeSouza", "email": "cdesouza@igalia.com", "time": "Sat Feb 25 17:40:39 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Feb 25 17:46:53 2023" }, "message": "Switch to simpler base::WriteFile() variants (106/N)\n\nThis CL is part of a batch of CLs to replace the use of the less\nfriendly base::WriteFile call with simpler variants, which are easier to\nread, and less prone to mistakes.\n\nChanges in this particular CL address files under the path\n/courgette.\n\nThis CL was uploaded by git cl split.\n\nR\u003dhuangs@chromium.org\n\nAX-Relnotes: n/a.\nBug: 418837\nChange-Id: I36a5a4ac2d8e4069c74f9dafd9e371a67ebb0986\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4292056\nAuto-Submit: Claudio DeSouza \u003ccdesouza@igalia.com\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1110012}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e2447a36abdc27d6f7f0fa221242f93e93c27b38\n" }, { "commit": "9affbf48e9f1712e60299d8bdb40294192452b7a", "tree": "1162ee18c9ea005376bce5d90b50085cf6712f0d", "parents": [ "f2167e2ec707b79e808e3c23385cceb8489d726a" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Feb 15 19:08:11 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 15 19:15:30 2023" }, "message": "Introduce the raw_ptr attribute AllowPtrArithmetic.\n\nThis will help flag places that are better suited for conversions\nto span\u003c\u003e or other containers and prevent the growth of new usages.\n\nThis CL flags the places that require pointer arithmetic, but stops\nshort of banning it entirely. A future CL will refuse to compile\npointer arithmetic against raw_ptrs that lack this attribute.\n\nChange-Id: Iff4a671280930df6eeacb04ff52dfa863da2b1dc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4229951\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1105779}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 09c200aef72e385f9549cdf21f14c1c15d90558b\n" }, { "commit": "f2167e2ec707b79e808e3c23385cceb8489d726a", "tree": "b4c9eba3e3552200e646c388756a7e18f8432a49", "parents": [ "6bdfc75f21d750ca3ded4aaed585df41936b62f1" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Wed Jan 11 04:37:36 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 11 04:45:44 2023" }, "message": "Update header includes for /base/functional in /c*\n\nbind.h, callback.h, callback_forward.h, and callback_helpers.h\nmoved into /base/functional/. Update the include paths to\ndirectly include them in their new location.\n\nBug: 1364441\nChange-Id: Ibc92b83a27071234ba27789cffa3d31f873dfde6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4150993\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1091177}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 710fdab691deb78c181b67e0d74d34d623476b6e\n" }, { "commit": "6bdfc75f21d750ca3ded4aaed585df41936b62f1", "tree": "41f7c2c7c62d934d4e8ef94788f699d8059e49fa", "parents": [ "a62bea22070f6d228ca2320ce8e1bf5a25da4c43" ], "author": { "name": "Keishi Hattori", "email": "keishi@chromium.org", "time": "Tue Nov 22 09:04:26 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 22 09:09:01 2022" }, "message": "[BRP] Apply raw_ptr rewriter\n\nRewrites generated by running the raw_ptr rewriter (win/android)\non ecf579231eacc3e22f6a07e747cb9aa15ffc368d\n\nPS1: generated rewrite\nPS2-PS5: manual build fixes and additional exclusions\nPS6: rebase\n\nBinary-Size: This is a batch rewrite so size increase is unavoidable\nChange-Id: I23b244e715d6dcf559ce2df9cc8dc97ec9227fca\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4044201\nOwners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCommit-Queue: Keishi Hattori \u003ckeishi@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1074510}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c1b0023f5a06aea9c7659b313b35ecc0d3d7e707\n" }, { "commit": "a62bea22070f6d228ca2320ce8e1bf5a25da4c43", "tree": "309d14082b74468e7de1fec4f37610703ea7b386", "parents": [ "56cc4babc70c46db7b92a37118d2112991f76e75" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Wed Nov 09 19:00:13 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 09 19:06:25 2022" }, "message": "win: Get rid of courgette.exe\n\nThere\u0027s an old TODO about moving from courgette.exe to courgette64.exe.\nSee if we can actually do it!\n\nCq-Include-Trybots: luci.chromium.try:win-official,win32-official\nCq-Include-Trybots: luci.chrome.try:win-chrome\nBug: 629243,1382256\nChange-Id: I26dfa10e68e115359a908cecc8f08db26b1f459c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4013527\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1069263}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 10767ac0a15bf970a1f3588b5ba774e2b023e5d4\n" }, { "commit": "56cc4babc70c46db7b92a37118d2112991f76e75", "tree": "4611e94a84ff3443270db5cc1886ce5be38dfc9a", "parents": [ "ce40cd6a25ece7fbd3c8019e5f0fda6b62dda206" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Wed Nov 09 16:28:51 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 09 16:35:23 2022" }, "message": "Rewrite T\u0026 into raw_ref\u003cT\u003e under multiple directories [1]\n\nThe changes were generated by running\ntools/clang/rewrite_raw_ref_fields/rewrite-multiple-platforms.sh with\ntool-arg\u003d--enable_raw_ref_rewrite\n\n`raw_ref` is a smart pointer for a pointer which can not be null, and\nwhich provides Use-after-Free protection in the same ways as raw_ptr.\nThis class acts like a combination of std::reference_wrapper and\nraw_ptr.\n\nSee raw_ptr and //base/memory/raw_ptr.md for more details on the\nUse-after-Free protection.\n\nBug: 1357022\nChange-Id: Ibcd714bd5a8e408aa31f07a04c5fc67f7eff4e3e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4001524\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1069181}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5517919606cb0431bb3a72e874c6080280e20c79\n" }, { "commit": "ce40cd6a25ece7fbd3c8019e5f0fda6b62dda206", "tree": "e8609199a9e5a8e6a34f9c81d7f2d3e48d8738ad", "parents": [ "2d72a5c503a7348c01de7b00fbb2261299da96fd" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Wed Nov 09 00:55:50 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 09 01:01:53 2022" }, "message": "courgette: Simplify courgette64 toolchain computation\n\nis_clang is always true in Chromium on Windows.\n\nNo behavior change.\n\nCq-Include-Trybots: luci.chromium.try:win-official,win32-official\nCq-Include-Trybots: luci.chrome.try:win-chrome\nChange-Id: I45307b10bc6af89e3db70ca73f8d302620cb5ad1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4014001\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1068905}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 33f064f70888689d462da7dd523089c358c5216f\n" }, { "commit": "2d72a5c503a7348c01de7b00fbb2261299da96fd", "tree": "c798136e6ee6ccfd452813859591418bcc2bffc4", "parents": [ "944d7a94966234a657705072f284ee03f460ac86" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Oct 28 16:05:55 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 28 16:11:23 2022" }, "message": "Convert std::copy() to base::ranges::copy().\n\nBug: 1368812\nChange-Id: I87aeca909203860f3d7aa0b535f2e816eb9f30b9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3988852\nReviewed-by: Yuchen Liu \u003cyucliu@chromium.org\u003e\nReviewed-by: Vasiliy Telezhnikov \u003cvasilyt@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1064863}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 51b3c4fd33f20f01ebc4aac3f92cd309564b8726\n" }, { "commit": "944d7a94966234a657705072f284ee03f460ac86", "tree": "272a94834d411e16a5fe713c6100a777da34573c", "parents": [ "a81e522b2287ae71c724df97a2224633525615a1" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Thu Oct 20 22:59:31 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 20 23:07:00 2022" }, "message": "DanglingPtr: Mark all of them as untriaged [1/N]\n\nThis patch must be a no-op with all the common build flags.\n\nAdd the \"DanglingUntriaged\" raw_ptr annotation. It indicates a\nraw_ptr becomes dangling, and it should be triaged/fixed. This will also disable dangling protection for those pointers, once enabled.\n\nThese were identified by running the CQ bots with DPD activated (both build + runtime here: https://crrev.com/c/3941825)\n\nBug: 1291138\nChange-Id: I07e3d85b1c629f7d49c928f1fca42a538c64ef3b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3959615\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Pâris Meuleman \u003cpmeuleman@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1061867}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4d4e24099b3bdced741623fd4e96aaf444809994\n" }, { "commit": "a81e522b2287ae71c724df97a2224633525615a1", "tree": "f28a00b7fccf28c506189329e8e0df90449b552e", "parents": [ "7c9fdbbd3f8b4b1e580ffaa4f5efc8154bfdc307" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Tue Sep 13 18:35:42 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 13 18:54:35 2022" }, "message": "Update copyright headers in courgette/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c34.\n\nNo-Try: true\nBug: 1098010\nChange-Id: I4906567a2210f349041e6414f0b7f7821e5b997b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3894152\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nCommit-Queue: Mark Mentovai \u003cmark@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1046474}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0ff8a7e8eebe43501002995bc1262f249df8b7ad\n" }, { "commit": "7c9fdbbd3f8b4b1e580ffaa4f5efc8154bfdc307", "tree": "a0bd651805e0bacdaea871e2ffa1b3155d725973", "parents": [ "138ad0bf68d4c0c701735109838e62ccb52b1515" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Tue Aug 30 17:06:50 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 30 17:16:28 2022" }, "message": "Change calls to std::{all,any,none}_of() to base:: functions: courgette/\n\nThis generally allows for slightly shorter, simpler calls, and in some\ncases more clearly expresses the intent of the underlying code.\n\nBug: none\nChange-Id: I3c7c51f292dfe99a794c7c19e7704eec7ab7ea3d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3863396\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1041042}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 266c4f87ca428c8bffdd5b116280c67c69af536e\n" }, { "commit": "138ad0bf68d4c0c701735109838e62ccb52b1515", "tree": "13cbb3133ab7519cf991ea2ec2d880c0b03a29c3", "parents": [ "b12cd4f78360d81b1564e9d84b324c53472021a9" ], "author": { "name": "Kentaro Hara", "email": "haraken@chromium.org", "time": "Wed Aug 24 06:58:01 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 24 07:12:47 2022" }, "message": "Remove inactive owners from /courgette\n\nPer discussion on the chromium-dev@ thread [1], we remove owners who made\n0 commits / reviews to the Chromium repository in the past 12 months\n(2021/7/26 - 2022/7/26).\n\nFor each owner removal, we upload a CL to remove the owner. The CL adds the\nowner being removed and two other owners as reviewers. The CL will be\ncommitted once it gets an LGTM from one of the reviewers.\n\nInstructions:\n\n- The guiding principle is: only owners who are meeting the owner\u0027s\nexpectations [2] should be written in OWNERS files. This is important to\nensure that developers can find active owners by looking at the OWNERS files.\n- Please LGTM or not-LGTM the CL based on the removal guideline [3]. i.e.,\nif the owner being removed was inactive only for a certain period of time\nwhile they were on a long leave and has been meeting the owner\u0027s expectations\nin other times, please not-LGTM the CL. Otherwise, please LGTM the CL.\n- If the CL was LGTMed and landed by mistake (e.g., the reviewer was not aware\nof the owner\u0027s leave status), we can just revert the CL.\n- If you have any questions / comments, please send an explicit email to\nharaken@chromium.org. (haraken@ is not watching all the comments of all the\nremoval CLs :-) If there is any disagreement between owners, it will be\nescalated to Chrome Eng Review and resolved per [3].\n\n[1] https://groups.google.com/a/chromium.org/g/chromium-dev/c/aGC8BTTFK64\n[2] https://chromium.googlesource.com/chromium/src/+/main/docs/code_reviews.md#expectations-of-owners\n[3] https://chromium.googlesource.com/chromium/src/+/main/docs/code_reviews.md#removal-of-owners\n\nThis CL was uploaded by git cl split.\n\nR\u003dhuangs@chromium.org, sra@chromium.org, tommi@chromium.org\n\nBug: 1355150\nChange-Id: I008296bba2c593d9fec2c225c2428f98076df5d6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3844624\nReviewed-by: Tomas Gunnarsson \u003ctommi@chromium.org\u003e\nAuto-Submit: Kentaro Hara \u003charaken@chromium.org\u003e\nCommit-Queue: Kentaro Hara \u003charaken@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1038614}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8ed04461fc1204ce5cd43dc7801c5a7083a7e990\n" }, { "commit": "b12cd4f78360d81b1564e9d84b324c53472021a9", "tree": "d51ee3bb854242a55ceabc349c594442bdc5b979", "parents": [ "297c32c2e1026dabb5061afdbe5d0e61e4467e39" ], "author": { "name": "Michael Chang", "email": "donchan@microsoft.com", "time": "Fri Jul 01 19:15:57 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 01 19:26:26 2022" }, "message": "Clean-up //third_party/lzma_sdk folder\n\nAs part of updating the lzma_sdk, clean up the folders and put them into different subfolders. This puts the files in a more similar\norganization to the original lzma sdk. Fix up other files to have\ncorrect includes.\n\nBug: 1334732\nChange-Id: If345eee3ae1b81f1de804b289880ea5755def49f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3727278\nCommit-Queue: Dong Sung Chang \u003cdonchan@microsoft.com\u003e\nReviewed-by: Joshua Pawlicki \u003cwaffles@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: David Roger \u003cdroger@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1020195}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3fa36902563c565b6c1e7811b7e431a533529a82\n" }, { "commit": "297c32c2e1026dabb5061afdbe5d0e61e4467e39", "tree": "8afb8440dea4b593c6612712007200fb11fc3e58", "parents": [ "528f9ed5d0305baf721bf7e55b84d172d5f47086" ], "author": { "name": "Arthur Eubanks", "email": "aeubanks@google.com", "time": "Tue Mar 29 17:56:00 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 29 18:07:03 2022" }, "message": "Remove set but otherwise unused variables\n\nRecent Clang versions have enhanced -Wunused-but-set-variable which now\nwarns about these.\n\nBug: 1309955\nChange-Id: Ie4e2efd0bbb23be246597fed516f8d30201507ce\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556182\nAuto-Submit: Arthur Eubanks \u003caeubanks@google.com\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#986584}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 99ed352bd87c3b217c44edd5978c6de693525cb0\n" }, { "commit": "528f9ed5d0305baf721bf7e55b84d172d5f47086", "tree": "8cf54d0e3531f9cca7f9fada2c4363e61aa0e34a", "parents": [ "bab791744a6b5de47873b70c4dea4daa2c2ac143" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon Mar 21 19:44:06 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 21 19:54:39 2022" }, "message": "Avoid including base/files/file_util.h in some headers.\n\nRarely would anyone ever use base/files/file_util.h functions inside a\nheader. Most code authors meant to include base/files/file_path.h or\nforward declare base::FilePath. Do that and then add missing file_util.h\nincludes to fix the build.\n\nBug: 242216\nChange-Id: I6280125f310cff0db1109c401d84e01aba386376\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3518311\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#983450}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 527964a214baed4f325c0d7751bfc527ba10bf34\n" }, { "commit": "bab791744a6b5de47873b70c4dea4daa2c2ac143", "tree": "4c87a3a8e60a77eff3f8dc03c21d1ffca39b3ad7", "parents": [ "98e99555c921979266119159b0c571bed370ed21" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Mon Feb 28 04:19:32 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 28 04:30:23 2022" }, "message": "Migrate base::{size,empty,data} to STL equivalents in //courgette.\n\nBug: 1299695\nChange-Id: Ic9b64dd3fde16a19d7ab6cc35fc621c095e1408d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3493825\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#975652}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 08601f802946b627c2dda924f42491f6f07c3a7c\n" }, { "commit": "98e99555c921979266119159b0c571bed370ed21", "tree": "124d8aee4ebd8fd24dddca14a8e044eca38711e9", "parents": [ "256253df0e7b2b5d2243a6781e1ac4702ae22eba" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Wed Feb 09 16:35:14 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 09 16:44:30 2022" }, "message": "[fuchsia] Make CFv2 the default for tests.\n\nThe default for `use_cfv2` is now `true`. Tests may opt-out by setting\nit to `false.` Tests are still built/run as CFv1 components if:\n\n- They use fuchsia.sys.Launcher (skia_unittests and gfx_unittests).\n- They use additional_manifest_fragments (many).\n\nThese will be migrated to CFv2 as their fragments (and their respective\nrequired capabilities) are migrated to CFv2.\n\nBug: 1256502\nChange-Id: I3ef514d997da29bf4ce80d17b7afa57bbdb107e7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3447303\nReviewed-by: Wez \u003cwez@chromium.org\u003e\nOwners-Override: Wez \u003cwez@chromium.org\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#968954}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5e4f41f35818752083da28bb5b981762bf21e2a1\n" }, { "commit": "256253df0e7b2b5d2243a6781e1ac4702ae22eba", "tree": "f622301208ad407efc4806cd0d3d149b7aa6b01a", "parents": [ "aab26e6da0201becf15c8f99b214e9cc934b8700" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Mon Feb 07 00:26:24 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 07 00:34:55 2022" }, "message": "Revert \"[fuchsia] Revert unit tests back to v1 Components\"\n\nThis reverts commit 4611979ec73c291aa39555583d4858a0b7cabada.\n\nReason for revert: build-info is now routed to tests in the \"chromium\" realm.\n\nOriginal change\u0027s description:\n\u003e [fuchsia] Revert unit tests back to v1 Components\n\u003e\n\u003e Due to https://crbug.com/1291318, v2 test Components cannot access the\n\u003e build-info service. Temporarily revert back to v1 until the issue is\n\u003e resolved.\n\u003e\n\u003e This effectively reverts the behavior change in\n\u003e https://crrev.com/c/3306403 while leaving all the logic.\n\u003e\n\u003e Bug: 1291318, 1275791\n\u003e Change-Id: I9d164bcf84be8ed5d9eefb34b7d0d67dab5c2640\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3418921\n\u003e Reviewed-by: Kevin Marshall \u003ckmarshall@chromium.org\u003e\n\u003e Reviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\n\u003e Reviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\n\u003e Reviewed-by: Wez \u003cwez@chromium.org\u003e\n\u003e Commit-Queue: Wez \u003cwez@chromium.org\u003e\n\u003e Owners-Override: Wez \u003cwez@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#963930}\n\nBug: 1291318, 1275791\nChange-Id: Id238307a40daa98439b1b5631dc1a73740268db5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3429279\nReviewed-by: Wez \u003cwez@chromium.org\u003e\nReviewed-by: Eric Seckler \u003ceseckler@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Kevin Marshall \u003ckmarshall@chromium.org\u003e\nReviewed-by: David Dorwin \u003cddorwin@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#967628}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 93a45b65dcb6f3ac49b9f572ffe49234979c4916\n" }, { "commit": "aab26e6da0201becf15c8f99b214e9cc934b8700", "tree": "dd37ef2a34be1ffb76858f275a440d5cd646c493", "parents": [ "2b5d087da660ea24eea837195da126a842a5f767" ], "author": { "name": "David Dorwin", "email": "ddorwin@chromium.org", "time": "Thu Jan 27 08:19:41 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 27 08:33:03 2022" }, "message": "[fuchsia] Revert unit tests back to v1 Components\n\nDue to https://crbug.com/1291318, v2 test Components cannot access the\nbuild-info service. Temporarily revert back to v1 until the issue is\nresolved.\n\nThis effectively reverts the behavior change in\nhttps://crrev.com/c/3306403 while leaving all the logic.\n\nBug: 1291318, 1275791\nChange-Id: I9d164bcf84be8ed5d9eefb34b7d0d67dab5c2640\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3418921\nReviewed-by: Kevin Marshall \u003ckmarshall@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Greg Thompson \u003cgrt@chromium.org\u003e\nReviewed-by: Wez \u003cwez@chromium.org\u003e\nCommit-Queue: Wez \u003cwez@chromium.org\u003e\nOwners-Override: Wez \u003cwez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#963930}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4611979ec73c291aa39555583d4858a0b7cabada\n" }, { "commit": "2b5d087da660ea24eea837195da126a842a5f767", "tree": "f622301208ad407efc4806cd0d3d149b7aa6b01a", "parents": [ "11c1f14a8fcf087f00bb3293b4b8db41998b2132" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Wed Jan 26 20:56:26 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 26 21:29:36 2022" }, "message": "Clean up uses of (void)\n\nThis migrates uses of (void) to [[maybe_unused]] or std::ignore as\nappropriate.\n\nThis CL was uploaded by git cl split.\n\nR\u003dtommi@chromium.org\n\nBug: 1289456\nChange-Id: I2970b5998d5ff272158a73978a244ccff81199ba\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3415895\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Tomas Gunnarsson \u003ctommi@chromium.org\u003e\nCommit-Queue: Tomas Gunnarsson \u003ctommi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#963689}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 18e2819ba4c519390af76a1caf4133098cdcfa02\n" }, { "commit": "11c1f14a8fcf087f00bb3293b4b8db41998b2132", "tree": "279185455a3f33f6f49db6f1940fd0c50f62a9d3", "parents": [ "fd1ee79b90c0bae2a478daa5a9b462939d1d08e1" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Wed Jan 26 09:17:45 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 26 09:31:07 2022" }, "message": "[fuchsia] Migrate some tests to CFv2.\n\nThe following tests are now built/run as CFv2 tests:\n\n- base:base_unittests\n- courgette:courgette_unittests\n- headless:headless_unittests\n- ipc:ipc_tests\n\nIn so doing:\n\n- All tests, when opting-in to CFv2, now include a cml shard that puts\n them into the \"system\" test realm. This gives all tests access to\n /config/data, which is required by base::i18n.\n- minimum_capabilities.test-cml is renamed to minimum.shard.test-cml for\n consistency with other CFv2 manifest sources.\n\nBug: 1256502\nChange-Id: I6c38e51dd5c78521d2f961086561c887e5ff1b20\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306403\nReviewed-by: Eric Seckler \u003ceseckler@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Wez \u003cwez@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#963439}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f31d7d26f246fa0450be7c24fa15e03bf242639b\n" }, { "commit": "fd1ee79b90c0bae2a478daa5a9b462939d1d08e1", "tree": "c1e8ffe57799dd471c80ff334e1e4b88cc4b9f4c", "parents": [ "cef057e487bbfebb0a08c6582ac3d7b8906ffba1" ], "author": { "name": "Xiaohan Wang", "email": "xhwang@chromium.org", "time": "Sat Jan 22 01:04:01 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jan 22 01:14:51 2022" }, "message": "misc4: Use BUILDFLAG for OS checking\n\nUse // BUILDFLAG(IS_XXX) instead of // OS_XXX.\n\nGenerated by `os_buildflag_migration.py` (https://crrev.com/c/3311983)\nwith modifications.\n\nR\u003dthakis@chromium.org\n\nBug: 1234043\nChange-Id: Ibcf60c672ab3167ddad14656bff27378e67f3975\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3408124\nCommit-Queue: Xiaohan Wang \u003cxhwang@chromium.org\u003e\nAuto-Submit: Xiaohan Wang \u003cxhwang@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#962181}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 64dc570e00d7bed0381134d8b474d0c2acd5a180\n" }, { "commit": "cef057e487bbfebb0a08c6582ac3d7b8906ffba1", "tree": "e8ea957cb4950ed82ccc009aeb8ad9eec67aaf2a", "parents": [ "5d570b833a054cee99355d6172480bc1189c156b" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Fri Jan 14 14:39:55 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 14 14:48:50 2022" }, "message": "Convert WARN_UNUSED_RESULT to [[nodiscard]] in //courgette.\n\nThis is an automated conversion produced by the script and command in\nthe attached bug.\n\nBug: 1287045\nChange-Id: I9217c39f13991966e35ea1c4fc02e4229f7bf595\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3387499\nAuto-Submit: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#959153}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8021cefa5e6478f2713fbf0f4b276d9c1588c36d\n" }, { "commit": "5d570b833a054cee99355d6172480bc1189c156b", "tree": "382e93f5c86022a43c702ef5f1b165fe73394baf", "parents": [ "7e662c9ab6e099d5ca879f9c8f20a8d51ee847f2" ], "author": { "name": "Xiaohan Wang", "email": "xhwang@chromium.org", "time": "Sat Jan 08 01:23:27 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jan 08 01:33:58 2022" }, "message": "courgette: Use BUILDFLAG for OS checking\n\nUse BUILDFLAG(IS_XXX) instead of defined(OS_XXX).\n\nGenerated by `os_buildflag_migration.py` (https://crrev.com/c/3311983).\n\nR\u003dthakis@chromium.org\n\nBug: 1234043\nTest: No functionality change\nChange-Id: Iafa31a6b9efa9cf94ad0930f83eedac5152fc762\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3373751\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#956759}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9a8720c24bf91aa8330b9d8d8064161d2c3a09f8\n" }, { "commit": "7e662c9ab6e099d5ca879f9c8f20a8d51ee847f2", "tree": "dfcc0690a5d40c86501e74d04441c0b647d7e238", "parents": [ "ce1fd27571b9c1a9dfe05d0193cd8def30f7d466" ], "author": { "name": "Alexei Svitkine", "email": "asvitkine@chromium.org", "time": "Thu Dec 02 22:06:15 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 02 22:23:09 2021" }, "message": "Update callsites to use WIN_-prefixed base::File flags.\n\nThe flags have been renamed to make it clear that they only\napply to Windows (see associated bug).\n\nIf you\u0027re reviewing this CL, please verify your code\u0027s usage\nof the flag to ensure that the behavior is as intended. Thanks!\n\nThis CL was uploaded by git cl split.\n\nR\u003dwfh@chromium.org\n\nBug: 1244149\nChange-Id: Ib1ee3a3a3355fc0245b056c1df5d49959fea351b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313446\nAuto-Submit: Alexei Svitkine \u003casvitkine@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#947664}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 126557a6b22199c48617613f68822b6aefb62909\n" }, { "commit": "ce1fd27571b9c1a9dfe05d0193cd8def30f7d466", "tree": "42d5df83b0508dc239bae45b183e296eccc74421", "parents": [ "2261f59b11b25d22e5a5efda342a9826da306b6e" ], "author": { "name": "Keishi Hattori", "email": "keishi@chromium.org", "time": "Sat Nov 27 09:25:52 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Nov 27 09:34:03 2021" }, "message": "Rewrite most `Foo* field_` pointer fields to `raw_ptr\u003cFoo\u003e field_`.\n\nDO NOT REVERT (unless absolutely necessary)! Report build breaks to keishi@(APAC)/glazunov@(EMEA)/sebmarchand@(NA) as soon as you see them. Fixes are expected to be trivial.\n\nThis commit was generated automatically, by running the following script: tools/clang/rewrite_raw_ptr_fields/rewrite-multiple-platforms.sh on commit fe74bc434e5b7e92d13a328362fcb6df15d8847e\n\nFor more information, see MiraclePtr One Pager [1], the PSA at chromium-dev@ [2], and the raw_ptr documentation in //base/memory/raw_ptr.md.\n\nFYI This CL does not enable MiraclePtr protection and we expect no behavior change from this.\n\n[1] https://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg/edit?usp\u003dsharing\n[2] https://groups.google.com/a/chromium.org/g/chromium-dev/c/vAEeVifyf78/m/SkBUc6PhBAAJ\n\nBinary-Size: Increase of around 500kb was approved for MiraclePtr\nInclude-Ci-Only-Tests: true\nNo-Tree-Checks: true\nNo-Presubmit: true\nBug: 1272324, 1073933\nChange-Id: I05c86a83bbb4b3f4b017f361dd7f4e7437697f69\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305132\nCommit-Queue: Keishi Hattori \u003ckeishi@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#945735}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0e45c020c43b1a9f6d2870ff7f92b30a2f03a458\n" }, { "commit": "2261f59b11b25d22e5a5efda342a9826da306b6e", "tree": "002c5f54910064393680aaeff02d9dc8255ba07f", "parents": [ "2545ba2de79ff6bf7d00f07296dacfdbae7e5c2b" ], "author": { "name": "Addison Luh", "email": "aluh@chromium.org", "time": "Sat Nov 20 00:19:12 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Nov 20 00:27:10 2021" }, "message": "Fix PNG file names for courgette docs.\n\nSeems this has been broken since 2013:\nhttps://source.chromium.org/chromium/chromium/src/+/fd0a76f109c0fa3f9dd973ee6921957501f317e5\n\nChange-Id: Ia9cd3421ee1679dd21cf4d6e2ad725b0b6234093\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292449\nCommit-Queue: Addison Luh \u003caluh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nAuto-Submit: Addison Luh \u003caluh@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#943754}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c39613d437f02931cf4242bbc92f4fb09cd720ba\n" }, { "commit": "2545ba2de79ff6bf7d00f07296dacfdbae7e5c2b", "tree": "e57a95873a85b5ead5f917d18af4a8647c19f587", "parents": [ "c8c70ed4c91bbf06feb9ed15291b3b9ae90e243e" ], "author": { "name": "Addison Luh", "email": "aluh@chromium.org", "time": "Fri Nov 19 20:09:49 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 19 20:19:13 2021" }, "message": "Revert \"Remove unused Courgette PNG files.\"\n\nThis reverts commit 4af8f6c99133af358ea3ac3595672f50decb8edf.\n\nReason for revert: The images seem to be still used by the md and html files, but just named incorrectly.\n\nOriginal change\u0027s description:\n\u003e Remove unused Courgette PNG files.\n\u003e\n\u003e Bug: 1257736\n\u003e Change-Id: I4a5d2cbb033bec6a3966cb49824b6ca762fcb989\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232667\n\u003e Auto-Submit: Addison Luh \u003caluh@chromium.org\u003e\n\u003e Commit-Queue: Will Harris \u003cwfh@chromium.org\u003e\n\u003e Reviewed-by: Will Harris \u003cwfh@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#933185}\n\nBug: 1257736\nChange-Id: Ia64996aa8e36f6b24500996313f6f54d38537e01\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292368\nAuto-Submit: Addison Luh \u003caluh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#943623}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e49c4655efe34617ce61793edcd76c06f2f2fa1a\n" }, { "commit": "c8c70ed4c91bbf06feb9ed15291b3b9ae90e243e", "tree": "537a8761200aa5397974832da7ec3f0d9717fbb5", "parents": [ "b109f4703443f52e550dbd59744628302c2c3829" ], "author": { "name": "Alexei Svitkine", "email": "asvitkine@chromium.org", "time": "Tue Nov 16 14:35:18 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 16 14:44:33 2021" }, "message": "Update callsites to use WIN_-prefixed base::File flags.\n\nThe flags have been renamed to make it clear that they only\napply to Windows (see associated bug).\n\nIf you\u0027re reviewing this CL, please verify your code\u0027s usage\nof the flag to ensure that the behavior is as intended. Thanks!\n\nThis CL was uploaded by git cl split.\n\nR\u003dtommi@chromium.org\n\nBug: 1244149\nChange-Id: I9244c9728f570fe71b8eab7a2dbb1aee5ac74b71\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3279147\nAuto-Submit: Alexei Svitkine \u003casvitkine@chromium.org\u003e\nReviewed-by: Tommi \u003ctommi@chromium.org\u003e\nCommit-Queue: Tommi \u003ctommi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#942147}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e9b263ccb690b0722ab467d42cc46c063d244dcd\n" }, { "commit": "b109f4703443f52e550dbd59744628302c2c3829", "tree": "a8e78b8ec002bd0cb10cd27ccb20b5a01feae0ff", "parents": [ "2acbb26ecd71164c60f9e99d9df10d39726f0a57" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Fri Nov 12 03:40:24 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 12 03:48:56 2021" }, "message": "Remove most remaining unused \"base/macros.h\"\n\nRemoves `#include \"base/macros.h\"` from remaining .cc, .h and .mm files\nthat do not contain `ignore_result(` and do not trigger pre-commit or\npre-upload errors.\n\nBug: 1010217\nNo-Try: true\nChange-Id: I4cc5207b3deafa7901764d2e633bbb1ad43cfb73\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276692\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#941054}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5666ff4f5077a7e2f72902f3a95f5d553ea0d88d\n" }, { "commit": "2acbb26ecd71164c60f9e99d9df10d39726f0a57", "tree": "6db7a347755a5cb58ced730b1f4ccbe7370bcb16", "parents": [ "66e9fe909793e4133054110dab52cb3ddcf76245" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Fri Nov 05 01:12:30 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 05 01:21:56 2021" }, "message": "Remove all DISALLOW_COPY_AND_ASSIGNs\n\nThis replaces all remaining DISALLOW_COPY_AND_ASSIGN() instances with\ntheir expanded counterparts.\n\nThe macro definitions and IWYU are left as a separate change. The former\nto prevent unintended large reverts and the latter is easier once all\nDISALLOW_ macros are gone.\n\nBug: 1010217\nChange-Id: I0e2fd43f4060628c09420709010aab2c84b87148\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259964\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#938612}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 896f13791f32e90dc08379498e17a181d4afcf5f\n" }, { "commit": "66e9fe909793e4133054110dab52cb3ddcf76245", "tree": "8c63fab7f5e4797953d8df0afeb49a52eb14c292", "parents": [ "3892b09fe232d91b03e65a91320ca93ee0160b5d" ], "author": { "name": "Addison Luh", "email": "aluh@chromium.org", "time": "Tue Oct 19 21:31:02 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 19 21:40:17 2021" }, "message": "Remove unused Courgette PNG files.\n\nBug: 1257736\nChange-Id: I4a5d2cbb033bec6a3966cb49824b6ca762fcb989\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232667\nAuto-Submit: Addison Luh \u003caluh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#933185}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4af8f6c99133af358ea3ac3595672f50decb8edf\n" }, { "commit": "3892b09fe232d91b03e65a91320ca93ee0160b5d", "tree": "c7ee389ed8675a389138df56f7516f74a884a316", "parents": [ "ef82df28c54f92e22dac19f4ab500789bf90daba" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Tue Sep 28 00:28:00 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 28 00:38:28 2021" }, "message": "Script remove more DISALLOW_COPY_AND_ASSIGNs\n\nThis applies a script previously used for large directories on all\nremaining (smaller) directories as a single chunk.\n\nThis replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes\nwhere a local script is able to detect its insertion place (~Foo() is\npublic \u003d\u003e insert before this line).\n\nThis is incomplete as not all classes have a public ~Foo() declared, so\nnot all DISALLOW_COPY_AND_ASSIGN occurrences are replaced.\n\nIWYU cleanup is left as a separate pass that is easier when these macros\ngo away.\n\nBug: 1010217\nChange-Id: I572936462f763e1dd15dd88cdcf451ee14b34dd1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182480\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#925533}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c68c5aad6c5f2cbbda3efc5a1e6dd647bbc55108\n" }, { "commit": "ef82df28c54f92e22dac19f4ab500789bf90daba", "tree": "7e458136092e71a46123e56417e8d17178ba8c74", "parents": [ "ee842c190fe103bd3ad2f75fa65c5f401f228826" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon Aug 23 14:58:35 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 23 15:07:37 2021" }, "message": "Fix some instances of -Wshadow.\n\nBug: 794619\nChange-Id: Id29d948ff1ace695a4fe33bc5554bad2ffdf2fef\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3104189\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Nina Satragno \u003cnsatragno@chromium.org\u003e\nReviewed-by: Istiaque Ahmed \u003clazyboy@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#914328}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c5a7879e6062cc88a519b32ec06a2d975dafc7d8\n" }, { "commit": "ee842c190fe103bd3ad2f75fa65c5f401f228826", "tree": "b1aaf8773bb58379b9fef8d96b2d60c1340250e4", "parents": [ "493a803823c7cc7cdfa787f04d83aa584266e4cc" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Jul 30 21:54:20 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 30 22:03:26 2021" }, "message": "Enable size_t truncation warnings in most directories.\n\nBug: 167187\nChange-Id: I757b2469336069ff637de60fde4abeb29bf4d041\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3057921\nReviewed-by: Sadrul Chowdhury \u003csadrul@chromium.org\u003e\nReviewed-by: Zhenyao Mo \u003czmo@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Zhenyao Mo \u003czmo@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#907277}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6552e4c03f2ed68c05ee7537def01b695f328021\n" }, { "commit": "493a803823c7cc7cdfa787f04d83aa584266e4cc", "tree": "63c30b7ea62775f4c60921af615a17c836812532", "parents": [ "c276805c38da6061eedb94ba37b763c755ad4765" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Thu Jul 08 03:43:28 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 08 03:50:07 2021" }, "message": "Swap base/stl_util.h to base/cxx17_backports.h in many files.\n\nFiles that use base::size() and base::data() should use\ncxx17_backports.h directly, instead of getting it transitively through\nstl_util.h.\n\nBug: 1210983\nChange-Id: Icc5f425c23ef4e69283293e0d0d6d733fe3b4ba1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2974072\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#899418}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d4a2f8e1ed461d8fc05ed88d1ae2dc94c9773825\n" }, { "commit": "c276805c38da6061eedb94ba37b763c755ad4765", "tree": "4052f39815d349dfeaae620ce18e13297d3c5ff0", "parents": [ "b6a160ae3dfa8505838f986358e33fc85df2977c" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon Jul 05 17:20:58 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 05 17:31:04 2021" }, "message": "-Wdeprecated-copy fixes: courgette/\n\nBug: 1221591\nChange-Id: Ieeef296b53b99d80eba82a889f1dde7bf36fcacd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004537\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#898657}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ecbdbf3d369b6828fb307430965c5978944948ef\n" }, { "commit": "b6a160ae3dfa8505838f986358e33fc85df2977c", "tree": "2f4b36c93d89fdbafa466639ea87ab8c42582a8f", "parents": [ "f38dc057e1521af77464c454e08f9bf84f075017" ], "author": { "name": "John Palmer", "email": "jopalmer@chromium.org", "time": "Wed May 19 18:51:41 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 19 18:58:11 2021" }, "message": "[COIL] Change chromium code search type links to use main rather than master for courgette\n\n See this doc: go/chromium-coil-change for more info\n BUG\u003d1210385\n\nChange-Id: I138ee4184018b591a33328bdd28fd5b2245c295a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2902867\nAuto-Submit: John Palmer \u003cjopalmer@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#884599}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ca086371a18d1424c712e21fa663c3f6cc20fe0d\n" }, { "commit": "f38dc057e1521af77464c454e08f9bf84f075017", "tree": "8f6c2712071d8d8a45119e3ebfe3a9adfca656df", "parents": [ "0406034659fce92eb96af5cbe0e6f792d014ab19" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Sun May 16 06:40:14 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sun May 16 06:44:32 2021" }, "message": "Delete most remaining unused STL includes.\n\nHeaders that do not contain \"std::\" do not need STL includes.\n\nThis CL is first mechanically generated as follows:\n\nINCL\u003d\"algorithm|array|list|map|memory|queue|set|string|unordered_map|unordered_set|utility|vector\"\ngit ls-files | grep \u0027\\.h$\u0027 | xargs grep -L std:: | \\\n xargs grep -El \"#include \u003c($INCL)\u003e$\" \u003e to_process.txt\n\nRemove a bunch of third party files from to_process.txt.\n\nINCL_ESCAPED\u003d\"$(echo $INCL|sed \u0027s/|/\\\\|/g\u0027)\"\ncat to_process.txt | xargs sed -i \"/^#include \u003c\\($INCL_ESCAPED\\)\u003e$/d\"\ncat to_process.txt | xargs sed -i \u0027/^$/N;/^\\n$/D\u0027\n\nThen fix the build in rlz/.\n\nBug: 1200833\nChange-Id: I7c48cdb53ec85412b6331df626f2f5c4c0174faa\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2896225\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#883318}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a613b275d8e820801248486346d1dda3a54a415c\n" }, { "commit": "0406034659fce92eb96af5cbe0e6f792d014ab19", "tree": "c4426edc698e98de4a5e92037843bb38af1bfd27", "parents": [ "08f91f7b39e6c22d9f07d81c8eea894590b30a2f" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon May 10 20:19:18 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 10 20:26:00 2021" }, "message": "Forward declare base::FilePath in some commonly used headers.\n\nDon\u0027t include file_path.h when it is not required. Then fix the build by\nadding in missing includes that are required.\n\nChange-Id: I5edb0c159dc5755f253bb8c15f74dedebd9adaaa\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881321\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#881201}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 175750867d80a445e3384f4a05c0c5986ae1a1d1\n" }, { "commit": "08f91f7b39e6c22d9f07d81c8eea894590b30a2f", "tree": "20f641aefd846c7bf9ff008b4360da79c4388acb", "parents": [ "233d50d5136e05950388449d3f471a19135500d5" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri May 07 18:59:39 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 07 19:04:06 2021" }, "message": "Remove unneeded base/files/file_path.h includes in headers.\n\nHeaders that do not reference base::FilePath do not need to include\nbase/files/file_path.h. This reduces the amount of data necessary to\nbuild the chrome target by 175 MB.\n\nBug: 242216\nChange-Id: I7abd8d9fc1862a2dca11292719ab5b9146ab04d1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878909\nReviewed-by: Peter Boström \u003cpbos@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#880501}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 12341b14c8ec39ae08af60a9d40cfeb0b9e748db\n" }, { "commit": "233d50d5136e05950388449d3f471a19135500d5", "tree": "c867ead61ed4e1033299771d5b1a32e49f24ced6", "parents": [ "96ef1f429a1eb24027282023cff0c00d56ce62f6" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon Apr 26 23:48:55 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 26 23:53:34 2021" }, "message": "Remove unneeded base/strings/stringprintf.h includes.\n\nList of files to delete from generated using the following command:\n\ngit grep -l base/strings/stringprintf.h | \\\n xargs grep -L \u0027StringPrint[fV]\u0027 | xargs grep -L StringAppend | \\\n grep -E \u0027(cc|mm|h)$\u0027\n\nChange-Id: Ibc72245f08730b4d25283e2d966235b61513c7ae\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2849392\nReviewed-by: Peter Boström \u003cpbos@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#876365}\nGitOrigin-RevId: b49a213e324277a5539cc808e46cfa982502a81d\n" }, { "commit": "96ef1f429a1eb24027282023cff0c00d56ce62f6", "tree": "204f0290ae90a2bfe2c7545e3dc536532540e78c", "parents": [ "13ba5623059bb752e0f5b0c76f1e4921669f2822" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon Apr 26 23:12:24 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 26 23:22:57 2021" }, "message": "Do IWYU for base/strings/stringprintf.h.\n\nFiles that use base::StringPrintf() and StringPrintV() should include\nstringprintf.h. Find the files that do not using this command:\n\ngit grep -l \u0027base::StringPrint[fV]\u0027 | \\\n xargs grep -L \u0027^#include \"base/strings/stringprintf.h\"$\u0027 | \\\n grep -E \u0027(cc|mm)$\u0027\n\nand add the include to those files.\n\nThen do a similar check for base::StringAppend.\n\nChange-Id: Ia736e7d64eeb13dc7aff72944ebe00f6931ed584\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2849391\nReviewed-by: Peter Boström \u003cpbos@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#876342}\nGitOrigin-RevId: e02299a9f0fad3a2115e5d74fd6f4195d41dd3d1\n" }, { "commit": "13ba5623059bb752e0f5b0c76f1e4921669f2822", "tree": "f10ead6e6571092988daa7d5559c864d213b506a", "parents": [ "68643372b0def35702c647c1b8c8e2c90d170147" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon Apr 26 19:47:38 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 26 19:59:32 2021" }, "message": "Fix header guards in various dirs.\n\nGenerated mechanically as follows:\n\ngit ls-files \u0027*.h\u0027 | grep \"^$DIR\" | \\\n xargs parallel cpplint.py --filter\u003d-,+build/header_guard -- 2\u003e\u00261 | \\\n grep build/header_guard | tools/apply_cpplint_header_guard.py\n\nBug: 1200694\nChange-Id: I128daa6b322b6d1c2bf7748b7bb03d1d68cfc2d9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2848538\nReviewed-by: Boris Sazonov \u003cbsazonov@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#876278}\nGitOrigin-RevId: 02f91dae7fbe275d86dd0cfc97b2ea0c46c8a332\n" }, { "commit": "68643372b0def35702c647c1b8c8e2c90d170147", "tree": "61585aea72a4d2e5c35b2f06d52c545109dd2a56", "parents": [ "520e8442f9188a5eb892be158f9c0c83407856fe" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Mon Apr 05 21:06:12 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 05 21:12:07 2021" }, "message": "Apply modernize-make-unique to remaining files\n\nThis intends to cover directories and individual files where changes\nweren\u0027t large enough to warrant splitting out to a separate change.\n\nThis is a large-scale change: go/chromium-modernize-make-unique\n\nBug: 1194272\nChange-Id: Ia50424ec4b7f998e65dee5071926332ffcce7a94\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2803041\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#869273}\nGitOrigin-RevId: fb60ea0a4d243d2626142c83ef018d9d129462cd\n" }, { "commit": "520e8442f9188a5eb892be158f9c0c83407856fe", "tree": "f3614b7b8ef74923a30fb05a56ba1b4841c50a57", "parents": [ "0a7452b20e26ec2863a2c0544cf03d38468b30e0" ], "author": { "name": "John Abd-El-Malek", "email": "jam@chromium.org", "time": "Wed Feb 24 22:22:40 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 24 22:33:48 2021" }, "message": "Update documentation to allow owners of public APIs that are used throughout the codebase to Owners-Override changes across the source tree.\n\nUnlike LSC which is meant for work that spans dozens of CLs, this new change is meant for one-off CLs. It\u0027s similar to google3\u0027s global approvals mechanism.\n\nbase, build, blink, content and url were chosen as an initial set because they are used in many top level directories and are frequently changing.\n\nAlso add \"set noparent\" to top level directories to avoid inadvertent +1s from src/OWNERS bypass owners reviews sometimes.\n\nChange-Id: Iaa397a5e09174139af21fee34dca390de132e216\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2688805\nAuto-Submit: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCommit-Queue: John Abd-El-Malek \u003cjam@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Kentaro Hara \u003charaken@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#857391}\nGitOrigin-RevId: dfd1edc8143345138e132645be807ddcd8954f2b\n" }, { "commit": "0a7452b20e26ec2863a2c0544cf03d38468b30e0", "tree": "9dd9a90e6cf15e9a37ea2b661645b82286d4b735", "parents": [ "b0a4266639e35a613427835a1875d076f7858ac6" ], "author": { "name": "Jan Wilken Dörrie", "email": "jdoerrie@chromium.org", "time": "Tue Nov 10 13:16:43 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 10 13:27:18 2020" }, "message": "[base] Remove STLIsSorted\n\nThis change removes base::STLIsSorted and replaces existing usages with\nthe equivalent base::ranges::is_sorted.\n\nTBR\u003ddcheng\n\nBug: None\nChange-Id: I2edbcdb7e27a95b42db31c5789c5891ca46c3e15\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526090\nCommit-Queue: Jan Wilken Dörrie \u003cjdoerrie@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Devlin \u003crdevlin.cronin@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#825784}\nGitOrigin-RevId: 03ec116d26a243967acf74563ec5206d2ad1cfd3\n" }, { "commit": "b0a4266639e35a613427835a1875d076f7858ac6", "tree": "b5478cd05efb9afbeaaa30fd1a9246fbfaa3cff3", "parents": [ "b21a41c69c5ffc692eb46faa12af1bea80763319" ], "author": { "name": "Edward Lesmes", "email": "ehmaldonado@google.com", "time": "Wed Oct 07 18:23:24 2020" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 07 18:28:38 2020" }, "message": "Add DIR_METADATA files to //courgette\n\nAdd Generate DIR_METADATA files and remove metadata from OWNERS\nfiles for //courgette.\n\nR\u003dhuangs@chromium.org\n\nBug: 1113033\nChange-Id: Ia24b5ca4b977524c79c245e78f14d86981aa029d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454274\nAuto-Submit: Edward Lesmes \u003cehmaldonado@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: Edward Lesmes \u003cehmaldonado@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#814782}\nGitOrigin-RevId: 1e0bfa5a060416a87c2f5ddb280f33ac28da6bf1\n" }, { "commit": "b21a41c69c5ffc692eb46faa12af1bea80763319", "tree": "9d37211e8d9f6e750f91c5131dd932606ebff18e", "parents": [ "18f491b74e732366d798381f859135c96965bfcb" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Sat Jul 18 01:29:39 2020" }, "committer": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Tue Aug 11 22:39:06 2020" }, "message": "remove copybara initialization artifacts\n\nGitOrigin-RevId: f176eba36c20d3f315e507eea7f306da3b58c2e4\n" }, { "commit": "18f491b74e732366d798381f859135c96965bfcb", "tree": "e5224cbd7331d4ab41f1854dd0225e3e3834d0c6", "parents": [ "e3f642887bd1f8e1072d7e63708134c0e80d5fd4" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Sat Jul 18 01:29:39 2020" }, "committer": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Tue Aug 11 22:36:52 2020" }, "message": "Copybara Service Migration Initialization.\n\nGitOrigin-RevId: f176eba36c20d3f315e507eea7f306da3b58c2e4\n" }, { "commit": "e3f642887bd1f8e1072d7e63708134c0e80d5fd4", "tree": "9d37211e8d9f6e750f91c5131dd932606ebff18e", "parents": [ "e5ef0480b13ec8fdb9980b758e4e5a2d265ee9e9" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Sat Jul 18 01:29:39 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Jul 18 01:29:39 2020" }, "message": "Use FLAG_SHARE_DELETE when opening files in the installer.\n\nThis CL adds FLAG_SHARE_DELETE to many file operations in Chrome\u0027s\ninstaller; including in delta patch processing and archive extraction\nutilities. This allows processing on files that are held open to be\ndeleted by another entity so that we can eventually hold temporary files\nopen with FILE_FLAG_DELETE_ON_CLOSE.\n\nBUG\u003d516207\n\nChange-Id: I1cd03f6360dfcd61fcd2f09797f0923331076415\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302109\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Greg Thompson \u003cgrt@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#789702}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f176eba36c20d3f315e507eea7f306da3b58c2e4\n" }, { "commit": "e5ef0480b13ec8fdb9980b758e4e5a2d265ee9e9", "tree": "01fbb96c0027eec4dca88c2e0c97675a1d7a7ddd", "parents": [ "ee6c296d1506f7a9a5c0f22fdcf7881b527e710b" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed Jul 08 00:02:15 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jul 08 00:02:15 2020" }, "message": "Switch to 1-parameter version of base::DeleteFile() in various dirs.\n\nThe 1-parameter version is simpler, and the 2-parameter version is\ndeprecated.\n\nBug: 1009837\nChange-Id: I083906f5cb2f899814511707a639da591a711182\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285177\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#786068}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7b28548aa69b1bde674ce5b97c38328b052f8822\n" }, { "commit": "ee6c296d1506f7a9a5c0f22fdcf7881b527e710b", "tree": "7a976f31d6b8b508a1610bab200c0f5e192209fb", "parents": [ "5498ee7818963a25b1b7c40c492e91ddab5401a6" ], "author": { "name": "Hans Wennborg", "email": "hans@chromium.org", "time": "Wed Jun 17 17:58:48 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jun 17 17:58:48 2020" }, "message": "Include-what-you-use related to logging.h (courgette)\n\nAdd direct includes for things provided transitively by logging.h\n(or by other headers including logging.h).\n\nThis is in preparation for cleaning up unnecessary includes of\nlogging.h in header files (so if something depends on logging.h,\nit needs include it explicitly), and for when logging.h no longer\nincludes check.h, check_op.h, and notreached.h.\n\nBug: 1031540\nChange-Id: I0e8ccb83f217a2c7861373b2a967a3eb49922dbf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249759\nAuto-Submit: Hans Wennborg \u003chans@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#779400}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6d867cef88e4a2cfdd1ceb91e627f075787c59fc\n" }, { "commit": "5498ee7818963a25b1b7c40c492e91ddab5401a6", "tree": "97961e86faed5c3b49ce043dc2dc4849b16aaa63", "parents": [ "34029924282d50bc12d33ab5ba9b3608f900901b" ], "author": { "name": "Bartek Nowierski", "email": "bartekn@chromium.org", "time": "Mon Jun 01 20:37:12 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jun 01 20:37:12 2020" }, "message": "Replace NULL and 0 with nullptr\n\nhttps://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says:\nFor pointers (address values), use nullptr, as this provides type-safety.\n\nAdditionally, NULL won\u0027t compile if we change |SomeClass*| to |CheckedPtr\u003cSomeClass\u003e|. See go/miracleptr for more details.\n\nBug: 1080832\nChange-Id: I70f899fe45a31d55f98063585180686d2a256141\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217946\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Sadrul Chowdhury \u003csadrul@chromium.org\u003e\nReviewed-by: Peng Huang \u003cpenghuang@chromium.org\u003e\nReviewed-by: Kentaro Hara \u003charaken@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#773810}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3253b67cc7b0dbc12e760a7d66584f8429023105\n" }, { "commit": "34029924282d50bc12d33ab5ba9b3608f900901b", "tree": "9d7141a01c51e53fc0f27f4b799d8e690df9f83e", "parents": [ "f941ac48dff194f4eacf34ae2b39a443fb663b70" ], "author": { "name": "Lukasz Anforowicz", "email": "lukasza@chromium.org", "time": "Fri May 29 02:44:24 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 29 02:44:24 2020" }, "message": "Use |nullptr| instead of |NULL| under //courgette.\n\nBug: 1080832\nChange-Id: I7c01babed13186995b83d4c3a49ce6fdaf2c648e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219582\nAuto-Submit: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#773019}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ab01986eb1955e920f1d3bf16db97411a59c6034\n" }, { "commit": "f941ac48dff194f4eacf34ae2b39a443fb663b70", "tree": "6d67b8cc12a7163515b9b1cef0c6cd7dd4cd87a7", "parents": [ "afd5d8f58356f30a52677df2d39ecc7ebdcc2a17" ], "author": { "name": "Piotr Tworek", "email": "ptworek@vewd.com", "time": "Tue Apr 28 08:02:40 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 28 08:02:40 2020" }, "message": "Add missing string.h include in //courgette/memory_allocator.h\n\nThe code in this file uses memcpy but fails to include string.h. This\nlead to a build failure on Linux systems using glibc 2.30, or newer.\n\nBug: 1074286\nChange-Id: I09011564cca79cb2cd07a26b3ba77308e79abd8b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167856\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: Piotr Tworek \u003cptworek@vewd.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#763240}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: afba0d79e4d498a50ada602193eeb43b51decb66\n" }, { "commit": "afd5d8f58356f30a52677df2d39ecc7ebdcc2a17", "tree": "ae947f8a534a9ec5a97c8c05ecfc2ecfdf42af52", "parents": [ "ad97fdb158a1b2a421cf1d359ef68dd3f7db4b29" ], "author": { "name": "Hans Wennborg", "email": "hans@chromium.org", "time": "Mon Apr 27 17:27:11 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 27 17:27:11 2020" }, "message": "Remove/replace unnecessary logging.h includes in .cc files (courgette)\n\nCHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved\nto the much smaller headers check.h, check_op.h, and notreached.h,\nrespectively.\n\nThis CL updates .cc files to use those headers instead when\npossible, with the purpose of saving compile time.\n\n(Split out from https://crrev.com/c/2164525 which also has\nnotes on how the change was generated.)\n\nBug: 1031540\nChange-Id: I0fa169e1b8146a0a00eb055536de0ce140aeb705\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165108\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nAuto-Submit: Hans Wennborg \u003chans@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#762912}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e9641ed144a744907f958d26a3185a12a9879d7f\n" }, { "commit": "ad97fdb158a1b2a421cf1d359ef68dd3f7db4b29", "tree": "de5b2b878ca8ae83893d3e8b01ad2f9e37afc8d8", "parents": [ "24a0419e6413fbeb33bfb0e8128144dccda7fa04" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Wed Apr 22 19:22:59 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Apr 22 19:22:59 2020" }, "message": "[Courgette] ELF x86: Reject abs32 references that straddle section boundary.\n\nThis CL prevents heap-buffer-overflow in Courgette for ELF x86, caused\nby abs32 references that start within a section, but whose 4-byte spans\nstraddles the end boundary of the section.\n\nBug: 961644\nChange-Id: I635135a586879155a5a443ad4a0dcef4d1bc9c38\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159368\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#761574}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 49bd5efa81081d1bedb670432c4ac4e2b596333f\n" }, { "commit": "24a0419e6413fbeb33bfb0e8128144dccda7fa04", "tree": "d80ad3fb07f6e2e12bdcc19e2e4d89cb1d9945f2", "parents": [ "7172d68d9017bafa9219718938e13f443ea8af88" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Mon Jan 13 20:02:26 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jan 13 20:02:26 2020" }, "message": "Reformat all gn files in /courgette.\n\n`gn format` recently changed its formatting behavior\nfor deps, source, and a few other elements when they\nare assigned (with \u003d) single-element lists to be consistent\nwith the formatting of updates (with +\u003d) with single-element.\n\nNow that we\u0027ve rolled in a GN binary with the change,\nreformat all files so that people don\u0027t get presubmit\nwarnings due to this.\n\nThis CL was uploaded by git cl split.\n\nR\u003dwfh@chromium.org\n\nBug: 1041419\nChange-Id: I206e7e4c8e89f16b2349ed1cd361a63524e688a3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996999\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#730753}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: dd348636f6aba5d48de4e032ad2efdd0431b884c\n" }, { "commit": "7172d68d9017bafa9219718938e13f443ea8af88", "tree": "61ac8a56f356384aa37d97c7b96c47ba4d5916b4", "parents": [ "ebc4ea9b3d112207e82bbaa5ed9f9a962014372f" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Mon Jan 06 22:57:20 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jan 06 22:57:20 2020" }, "message": "[Courgette] Remove label trimming feature, which was used by ARM only.\n\nCourgette\u0027s algorithm allow removal for underused labels. However, this\nwas only used by ARM, whose support is recently removed. This CL is a\nfollow-up to remove more dead code.\n\n* Remove AssemblyProgram::TrimLabels()\n* Remove LabelManager::RemoveUnderusedLabels() and usage in test.\n\nBug: 1012592\nChange-Id: Ia50ee2ec9f90e35ce123463e06edc9bfb5a868af\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987863\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#728682}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2635521ff6a46f2fb668f58a26d6df52e554f561\n" }, { "commit": "ebc4ea9b3d112207e82bbaa5ed9f9a962014372f", "tree": "73c1492d043064eda756a14cb74d4b75bb892239", "parents": [ "98b4306ef708006b6d5b546ab530ceb9440e4996" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Mon Jan 06 18:40:22 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jan 06 18:40:22 2020" }, "message": "[Courgette] Deprecate ARM support.\n\nCourgette\u0027s ARM support was complex and was never used (except for\nhelping to prototype Zucchini\u0027s ARM flow, which is WIP). Recently the\ncode is also causing Fuzzer issues. Therefore we deem it better to just\nremove the code.\n\nThis CL performs superficial removal of ARM code. For compatibility,\nthe enums\n\n enum ExecutableType { EXE_ELF_32_ARM \u003d 3; }\n enum EncodedProgram::OP { MAKE_ELF_ARM_RELOCATION_TABLE \u003d 7; }\n\nare deprecated and commented out, without changing other values.\n\nBug: 1012592\nChange-Id: Iad3a3c9e41470eef8ff004591e6ed42ea4315d06\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986211\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#728580}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f18358c1333dc1148daf090189afb64ebcce272f\n" }, { "commit": "98b4306ef708006b6d5b546ab530ceb9440e4996", "tree": "bf0ecd800fb4a272cce7514c1dcb6c7468c970ad", "parents": [ "da371d17eb8d2e5bd368f430878c4162b4630475" ], "author": { "name": "Etienne Pierre-doray", "email": "etiennep@chromium.org", "time": "Tue Dec 10 23:05:25 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Dec 10 23:05:25 2019" }, "message": "[Courgette]: Fix applying non-zero offset 255 to null pointer.\n\nReport:\n\"courgette/disassembler_win32.cc:241:44: runtime error: applying non-zero offset 255 to null pointer\"\n\ncourgette::DisassemblerWin32::ParseRelocs\ncourgette::DisassemblerWin32::ExtractAbs32Locations\ncourgette::Disassembler::CreateProgram\n\nThe fix seems to move bounds check on |relocs_start| before computing |relocs_end|.\n\nBug: 1027893\nChange-Id: Iec3f81ab0db077467d28dd8e122aa33d92d52a89\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960548\nCommit-Queue: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#723563}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e0586291d104f26c24f7f3b8d8948d8752297bb2\n" }, { "commit": "da371d17eb8d2e5bd368f430878c4162b4630475", "tree": "4a1f92100d90b90bf42a9cef21da3f7254786dcc", "parents": [ "06e28b2f98903dc844758d86e45737cc4cfbf56c" ], "author": { "name": "inglorion", "email": "inglorion@chromium.org", "time": "Tue Oct 08 19:25:14 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 19:25:14 2019" }, "message": "[Courgette] Fix disassembler_elf_32_arm on_32bit tracking code\n\nPreviously, we used bitwise operations on booleans to keep track of\nwhether we are 32-bit aligned. This code ran afoul of Clang\u0027s new\n-Wbool-operation and didn\u0027t implement the intended behavior. This\nchange fixes the bug uncovered by the warning and implements the\nintended logic using boolean operations.\n\nBug: 1011810\nChange-Id: I4a7275a4e8da274115fa8ae85c90448c036200ff\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846481\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Bob Haarman \u003cinglorion@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703866}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a37764afa5718284d3f3c4ad97be4b220c93c906\n" }, { "commit": "06e28b2f98903dc844758d86e45737cc4cfbf56c", "tree": "954d798ca40f91029bc6bd81f0f4ec2b8f8baf85", "parents": [ "096e7288967c599c9a914c7133daf39ffab3b99d" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Mon Sep 23 17:29:59 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Sep 23 17:29:59 2019" }, "message": "[Courgette] Fix Fuzzer failure for ARM reloc parsing.\n\nThe Courgette Fuzzer found a bug where\nDisassemblerElf32ARM::ParseRelocationSection() overruns buffer\nbecause reloc units are not sorted. This CL fixes the bug by adding\na check. The bug does not happen for X86 case, or for Zucchini.\n\nBug: 961540\nChange-Id: I5ff49c510e9fd8083f42a34e99140ff2c47201e4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818875\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#698927}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e791cc71dfb2f8f98325af1ebb4bc5d3612ab0da\n" }, { "commit": "096e7288967c599c9a914c7133daf39ffab3b99d", "tree": "a79a1e787fc30bb25c7529527e5992dca7aef79a", "parents": [ "6dfa5bf7dfe4c9226c6902f0e875558d0e07bd7a" ], "author": { "name": "Robbie McElrath", "email": "rmcelrath@chromium.org", "time": "Tue Aug 20 22:22:53 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Aug 20 22:22:53 2019" }, "message": "Support initializing logging with a file descriptor rather than a path.\n\nThis CL adds an optional file descriptor to LoggingSettings, which can\nbe used to initialize logging to an already open file. Previously,\nlogging to a file required passing a path and letting the logging\nsystem open() it for append. Passing a file-descriptor means that a\nprocess can be sandboxed to have no access to the log directory, but\ncan still be passed a file-descriptor to log to.\n\nThis is needed for the Network Service on ChromeOS, whose logging needs\nto be reinitialized to a new location after it\u0027s already started.\n\nBug: 977415\nChange-Id: I2d07dc13a7e9f0f57d0802e4816628c181f183cd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699477\nCommit-Queue: Robbie McElrath \u003crmcelrath@chromium.org\u003e\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nReviewed-by: Achuith Bhandarkar \u003cachuith@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Wez \u003cwez@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#688754}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8bf4984f3ad0fb5fc8981f02ce9b96078a98632f\n" }, { "commit": "6dfa5bf7dfe4c9226c6902f0e875558d0e07bd7a", "tree": "5b0b5462b33031a8e35eae9d3b882f8b0c935054", "parents": [ "96b52ba05c361a1d9ea792a92fbed8f53e482790" ], "author": { "name": "Sharon Yang", "email": "yangsharon@chromium.org", "time": "Mon May 20 20:27:15 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon May 20 20:27:15 2019" }, "message": "[logging] Add LOG_TO_STDERR logging destination\n\n* Separate LOG_TO_SYSTEM_DEBUG_LOG into two cases, LOG_TO_STDERR and\n LOG_TO_SYSTEM_DEBUG_LOG as before.\n* Provide the option to only write to system specific logs, write to\n stderr or both, reducing redundant logs for systems which have log\n services, such as with Fuchsia.\n* For all systems, logs with severity ERROR and above will continue to\n be written to stderr.\n* All systems except Fuchsia have the same behaviour and defaults as\n before.\n* Update default logging destination for Fuchsia to system logs only.\n\n\nBug: 960882\nChange-Id: Ib0f27d194226ac5584609a3e8e4bc561828deed8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601467\nCommit-Queue: Sharon Yang \u003cyangsharon@chromium.org\u003e\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#661446}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7cb919a9b3f78d642f8a98e8a81140ef13e2fec2\n" }, { "commit": "96b52ba05c361a1d9ea792a92fbed8f53e482790", "tree": "f005f3b507a0d47304a8e14eb17e1e42c8e0f96d", "parents": [ "58961630f183587cfb0eaa914a74e94af0e32889" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Mon May 06 15:47:15 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon May 06 15:47:15 2019" }, "message": "[Courgette] ELF: Reject if |sh_entsize| of SHT_REL is invalid.\n\nDisassemblerElf32::ExtractAbs32Locations() processes SHT_REL, but\nuses |sh_size / sh_entsize| to compute the number of entries in the\nrelocation table. This assumes |sh_entsize \u003d\u003d sizeof(Elf32_rel)|\n(since Courgette only processes 32-bit SHT_REL), which if violated,\ncan lead to reading off buffer! This CL fixes the issue by requiring\nthe equality (rejects ELF if mismatch is found).\n\nBug: 959066\nChange-Id: I617502dfa67e33a5cf9914feac62294e252adcbc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595964\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#656802}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 59fc566baffba1abe274e9b899cc5301998c5113\n" }, { "commit": "58961630f183587cfb0eaa914a74e94af0e32889", "tree": "43b04c72df371d82ccd2ada60d48e183cfdd3acb", "parents": [ "6ce7044636bc5909eae07c005b2dedf282ebdae8" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Wed Apr 03 15:53:13 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Apr 03 15:53:13 2019" }, "message": "[Courgette] Add more checks in Win32 PE parsing to fix fuzzer failure.\n\nRecently ClusterFuzz found a number of small PE files that trigger\nCHECK failures. This CL makes Courgette PE parsing code more robust,\nso more pathological cases can be identified and gracefully handled.\nDetails:\n* Check that section headers fit within the image.\n* Check that section bodies lie within the image.\n* Check that section bodies virtual addresses are bounded by\n |size_of_image_|.\n * Add DisassemblerWin32::IsRvaRangeInBounds() to do this check..\n* Check that PE header does not appear too early and cause\n pathological overlap.\n* For DisassemblerWin32: In ParseHeader() and QuickDetect():\n * Check that ranges of all data read are within image.\n\nBug: 934112,934141,936741\nChange-Id: Iaf9be4c5fbd0efb31b47d61d86b7001f7674dde7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549724\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#647297}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a34dce5bf8035cde81bc76523ddb56145687b51a" }, { "commit": "6ce7044636bc5909eae07c005b2dedf282ebdae8", "tree": "cb3aee7cdc83775285ca2819e24d9c38edc7f5ee", "parents": [ "0cede6156b739549f4b742ea51eecc11aff15021" ], "author": { "name": "Raul Tambre", "email": "raul@tambre.ee", "time": "Thu Mar 28 06:21:55 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 28 06:21:55 2019" }, "message": "Run clang-tidy modernize-use-nullptr on //courgette\n\nThis was done on Windows. Non-Windows platform-specific code hasn\u0027t been converted.\n\nThis is a mechanical change.\nSee bugs for justification and details.\n\nBug: 776257, 778942\nChange-Id: Iad35c3a9911e5a1c8ae3ce77c5b5c9e8481a9c05\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536067\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Raul Tambre \u003craul@tambre.ee\u003e\nCr-Original-Commit-Position: refs/heads/master@{#645197}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5bd929846cdb931786a1a54e5b2c07932b84584c" }, { "commit": "0cede6156b739549f4b742ea51eecc11aff15021", "tree": "03134c61073a81f45e341508c8697e8cfb207368", "parents": [ "9a90952036abb3e9ee87f9e8758ef3d2ce1ecf66" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Fri Mar 22 20:12:59 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Mar 22 20:12:59 2019" }, "message": "[Courgette] Restrict PE rel32 scan size to min(virtual_size, size_of_raw_data).\n\nFor PE files, rel32 scanning previously scans .text data spanning\n|size_of_raw_data| bytes. However, it\u0027s possible for |virtual_size| \u003c\n|size_of_raw_data|. In this case, any rel32 references found in the\ndata beyond |virtual_size| would have an invalid RVA, causing failure\nwhen attempting to translate them to file offsets.\n\nThis CL fixes the issue by reducing range of rel32 scan size to\n|min(virtual_size, size_of_raw_data)|, thereby avoiding extracting\nthese invalid rel32 references.\n\nBug: 935283\nChange-Id: I81d827d904eb6d168b5268c961419c1855382f69\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535435\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#643525}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 168ab692df93884a7fd04dbf36ff698ec30b9712" }, { "commit": "9a90952036abb3e9ee87f9e8758ef3d2ce1ecf66", "tree": "f7eceb774689e5ecd91a3bb6d8fda4424418d71c", "parents": [ "cc64ca11ef40e3d929b9d0df1a3cab73947f309b" ], "author": { "name": "Samuel Huang", "email": "huangs@chromium.org", "time": "Wed Mar 13 20:43:30 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Mar 13 20:43:30 2019" }, "message": "[Courgette] Add more checks in ELF parsing to fix fuzzer failure.\n\nRecently Clusterfuzz discovered a minimal ELF file that triggers CHECK\nfailure. This CL ports some Zucchini ELF parsing checks to Courgette\nto fix these, and add more. Failing these check just causes potential\nimage to be not identified as ELF. Details:\n* Require string table section to exist (e_shstrndx !\u003d SHN_UNDEF \u003d\u003d 0).\n* Require non-SHT_NOBITS sections to lie with image.\n* Require program segments to lie within image.\n* NB: \"Lie within image\" uses tentative image, before UpdateLength()\n is applied to shrink image.\n* Require string table section to have type SHT_STRTAB.\n * This prevents loophole to the section within image check.\n * This allows CHECK() to be added to SectionBody() per TODO.\n* Require e_ident[{EI_CLASS, EI_DATA, EI_VERSION}] to fixed values\n (32-bit little-endian).\n\nBug: 934142\nChange-Id: I9687d2cbdcbfb957ddd55d0f6a40aea857071d74\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518806\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#640473}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4db877c713b6cf149d6e85e6924f5d449c4dd279" }, { "commit": "cc64ca11ef40e3d929b9d0df1a3cab73947f309b", "tree": "efdc2be2763d824facc96b4be63110127025af32", "parents": [ "73e346ebb690edf038950daeb244f050ba63ae8f" ], "author": { "name": "Daniel Bratell", "email": "bratell@opera.com", "time": "Mon Mar 11 19:56:48 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 11 19:56:48 2019" }, "message": "Adding missing dependency from courgette to lzma_sdk\n\ncrc.cc in in courgette uses third_party/lzma_sdk/7zCrc.h so\nit needs to depend on the build target that lists that file,\ni.e. \"//third_party/lzma_sdk\".\n\nChange-Id: I29f88fee06f1954bc3043eee5e78fbabeebaebee\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505945\nAuto-Submit: Daniel Bratell \u003cbratell@opera.com\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#639603}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 93bec26e04321b39fe4c8f560b1e14c4a0595921" }, { "commit": "73e346ebb690edf038950daeb244f050ba63ae8f", "tree": "f8c9e08af1bd8d328fb9600dda1cebeacbdc3c56", "parents": [ "cd5fd9e4f5751a897784ca744b55888ca90f47db" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Wed Feb 13 14:23:00 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Feb 13 14:23:00 2019" }, "message": "Remove a few unnecessary semicolons.\n\nThis CL was uploaded by git cl split.\n\nR\u003dhuangs@chromium.org\n\nBug: 926235\nChange-Id: I2dbfce3d0f384dbf09f5cc5e3dd79081f4b4738a\nReviewed-on: https://chromium-review.googlesource.com/c/1463302\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#631687}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 47e95a42220f32368a737a77b918c39437f2d5e4" }, { "commit": "cd5fd9e4f5751a897784ca744b55888ca90f47db", "tree": "19c51cf462389e053ee144aeaf2742c253d67ce2", "parents": [ "d87dd6f18ab585fb491b0566af1140dc25beeb99" ], "author": { "name": "Raul Tambre", "email": "raul@tambre.ee", "time": "Mon Feb 11 19:54:50 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Feb 11 19:54:50 2019" }, "message": "//courgette: Convert base::(U)Int(64)ToString(16) to NumberToString(16)\n\nThe former non-overloaded variants are deprecated.\nRemoved casts where they are now unnecessary.\n\nThis is a mechanical change; there is no intended behavior change.\n\nBug: 929827\nChange-Id: Ia3586714e8faa17fa3adbeb7806634543a502434\nReviewed-on: https://chromium-review.googlesource.com/c/1461384\nAuto-Submit: Raul Tambre \u003craul@tambre.ee\u003e\nCommit-Queue: Samuel Huang \u003chuangs@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#630889}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e7ef5c5cdf0ca2cc053dc5077c8650bec6a1d60a" }, { "commit": "d87dd6f18ab585fb491b0566af1140dc25beeb99", "tree": "31d051a8b2963ad9af588fae6e8a127ce663f3bc", "parents": [ "1fa0f6e06e8d247ad5607c002eff884f91188951" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Tue Jan 08 06:26:58 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 08 06:26:58 2019" }, "message": "Remove include of base/containers/hash_tables.h except base/\n\nAdded some unordered_map/unordered_set include instead to fix build.\n\nBug: 576864\nTBR: thakis@chromium.org\nChange-Id: I8a23d908af392ced8fb2df0073e64e8020acc5fd\nReviewed-on: https://chromium-review.googlesource.com/c/1398161\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#620639}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: fc262dcd403c74cf3e22896f32d9723ba463f0b6" }, { "commit": "1fa0f6e06e8d247ad5607c002eff884f91188951", "tree": "456ab877c9600ba1760ee90951ac42bf75372609", "parents": [ "e04a0c15fa5ec2c7a964ba091071f6599b9d061e" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Sat Jan 05 03:58:00 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Jan 05 03:58:00 2019" }, "message": "Replace base::hash_set with std::unordered_set\n\nbase::hash_set is alias of std::unordered_set now.\n\nI applied following command to make this CL.\n\n$ git grep -l \u0027base::hash_set\u0027 | fgrep -v base/ | xargs sed -i -e \u0027s/base::hash_set/std::unordered_set/g\u0027 -e \u0027s/\\(#include \u003c[a-z_]*\u003e\\)/\\1\\n#include \u003cunordered_set\u003e/\u0027 -e \u0027s/BASE_HASH_NAMESPACE/std/\u0027\n$ git cl format\n\nTBR: dcheng@chromium.org\nBug: 576864\nChange-Id: I89535173626483c06989b4d8a99dc46c1d49ce7b\nReviewed-on: https://chromium-review.googlesource.com/c/1390887\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#620168}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8332bf9da1576fe59109cdc2de8a06added6873f" }, { "commit": "e04a0c15fa5ec2c7a964ba091071f6599b9d061e", "tree": "caeb379bac24abb76ab1f9dce49133f5df1b5d0c", "parents": [ "cb67f0830c0ceb78215afde4e2d86b1206032747" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Tue Dec 25 20:27:29 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Dec 25 20:27:29 2018" }, "message": "Use base::size rather than arraysize in courgette/.\n\nThis is purely a mechanical change; there is no intended behavior change.\n\nBUG\u003d837308\nTBR\u003dwfh@chromium.org\n\nChange-Id: I67c0b8518d2464298e282891298e3e2eb8ca4796\nReviewed-on: https://chromium-review.googlesource.com/c/1390733\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#618875}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a9b11a13a8903dd857e4619b2bd85f27dc1b82b1" }, { "commit": "cb67f0830c0ceb78215afde4e2d86b1206032747", "tree": "7595317e4ef75576ecdecc0f552ac40bc21835f5", "parents": [ "0d851528adbe0b9d59d454d7db45aeced1c5f12e" ], "author": { "name": "Scott Graham", "email": "scottmg@chromium.org", "time": "Thu Oct 25 19:00:22 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 25 19:00:22 2018" }, "message": "fuchsia: Fix sign-compare warning in divsufsort\n\nALPHABET_SIZE, BUCKET_A_SIZE, and BUCKET_B_SIZE are defined in terms\nof UINT8_MAX which is unsigned (at least on Fuchsia) and fairly small\n((UINT8_MAX+1)^2). saidx_t and saint_t are signed.\n\n[25568-\u003e415/26982 ~1000] CXX obj/courgette/divsufsort/divsufsort.o\nFAILED: obj/courgette/divsufsort/divsufsort.o\n/usr/local/google/home/scottmg/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/courgette/divsufsort/divsufsort.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON\u003d1 -DUSE_AURA\u003d1 -DUSE_OZONE\u003d1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS\u003d64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DFUCHSIA_SDK_VERSION\u003d05a1d1f99b5b8b4b8edb3097564b0653ec0f52bd -DCR_CLANG_REVISION\u003d\\\"344066-1\\\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION\u003d344254 -DCR_LIBCXXABI_REVISION\u003d344215 -D_LIBCPP_ENABLE_NODISCARD -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED\u003d1 -DWTF_USE_DYNAMIC_ANNOTATIONS\u003d1 -I../.. -Igen -I../../third_party/fuchsia-sdk/sdk/pkg/async/include -I../../third_party/fuchsia-sdk/sdk/pkg/fdio/include -I../../third_party/fuchsia-sdk/sdk/pkg/zx/include -fno-strict-aliasing --param\u003dssp-buffer-size\u003d4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__\u003d -D__TIME__\u003d -D__TIMESTAMP__\u003d -funwind-tables -fPIC -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare\u003d0 -no-canonical-prefixes -fcomplete-member-pointers --target\u003dx86_64-fuchsia -fno-sanitize\u003dsafe-stack -m64 -march\u003dx86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -Wno-defaulted-function-deleted -O0 -fno-omit-frame-pointer -g2 -ggnu-pubnames -fvisibility\u003dhidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-shorten-64-to-32 -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std\u003dc++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot\u003d../../third_party/fuchsia-sdk/sdk/arch/x64/sysroot -fvisibility-inlines-hidden -c ../../courgette/third_party/divsufsort/divsufsort.cc -o obj/courgette/divsufsort/divsufsort.o\n../../courgette/third_party/divsufsort/divsufsort.cc:60:16: error: comparison of integers of different signs: \u0027divsuf::saidx_t\u0027 (aka \u0027int\u0027) and \u0027unsigned int\u0027 [-Werror,-Wsign-compare]\n for(i \u003d 0; i \u003c BUCKET_A_SIZE; ++i) { bucket_A[i] \u003d 0; }\n ~ ^ ~~~~~~~~~~~~~\n../../courgette/third_party/divsufsort/divsufsort.cc:61:16: error: comparison of integers of different signs: \u0027divsuf::saidx_t\u0027 (aka \u0027int\u0027) and \u0027unsigned int\u0027 [-Werror,-Wsign-compare]\n for(i \u003d 0; i \u003c BUCKET_B_SIZE; ++i) { bucket_B[i] \u003d 0; }\n ~ ^ ~~~~~~~~~~~~~\n../../courgette/third_party/divsufsort/divsufsort.cc:87:32: error: comparison of integers of different signs: \u0027divsuf::saint_t\u0027 (aka \u0027int\u0027) and \u0027unsigned int\u0027 [-Werror,-Wsign-compare]\n for(c0 \u003d 0, i \u003d 0, j \u003d 0; c0 \u003c ALPHABET_SIZE; ++c0) {\n ~~ ^ ~~~~~~~~~~~~~\n../../courgette/third_party/divsufsort/divsufsort.cc:91:25: error: comparison of integers of different signs: \u0027divsuf::saint_t\u0027 (aka \u0027int\u0027) and \u0027unsigned int\u0027 [-Werror,-Wsign-compare]\n for(c1 \u003d c0 + 1; c1 \u003c ALPHABET_SIZE; ++c1) {\n ~~ ^ ~~~~~~~~~~~~~\n4 errors generated.\n\nBug: 808287\nChange-Id: I57c416b029803d56157152f73c71742e9ba61ab9\nReviewed-on: https://chromium-review.googlesource.com/c/1298232\nCommit-Queue: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#602817}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: fdf87103b6d01dc8b7fa3d7120fa03a53e0b1864" }, { "commit": "0d851528adbe0b9d59d454d7db45aeced1c5f12e", "tree": "2fee1f9e030bfbbeaf8e8860cebaf330f13e9cb0", "parents": [ "b84a9e2e14913f07a01c3726b67bdfccdea86af5" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Thu Oct 18 02:12:30 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 18 02:12:30 2018" }, "message": "Fix BUILD.gn on windows for symbol_level\u003d0\n\n`gn gen` failed due to missing pdb files.\n\nThis is follwup of\nhttps://chromium-review.googlesource.com/c/1279380\n\nTBR: wfh@chromium.org thestig@chromium.org\nChange-Id: I513d10d61a3868953c4afc025adf840e0f3c70c2\nReviewed-on: https://chromium-review.googlesource.com/c/1286108\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#600636}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0b991a325b2c3f83e21b1eace5f4d4eb73cf42b5" }, { "commit": "b84a9e2e14913f07a01c3726b67bdfccdea86af5", "tree": "3d04c8a64aa5c918d0adea42791152beb58fa58a", "parents": [ "89446922af1cbcbdce41896bd35725d4736e3aa0" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Sat Oct 13 19:20:00 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Oct 13 19:20:00 2018" }, "message": "win/32-bit: only copy pdbs if symbol_level \u003e 0.\n\npdbs are only created if symbol_level \u003e 0, so don\u0027t try to copy them when\nthey don\u0027t exist. (Official builds use symbol_level\u003d2 and aren\u0027t affected\nby this.)\n\nTBR\u003dpastarmovj,wfh\n\nBug: 894725\nChange-Id: If27fc004ed31497bba18e720ced2a2cb0efd3c65\nReviewed-on: https://chromium-review.googlesource.com/c/1279380\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#599517}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bfecf059991550723ad085bf81c704ab9eb72495" }, { "commit": "89446922af1cbcbdce41896bd35725d4736e3aa0", "tree": "41299c965384db658f4dfc6a50aaa9d4fafc0def", "parents": [ "719c84e79b0383a4925c1fb71fdac6eff1fb760c" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Sat Oct 13 14:47:39 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Oct 13 14:47:39 2018" }, "message": "win/32-bit: copy courgette64.exe.pdb and gcp_portmon64.dll.pdb to the root build dir.\n\nThe binary itself was already being copied over, and since the binaries\nnow contain only the basename of the pdb, the pdb must be next to it\nfor the symbol upload scripts to work.\n\nTBR\u003dpastarmovj,wfh\n\nBug: 894725\nChange-Id: If57fda6a8e4610994b948a0e628dac750a3ff7ad\nReviewed-on: https://chromium-review.googlesource.com/c/1279373\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#599513}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c13a10b85120f967920ffa056b4ed967b049fa4e" }, { "commit": "719c84e79b0383a4925c1fb71fdac6eff1fb760c", "tree": "6d76fe3aec9db444b11d5a2f96b2cb483a8f1bdd", "parents": [ "22e25776cd0c3bb771f379359325ee06c3cd359d" ], "author": { "name": "Will Harris", "email": "wfh@chromium.org", "time": "Fri Aug 31 18:00:28 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Aug 31 18:00:28 2018" }, "message": "Suppress 64-to-32 conversion warnings in courgette\u0027s divsufsort.\n\nThe list of warnings is here:\n\nhttps://pastebin.com/raw/JcPPmeQj\n\nThis involved restructure courgette\u0027s dependencies to avoid cycles.\n\nNew dependency chart looks like:\n\n +----------------+\n | courgette_lib |\n +------+---+-----+\n | |\n+-------------+ | |\n| bsdiff \u003c---------------+ |\n+---+------+--+ |\n | | |\n | | |\n | +--v---------+ +-------v----------+\n | | divufsort* +----\u003e courgette_common |\n | +--+---------+ +------------------+\n | |\n | |\n+---v------v--+\n| paged_array |\n+-------------+\n\n* -Wno-shorten-64-to-32 applied here.\n\nBUG\u003d588506\n\nChange-Id: Icb853d68693d51b9ef553c2fa0708ca57d126b62\nReviewed-on: https://chromium-review.googlesource.com/1197406\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: Samuel Huang \u003chuangs@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#588087}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f324d18a0dded31c6e49e92ed38e98a0a3d45a76" }, { "commit": "22e25776cd0c3bb771f379359325ee06c3cd359d", "tree": "871a0608db62a845e1756cb9a39511c5241c8144", "parents": [ "c360fb440d30423ff52d27d33d7b5aea707754e2" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Wed May 30 22:20:37 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 30 22:20:37 2018" }, "message": "Remove references to exe_and_shlib_deps in src\n\nAfter [1], a manual dependency on exe_and_shlib_deps is no longer necessary\nsince it\u0027s automatically added. This CL removes all remaining manual references\nto exe_and_shlib_deps.\n\n[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5\n\nBUG\u003d845700\nR\u003ddpranke\nTBR\u003dsky,mark\n\nCq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet\nChange-Id: I647442fb09eba4c055697bf26504abc3b3284d94\nReviewed-on: https://chromium-review.googlesource.com/1073613\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#563028}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ce772faa73ab8fa58e848b61b786d449bb988237" }, { "commit": "c360fb440d30423ff52d27d33d7b5aea707754e2", "tree": "b01a1d56fec3449d99a57c391a6528e7f046fa05", "parents": [ "5c94f28e2edf5713d08439a306e6d40f4c970370" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Mon May 07 18:55:12 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon May 07 18:55:12 2018" }, "message": "Fully move PathService into the base namespace.\n\nBUG\u003d838398\n\nCq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.win:win10_chromium_x64_rel_ng\nChange-Id: Ibb79d0d8090cece52d7a20269153718992c8c2d1\nReviewed-on: https://chromium-review.googlesource.com/1036570\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#556512}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ea15ea06b514d9a95af39d7e35235fdf948da0c8" } ], "next": "5c94f28e2edf5713d08439a306e6d40f4c970370" }