Migrate to NOTREACHED() in low-instance top dirs
NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.
The former is [[noreturn]] so this CL also performs dead-code removal
after the NOTREACHED().
This CL does not attempt to do additional rewrites of any surrounding
code, like:
if (!foo) {
NOTREACHED();
}
to CHECK(foo);
Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.
Bug: 40580068
Low-Coverage-Reason: OTHER Should-be-unreachable code
Change-Id: I2b1f8d4f456e2686035098e67bd2dfde04eefbc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872509
Owners-Override: Lei Zhang <thestig@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1358092}
NOKEYCHECK=True
GitOrigin-RevId: 89c82708f7afa9c16afca5e69a0c6294668ec7f9
3 files changed
