)]}' { "log": [ { "commit": "f71b8ff9f69c3ac39dde1000ec248f1b152e125c", "tree": "7c5d7fd903f2217d74a15b0077e4104561adb12d", "parents": [ "c7a3215585d2bae14b2f4628c6b28fa88fdb1c4c" ], "author": { "name": "Alexei Svitkine", "email": "asvitkine@chromium.org", "time": "Thu Mar 26 13:04:03 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 26 13:07:44 2026" }, "message": "Cleanup: Remove histogram macros header includes in dbus\n\nBug: None\nChange-Id: I50876285d6abbef629c425adb72ed15db4a85f74\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7700161\nAuto-Submit: Alexei Svitkine \u003casvitkine@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1605431}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: af687bc5e07d5b8c5bcb90808ba57495546a4347\n" }, { "commit": "c7a3215585d2bae14b2f4628c6b28fa88fdb1c4c", "tree": "b7e353bcca96bb7cd1abe6e73fdff21bd21fa7b4", "parents": [ "8913b4187c04c04ae7c4c194fd5f6abebdeb260a" ], "author": { "name": "Steven Bennetts", "email": "stevenjb@chromium.org", "time": "Wed Mar 25 00:54:03 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 25 00:58:03 2026" }, "message": "Remove stevenjb@ from dbus OWNERS\n\nChange-Id: I413a7264649c0eea8734b8c921d0b1518d115739\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7697932\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nAuto-Submit: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1604509}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5140d9add390f1f413f14c8d13d8209c5ea144ae\n" }, { "commit": "8913b4187c04c04ae7c4c194fd5f6abebdeb260a", "tree": "6d29a5d4b9c10e93d72f026b47f82bc7242e53b0", "parents": [ "fe14a2b2ce1d0043a0c4730a66b5f13e46f2fcba" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Mar 12 09:03:58 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 12 09:12:30 2026" }, "message": "Fix unsafe buffer usage in dbus/property_unittest.cc\n\nReplaced memcmp with base::span comparison and an unsafe vector\nconstruction with a safe iterator-based one to fix unsafe buffer\noperations.\n\nInitial patchet generated by headless gemini-cli using:\n//agents/prompts/projects/spanification/run.py\n\nFixed: 455864224\nChange-Id: I6be65a24c981c94cc5683e3b8fdac2134bc12d0b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7088289\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1598280}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8f0e01bb263f170d202f5ec4be5f96c8f73f6b6a\n" }, { "commit": "fe14a2b2ce1d0043a0c4730a66b5f13e46f2fcba", "tree": "47a8b05e19518dc26974036e8c078e193d0c5ee8", "parents": [ "ff06602a0f9540253257e75705b8c0f3f72f8ff2" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Fri Jan 23 19:46:25 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 23 19:52:04 2026" }, "message": "Use modern names for base::DictValue and base::ListValue\n\nThese classes were hoisted and renamed; switch all usage of these\nclasses to use the new names.\n\nThis is a strictly mechanical change.\n\nBug: 478100525\nChange-Id: Idf665ba71433a8dcad943d24a7feabebdcf3b985\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7509679\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1573853}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 18084c7a63f2abe19bcd328d3f8e7c49b81320cc\n" }, { "commit": "ff06602a0f9540253257e75705b8c0f3f72f8ff2", "tree": "ff8a3adab2c0b68cce91366566d716abd77574a0", "parents": [ "4296e1c7a78ce72dabed9a4eefd7856bf77ab25e" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Tue Jan 06 10:59:00 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 06 11:07:23 2026" }, "message": "Migrate various base::Contains() to contains() in dbus\n\nBug: 470391351\nChange-Id: I9da361f58d3c27647c34f62c93d060bba37acb51\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7367479\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1564875}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5ad2af7946f143a02fea0e77e3b1f072362c4376\n" }, { "commit": "4296e1c7a78ce72dabed9a4eefd7856bf77ab25e", "tree": "8a4f4373b339bfd1f4618d0f83fab6a696767fd4", "parents": [ "f71c9128533aefa03ef42919bd6d622e60686bf6" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Dec 19 17:03:07 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 19 17:10:11 2025" }, "message": "Forward declare SingleThreadTaskRunner and SequencedTaskRunner\n\nIn various headers, forward declare SingleThreadTaskRunner and\nSequencedTaskRunner. Then do IWYU to fix the build.\n\nChange-Id: I2044abb7ed35f46b91e98f91eae5f329082e3edf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7257184\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1561189}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c01d5705c2f2837b0859fd2da77b2dd4a0974b14\n" }, { "commit": "f71c9128533aefa03ef42919bd6d622e60686bf6", "tree": "4321a512dde592e62f8bafb460f80ae43da336f1", "parents": [ "773528182d438554b98b110a056a6d266fa9b863" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Thu Nov 13 17:33:11 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 13 17:39:09 2025" }, "message": "Remove superfluous callback.h includes from various headers\n\nRemove unused includes mostly found by heuristics in headers that do not\ncontain keywords like \"Callback\" or \"Closure\".\n\nBug: 40318405\nChange-Id: I64e37f6b0c63f0d82288c0b70bd5344947970091\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7116485\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1544338}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c3eeda94f7b9be9788385df55c6c27699e20fcca\n" }, { "commit": "773528182d438554b98b110a056a6d266fa9b863", "tree": "3a8f1b5cd0e1545314c4e3650bceab4a3220291e", "parents": [ "113b5e2667c9ec58075865d3d43fe0c8dcdcc20e" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Oct 24 23:22:17 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 24 23:27:23 2025" }, "message": "Swap ref_counted.h for scoped_refptr.h when appropriate in various dirs\n\nAt some point, scoped_refptr got split off into its own header. Use it\nin various headers when appropriate in place of ref_counted.h.\n\nMostly automated with the following commands:\n\ngit ls-files chrome | grep \u0027\\.h$\u0027 | \\\n xargs grep -l base/memory/ref_counted.h | xargs grep -L RefCounted | \\\n xargs grep -L REQUIRE_ADOPTION_FOR_REFCOUNTED_TYPE | \\\n xargs grep -l \u0027scoped_refptr\u003c\u0027 | \\\n xargs grep -L base/memory/scoped_refptr.h \u003e list.txt\n\nThen remove files from list.txt for directories to process in separate\nCLs.\n\ncat list.txt | \\\n xargs tools/add_header.py --header \u0027\"base/memory/scoped_refptr.h\"\u0027\n\ncat list.txt | \\\n xargs tools/add_header.py --header \u0027\"base/memory/ref_counted.h\"\u0027 \\\n --remove\n\nThen do IWYU to fix the build.\n\nBug: 40245294\nChange-Id: I8175d67249f79529149d19ee5aabd3c26bf6dd3f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7081865\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1535395}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2fadc65f280651c4a7e59df7ad85ffddaad5097f\n" }, { "commit": "113b5e2667c9ec58075865d3d43fe0c8dcdcc20e", "tree": "42ae6dee17b66323885adc5b6515be59c59dbed6", "parents": [ "089c3ecf93d76bebe0e10a529674e9884b8fc3f1" ], "author": { "name": "Lambros Lambrou", "email": "lambroslambrou@chromium.org", "time": "Tue Oct 21 08:01:54 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 21 08:08:11 2025" }, "message": "Pass Bus::Options by value with std::move.\n\nThis modifies the dbus::Bus constructor to accept the Options parameter\nby value instead of by const-reference. Callers are updated to use\nstd::move() since Bus::Options is a move-only type.\n\nThe intention is to add a new OnceCallback property to Bus::Options in\na followup CL to address the linked bug. This is not possible if\nBus::Options is passed by const-reference.\n\nBug: b:447203893\nChange-Id: I7880c1fd713a53b6c6794c81f389be4a7bf34767\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056670\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Michael Sun \u003cmichaelfsun@google.com\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nAuto-Submit: Lambros Lambrou \u003clambroslambrou@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1532789}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7a20c86873127be0afa5bfb54f2c0cc3a987decb\n" }, { "commit": "089c3ecf93d76bebe0e10a529674e9884b8fc3f1", "tree": "338eaaab337c9e542649cf6dc1bb65d3a489b1f0", "parents": [ "bea75f64f766e9d6ef255b65dffc2f760ffc4b22" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Wed Oct 15 20:35:12 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 15 20:41:15 2025" }, "message": "Remove Do* Methods in MockObjectProxy\n\nAs of April 2017, gmock supports move-only method arguments, so the\nMockObjectProxy::Do* can be removed.\n\nAll changes are trivial except\nnotification_platform_bridge_linux_unittest.cc which migrates some\nACTIONs to templates.\n\nBug: None\nChange-Id: Ifc4c9a97f3778f30832636d4f4d074f0e5212a48\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7037437\nCommit-Queue: Michael Sun \u003cmichaelfsun@google.com\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Michael Sun \u003cmichaelfsun@google.com\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nAuto-Submit: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1530426}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5dad3e5ffb1bc348ebd40d2be9122246b416a917\n" }, { "commit": "bea75f64f766e9d6ef255b65dffc2f760ffc4b22", "tree": "b1ac0a40df06ad41d1ac92760e3c8497ecee2b90", "parents": [ "53e642ab0bf538190ad354e5300850f187385bf8" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed Sep 10 19:16:18 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Sep 10 19:38:44 2025" }, "message": "Remove some deprecated base::JSONWriter::Write() calls in various dirs\n\nMechanically switch from base::JSONWriter::Write() to base::WriteJson()\nfor callers that did not check the return value. Keep the existing\nbehavior and return an empty string on failure.\n\nThis CL was initially AI generated, with human touch-ups. Based on\nhttps://crrev.com/1511773.\n\nBug: 443929217\nChange-Id: I35762c03663c85d8a291ca2f1bd638e0ceadd328\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6929523\nReviewed-by: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nOwners-Override: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1513868}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d42cf56c54db361576eaea45c91077a418e53f0a\n" }, { "commit": "53e642ab0bf538190ad354e5300850f187385bf8", "tree": "74f4bd8ea179a8d5ec953a7d353698fd09b6243e", "parents": [ "53329b65dd2340a78fa6a286d3f104a8f129de64" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Tue Aug 19 22:43:56 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 19 23:02:52 2025" }, "message": "Run unsafe_buffers pragma rewriter over remaining files.\n\nThis pass skips files with conditionally-compiled blocks.\n\nBug: 409340989\nChange-Id: I9c0a7c110ecb70d585f9c13c3c25d311f4393222\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6851755\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1503667}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 38c4b2c659e36ed03bbd7b2852e199f4ccaa06e9\n" }, { "commit": "53329b65dd2340a78fa6a286d3f104a8f129de64", "tree": "d921abac38e842e745de1140429a6c44c7c31c7e", "parents": [ "3701997c9448b74a9222760f90fbce7fac8d2b9b" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Aug 14 10:25:46 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 14 10:33:28 2025" }, "message": "Spanify dbus::MessageReader::PopArrayOf...\n\nThe `MessageReader::PopArrayOf...` methods were returning raw pointers,\nwhich were being accessed unsafely. They have been updated to return a\n`base::span` instead of a raw pointer and size. This makes the API\nsafer, readable and prevents unsafe buffer access.\n\nAll the call sites have been updated, and simplified.\n\nGenerated with gemini-cli, following by multiple AI assisted iterations.\n\nBug: 435317390\nBug: 435682511\nFixed: 435682511\nChange-Id: Icf6332cf7453018da481297836f5cf98ab3d81f7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6811455\nReviewed-by: Reilly Grant \u003creillyg@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1501289}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b77eea0871022fa9a537892679ebfcc09ca34104\n" }, { "commit": "3701997c9448b74a9222760f90fbce7fac8d2b9b", "tree": "c7e7da6531f7759a2ce89211f1516ab1052d164d", "parents": [ "f730997046e7f42714d5fd0bb3c581a8c8b8bddd" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri Aug 01 00:53:21 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 01 01:11:48 2025" }, "message": "Remove deprecated dbus::ObjectProxy::CallMethodWithErrorCallback()\n\nR\u003dhashimoto\n\nBug: 41328956\nChange-Id: Iac68aa0101b11d62992efefad7bb1af1a97e934e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6799255\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1495197}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bfb4bc46e223f92a8ab9d1235dc33ff6584972b5\n" }, { "commit": "f730997046e7f42714d5fd0bb3c581a8c8b8bddd", "tree": "c294bf1dd23032039d520f7102ba44c11ce94a56", "parents": [ "b35224a7f5b591430f70cdf45bb3bd0546d9b9a3" ], "author": { "name": "Devon Loehr", "email": "dloehr@google.com", "time": "Tue May 06 21:23:23 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 21:28:56 2025" }, "message": "Exported things should always be visible\n\nThis changes our COMPONENT_EXPORT macros to make the things they export\nvisible all the time on non-windows, rather than making them visible in\nthe named component only. This avoids subtle bugs where things defined\nin multiple components end up with one copy per component, only one of\nwhich is visible, and so the linker doesn\u0027t know it\u0027s supposed to dedup\nthem.\n\nSome, but not all, of these issues are detected by the new clang warning\n-Wunique-object-duplication. This change addresses some instances of that\nwarning firing on chromium code, but not all. Conversely, there are likely\ninstances which the warning does not catch, which are fixed by this CL.\n\nBug: 368047728\nChange-Id: I829a9bd84e57e3c7d80ec33aea0408951019bde7\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6264795\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Devon Loehr \u003cdloehr@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1456614}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: edf57482697bfb2777c28ab56977f5c448fa5c2d\n" }, { "commit": "b35224a7f5b591430f70cdf45bb3bd0546d9b9a3", "tree": "ea52a938b832abaeef069ba20ad7de5e587e6a94", "parents": [ "ab393d06459404f2e35c2e26284f845ba95d08ce" ], "author": { "name": "Stephen Nusko", "email": "nuskos@chromium.org", "time": "Thu May 01 21:05:37 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 01 21:11:56 2025" }, "message": "spanification: remove `#pragma allow_unsafe_buffers` where unneeded\n\nThis is a clean up of any files that now compile without the pragma.\nThis CL has no behavior changes.\n\nThe original patch was fully automated using script:\n//tools/clang/spanify/remove-unneeded-pragmas.py\n\nand then split with\n`git cl split --target-range 8 32 --max-depth\u003d2 --expect-owners-override --no-reviewers -d ~/description.txt`\n\nThis covers directories:\n[\u0027content\u0027, \u0027chrome\u0027, \u0027sandbox\u0027, \u0027skia\u0027, \u0027dbus\u0027, \u0027remoting\u0027, \u0027testing\u0027]\n\nThis is part of auto spanification see internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 414858406\nChange-Id: I2fc638ec819fde0d50fdfb16a8267dc6b2115025\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6504299\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Stephen Nusko \u003cnuskos@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Yuki Shiino \u003cyukishiino@chromium.org\u003e\nReviewed-by: Joe Downing \u003cjoedow@chromium.org\u003e\nOwners-Override: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1454668}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 00d4083c4d60c705517dd37523e95c0a08d4a191\n" }, { "commit": "ab393d06459404f2e35c2e26284f845ba95d08ce", "tree": "1dd0af2c20cd330d7483a89fb58eff1892fc537c", "parents": [ "abecf9a6402f77ddfb97ed4567be38c2d55e6cca" ], "author": { "name": "Kalvin Lee", "email": "kdlee@chromium.org", "time": "Wed Apr 16 18:28:20 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Apr 16 18:34:40 2025" }, "message": "spanify: Renewed arrayification (X/43)\n\nThis CL is part of the wider spanification / arrayification effort [1]\nand does not (intentionally) introduce behavioral change. It applies the\n`std::array` rewrite to\n\ndbus\n\nas close as possible to the output directly written by `spanify`, with\nno hand-rolled fixes (except where rebasing would require).\n\nThis change (and its siblings taken together) is thought not to cause\nany measurable perf regressions [2].\n\n[1] https://issues.chromium.org/356643982\n[2] https://docs.google.com/document/d/1jughaR6JKn7T-dDjMou10awyNkhE5T-vLY_K2YMqHE4/edit?tab\u003dt.0#heading\u003dh.r2eguxl5lhu7\n\nThis CL was uploaded by an experimental version of git cl split\n(https://crbug.com/389069356).\n\nBug: 406029216\nChange-Id: Ib0dc6d26918cc822eb19a83c56e1690c3a2294cf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6436893\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nOwners-Override: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Yuki Shiino \u003cyukishiino@chromium.org\u003e\nAuto-Submit: Kalvin Lee \u003ckdlee@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1447891}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 078e99bb7800f56b7d63aa6496765fdeb4d4c6b1\n" }, { "commit": "abecf9a6402f77ddfb97ed4567be38c2d55e6cca", "tree": "fb7c661204a3878e6d7e2cbdb74b19dc371d4f0d", "parents": [ "144ef921a586ea944dfe6efd41f99a071d650206" ], "author": { "name": "Xiyuan Xia", "email": "xiyuan@chromium.org", "time": "Fri Mar 21 15:19:04 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 21 15:25:58 2025" }, "message": "dbus: Fix ResponseSender crash caused by lifetime mismatch\n\n`ExportedObject` could out live its method call callbacks.\nIn such case, method call callbacks is no op hence not running\nResponseSender and crash. This CL checks the edge case and\nsend back `DBUS_ERROR_UNKNOWN_METHOD` error response.\n\nFind a simpler way to export method and use it to update\nexisting `NotSendingResponseCrash` as well as adding a new\n`SendFailureForShortLivedObject` to cover the fix. And reverted\nthe previous changes in `TestService`\n\nChange ResponseSender CHECK to LOG(FATAL) to make it easier\nto debug crashes that are not uploaded (hence no crash keys).\n\nRe-enabled the disabled crosier bluetoothe tests.\n\nCq-Include-Trybots: luci.chrome.try:chromeos-trogdor-chrome\n\nBug: 404601483, 400758194\nChange-Id: I578a7b2e902b71351104ce3ec0195ed16920202b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6373547\nCommit-Queue: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1436057}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 70afa29ed2e9b641773bfa6c203ced4bc5aa0e85\n" }, { "commit": "144ef921a586ea944dfe6efd41f99a071d650206", "tree": "53b4935d4b00c134e7d62295a1502609c44d3bb6", "parents": [ "59f3f8529425652f389323e10e09df8910f0790b" ], "author": { "name": "Ryo Hashimoto", "email": "hashimoto@chromium.org", "time": "Wed Mar 12 23:46:27 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 12 23:56:15 2025" }, "message": "dbus: Add crash keys for ObjextProxy::OnCallMethod()\n\nTo identify the caller.\n\nBUG\u003d397080280\nTEST\u003ddbus_unittests\n\nChange-Id: Icce92536ede9d150a0d9c02a326dadefca2ee4fb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6345351\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1431831}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b8904e0f510e82664e587e6b5dc231a3d25235d0\n" }, { "commit": "59f3f8529425652f389323e10e09df8910f0790b", "tree": "c934671b400f60d3e29cea35cee0488fb0ea0bb2", "parents": [ "b4b64ade8b69bf8ef4ee24c32ac1993325f1c74b" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Tue Mar 11 18:40:52 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 11 18:49:04 2025" }, "message": "Migrate absl variant.h and utility.h in dbus\n\nSince https://crrev.com/c/6330348, some utils in\nthird_party/abseil-cpp/absl/types/variant.h and\nand third_party/abseil-cpp/absl/utility/utility.h are only aliases for\ntheir std counterparts. This CL migrates code to use std:: directly.\n\nBug: 40242126\nChange-Id: Id2611ac7a68f34017f0ecad1097b6f2d9de5399d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6343191\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Victor Vianna \u003cvictorvianna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1431035}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 484f554d19ca5fc6527df4cc97fa23956e7358c7\n" }, { "commit": "b4b64ade8b69bf8ef4ee24c32ac1993325f1c74b", "tree": "844e27f23377c338e91d6289fd72d645e938f7ad", "parents": [ "ad889745bb4c6bf792a24c3ac5c5d6b968e74600" ], "author": { "name": "Xiyuan Xia", "email": "xiyuan@chromium.org", "time": "Mon Mar 10 16:01:26 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 10 16:10:00 2025" }, "message": "dbus: Fix `ExportedObjectTest.NotSendingResponseCrash`\n\nCHECK() does not do logging on official build. Use convenience\nwrapper `EXPECT_CHECK_DEATH_WITH` instead.\n\nCq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome\n\nFixed: 401584852, 400758194\nChange-Id: Iad170c16c80f212df1439d34f19c4d061cdfd5f4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6336902\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1430274}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d19505594985b40194600a5061c8b09b566fc29c\n" }, { "commit": "ad889745bb4c6bf792a24c3ac5c5d6b968e74600", "tree": "dc9034f69fd7419cdc76bbc7f2ac3d6091b7e6df", "parents": [ "798668ce9e4fc32df88d384fe948d3e39b103148" ], "author": { "name": "Adithya Srinivasan", "email": "adithyas@chromium.org", "time": "Fri Mar 07 21:43:10 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 07 21:51:25 2025" }, "message": "Gardener: Disable NotSendingResponseCrash\n\nBug: 401584852\nChange-Id: I04c3ffe5009e50a12d9347f241f05ce4c4d1dcff\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330885\nCommit-Queue: Adithya Srinivasan \u003cadithyas@chromium.org\u003e\nOwners-Override: Adithya Srinivasan \u003cadithyas@chromium.org\u003e\nReviewed-by: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1429726}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b8139ee17629cfc79260b8910d7222fc66b841c8\n" }, { "commit": "798668ce9e4fc32df88d384fe948d3e39b103148", "tree": "18e9ba51d2975927805e5929fd3d1bcc95c9e571", "parents": [ "925f50f1125de24dc9c7e44775c8b8e7b7781657" ], "author": { "name": "Xiyuan Xia", "email": "xiyuan@chromium.org", "time": "Fri Mar 07 20:09:18 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 07 20:16:01 2025" }, "message": "dbus: CHECK if a response is not sent after handling calls\n\nThis CL wraps ExportedObject::SendResponse in a helper to ensure\nthat it is invoked before destruction.\n\nBug: 400758194\nChange-Id: I6515f164a0e2594e7313d6e7e0a5cdfe9fa2af94\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6325811\nCommit-Queue: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Michael Sun \u003cmichaelfsun@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1429663}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b90214d46d35787a9bf824b2fcad45d47751c65a\n" }, { "commit": "925f50f1125de24dc9c7e44775c8b8e7b7781657", "tree": "b2b943762857dec62dfbab6a00f9a8eb61f97032", "parents": [ "d1e87fa8e3b31f72323e81373f7a1f00cac0e383" ], "author": { "name": "Xiyuan Xia", "email": "xiyuan@chromium.org", "time": "Thu Feb 20 15:03:04 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 20 15:26:35 2025" }, "message": "dbus: No infinite timeout calls on ChromeOS system daemon\n\nChromeOS system daemon will be configured to have a max reply\ntimeout (of 1 hour). Replace `TIMEOUT_INFINITE` in existing\ncalls with `TIMEOUT_MAX_CHROMEOS` for ChromeOS.\n\nBug: b:388332345\nChange-Id: Ic664ab3047cd396911202e8da6cfd613ce4499a4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6261306\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: David Padlipsky \u003cdpad@google.com\u003e\nCommit-Queue: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nReviewed-by: Michael Sun \u003cmichaelfsun@google.com\u003e\nReviewed-by: Nina Satragno \u003cnsatragno@chromium.org\u003e\nReviewed-by: Igor \u003cigorcov@chromium.org\u003e\nReviewed-by: Achuith Bhandarkar \u003cachuith@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1422528}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2e2f97adb32f3ab6d18e70b7d1421178167cf94c\n" }, { "commit": "d1e87fa8e3b31f72323e81373f7a1f00cac0e383", "tree": "60657d2fc4f72a54fc5e4191127e52adc879327e", "parents": [ "73566dff1aa9056957410bf8edec1fb778ef2a7f" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Jan 29 02:11:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 29 02:21:49 2025" }, "message": "Suppress unsafe_libc_call warning for initial identified files.\n\nSee docs/unsafe_buffers.md for details. Enforcement is not yet\nenabled, but this set of files are not in compliance with the\nnew warnings.\n\nBug: 390223051\nChange-Id: I4e24c2141b9399f572678302c833947494098b29\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187925\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1412673}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8726d30ed0372d085f5d9048ed5a4d62e13015ca\n" }, { "commit": "73566dff1aa9056957410bf8edec1fb778ef2a7f", "tree": "eaee859b0280df5fcabb3030b60963e864d85837", "parents": [ "6c77bec14448f0d167146d617931faa9c87ead3e" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed Jan 15 01:14:13 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 15 01:19:17 2025" }, "message": "Document dbus::ObjectProxy error logging behavior\n\nDescribe how ObjectProxy::CallMethod() and CallMethodWithErrorResponse()\nhandle error logging.\n\nChange-Id: Id2ea4a8297ea0af2f0501e7a97c125d87cda29de\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174382\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1406449}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fa27d53a463a9933aa0b2d000c36ace1f398ff76\n" }, { "commit": "6c77bec14448f0d167146d617931faa9c87ead3e", "tree": "26b2b9131527d1f4f415a8b6548817d843ca307b", "parents": [ "fe1f69e662aeb68fbdc48c4e7350ca020339a132" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Sat Dec 14 18:53:10 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Dec 14 19:01:23 2024" }, "message": "C++11 std::array rewrite for memory safety [17/19]\n\nSplit from:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6004959/21\n\nGenerated patch\n---------------\n- Tool: ./tool/clang/spanify/rewrite-multiple-platform.sh\n- Platform: Linux.\n- Filter: This includes 2400/4222 patches. I included the std::array\n ones and excluded build errors.\n\nGoogle announcement:\n--------------------\nhttps://groups.google.com/a/google.com/g/chrome-memory-safety/c/RMiO4gaVLQA/m/Yz-3NCObAgAJ\n\nBenchmarks:\n----------\nSee design doc and\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6004959/21\n\nDescription\n-----------\nThe consensus during the memory safety summit was to begin rewriting\nrelevant C-style arrays to C++11 std::array. It can be done immediately,\noffers better developer ergonomics, and fix large chunks of the\n-Wunsafe-buffer-usage errors in Chrome.\n\nTo clarify, this effort is complementary to the longer plan work with\nenabling -fsanitize\u003darray-bounds, and we plan to leverage both,\nespecially for protecting 3p code.\n\n[Attached] is a document detailing the rationale, benefits, and\nconsiderations for potential compile-time and performance impacts.\n\n[Attached]:https://docs.google.com/document/d/1z5aBDg26lHmNDjXRCysElWKx7E4PAJXqykI_k7ondJI/edit?tab\u003dt.0#heading\u003dh.cqgo7wvp0kzt\n\nNO_IFTTT\u003dNo need to update base/debug/stack_trace.h\n\nBug: 378069401\nChange-Id: I5d2420ca9261f62a8a21f037ecd1850ecdb58210\nR: dcheng@chromium.org\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039266\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1396391}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 88ba2ce076d07b060f8e629a9a40f62db2aaee50\n" }, { "commit": "fe1f69e662aeb68fbdc48c4e7350ca020339a132", "tree": "107728388d13cc0453a814c886aa7158ba65ae57", "parents": [ "e869ad4cf086dd034b1ec9f71bf57a80704a7f03" ], "author": { "name": "Reilly Grant", "email": "reillyg@chromium.org", "time": "Wed Nov 20 17:24:52 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 20 17:32:22 2024" }, "message": "Use std::string_view to construct dbus::ObjectPath\n\nThis change improves the efficiency of dbus::ObjectPath constructor\ncall sites which typically invoke this method with a compile-time\nconstant.\n\nChange-Id: I8173894ae31939f9864e607b48086564806f229c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6036254\nAuto-Submit: Reilly Grant \u003creillyg@chromium.org\u003e\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1385724}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6576fc650c070d503f42640c3004fec4f49ce80c\n" }, { "commit": "e869ad4cf086dd034b1ec9f71bf57a80704a7f03", "tree": "bce835526600301a6d8d889147f37fba63f09ac3", "parents": [ "0db34cc4c7d30946dba7b006c5e52c8b437604d8" ], "author": { "name": "Reilly Grant", "email": "reillyg@chromium.org", "time": "Mon Nov 18 23:55:32 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 19 00:05:26 2024" }, "message": "Use std::string_view in dbus::Bus::GetObjectProxy\n\nThis change improves the efficiency of call sites which typically\ninvoke this method with a compile-time constant.\n\nChange-Id: Ib8988d4b4ffaaba9c32b511dbd6d5bd9bca9a659\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033411\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Reilly Grant \u003creillyg@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1384658}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 887ed0e584ffacdcafc3010fd893aeb3ba8b2184\n" }, { "commit": "0db34cc4c7d30946dba7b006c5e52c8b437604d8", "tree": "968520898c43bb645a6c4241420b8241387080ca", "parents": [ "ec01488c8788816369773d8c0852dc80bb226e06" ], "author": { "name": "Erik Jensen", "email": "rkjnsn@google.com", "time": "Wed Oct 16 22:20:33 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 16 22:27:42 2024" }, "message": "Reland \"Add wrapper around GDBusConnection.\"\n\nThis is a reland of commit 50d8e75ae0bdaa4db8111a1a45df7ba64cd902d4\n\nFixes GN error when building on Linux with the remoting host disabled.\n\nOriginal change\u0027s description:\n\u003e Add wrapper around GDBusConnection.\n\u003e\n\u003e Allows using standard Chromium sequenced callbacks with weak pointers instead of having to worry about GLib thread contexts and GCancellables. Also supports providing call specifications for type-checked calls.\n\u003e\n\u003e For unit testing, this reuses the D-Bus test service in //dbus, which is pulled out into its own source set so it can be included independently of dbus_test_server.\n\u003e\n\u003e Change-Id: Ib4b87ab3aec22b1fb62b32178461e4b9dbd6b70a\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809854\n\u003e Reviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\n\u003e Reviewed-by: Lambros Lambrou \u003clambroslambrou@chromium.org\u003e\n\u003e Commit-Queue: Erik Jensen \u003crkjnsn@chromium.org\u003e\n\u003e Reviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1368809}\n\nChange-Id: I452360f89d1e039687769e8d450dab4340c8c200\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5935954\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Erik Jensen \u003crkjnsn@chromium.org\u003e\nReviewed-by: Lambros Lambrou \u003clambroslambrou@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1369666}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0cb26c85eeac828cf516b9aefbc164445ae4c44e\n" }, { "commit": "ec01488c8788816369773d8c0852dc80bb226e06", "tree": "f56217261a9629323195458c16eee3512f60f5f0", "parents": [ "d26a6abd4abb19f525ad83b3583956e7bbdc5839" ], "author": { "name": "Dan H", "email": "harringtond@chromium.org", "time": "Tue Oct 15 16:28:54 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 15 16:35:24 2024" }, "message": "Revert \"Add wrapper around GDBusConnection.\"\n\nThis reverts commit 50d8e75ae0bdaa4db8111a1a45df7ba64cd902d4.\n\nReason for revert: Build failure, tree closure\n\nBug: 373635026\n\nOriginal change\u0027s description:\n\u003e Add wrapper around GDBusConnection.\n\u003e\n\u003e Allows using standard Chromium sequenced callbacks with weak pointers instead of having to worry about GLib thread contexts and GCancellables. Also supports providing call specifications for type-checked calls.\n\u003e\n\u003e For unit testing, this reuses the D-Bus test service in //dbus, which is pulled out into its own source set so it can be included independently of dbus_test_server.\n\u003e\n\u003e Change-Id: Ib4b87ab3aec22b1fb62b32178461e4b9dbd6b70a\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809854\n\u003e Reviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\n\u003e Reviewed-by: Lambros Lambrou \u003clambroslambrou@chromium.org\u003e\n\u003e Commit-Queue: Erik Jensen \u003crkjnsn@chromium.org\u003e\n\u003e Reviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1368809}\n\nChange-Id: I33b23c239c427033f001da9a7cccab788dc14833\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5933408\nAuto-Submit: Dan H \u003charringtond@chromium.org\u003e\nReviewed-by: Dan H \u003charringtond@chromium.org\u003e\nOwners-Override: Dan H \u003charringtond@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Dan H \u003charringtond@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1368816}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3e2aadc78c4eec152c9ebf38ac788575511140e3\n" }, { "commit": "d26a6abd4abb19f525ad83b3583956e7bbdc5839", "tree": "968520898c43bb645a6c4241420b8241387080ca", "parents": [ "e277eb4d512e5cf8556a2b01de2e0f5ad2372f80" ], "author": { "name": "Erik Jensen", "email": "rkjnsn@google.com", "time": "Tue Oct 15 16:00:22 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 15 16:09:13 2024" }, "message": "Add wrapper around GDBusConnection.\n\nAllows using standard Chromium sequenced callbacks with weak pointers instead of having to worry about GLib thread contexts and GCancellables. Also supports providing call specifications for type-checked calls.\n\nFor unit testing, this reuses the D-Bus test service in //dbus, which is pulled out into its own source set so it can be included independently of dbus_test_server.\n\nChange-Id: Ib4b87ab3aec22b1fb62b32178461e4b9dbd6b70a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809854\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Lambros Lambrou \u003clambroslambrou@chromium.org\u003e\nCommit-Queue: Erik Jensen \u003crkjnsn@chromium.org\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1368809}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 50d8e75ae0bdaa4db8111a1a45df7ba64cd902d4\n" }, { "commit": "e277eb4d512e5cf8556a2b01de2e0f5ad2372f80", "tree": "f56217261a9629323195458c16eee3512f60f5f0", "parents": [ "c4dc964b4dc0a0fb222e70af2d74f13fe1cc31ae" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Mon Sep 30 17:58:53 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 15 16:08:49 2024" }, "message": "Rewrite map pointer values to raw_ptr\n\nThis cl rewrites CTN\u003ckey, T*\u003e into CTN\u003ckey, raw_ptr\u003cT, CtnExperimental\u003e\u003e\nwhere CTN is one of: std::map, std::unordered_map, base::flat_map\n\nThe following benchmarks were launched to ensure the cl does not\nintroduce any performance regression:\nhttps://pinpoint-dot-chromeperf.appspot.com/job/10ce4602210000\nhttps://pinpoint-dot-chromeperf.appspot.com/job/11e2fc0c210000\nhttps://pinpoint-dot-chromeperf.appspot.com/job/16ca4ca8210000\nhttps://pinpoint-dot-chromeperf.appspot.com/job/168ae33c210000\n\nThe identified bottlenecks were excluded from the rewrite. These are the\ninitial values before exclusions on motionmark_ramp_composite (for\nexample): https://pinpoint-dot-chromeperf.appspot.com/job/16987bf4210000\n\nAfter Exclusions:\nhttps://pinpoint-dot-chromeperf.appspot.com/job/168ae33c210000\n\nAX-Relnotes: n/a.\nChange-Id: I35c52d7427140361410db74e25e0cb8f7bd516db\nBug: 329428315\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5867189\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1361899}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 60a72b0afdb415164c8f72cb0cada4317e4464a1\n" }, { "commit": "c4dc964b4dc0a0fb222e70af2d74f13fe1cc31ae", "tree": "ae3e7b1882eede3c620ac9cc4e1e17ac8841b307", "parents": [ "5ee7d204200143a11e39d643f8b70dc6f0806fcd" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Fri Sep 20 10:54:38 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Sep 20 11:06:09 2024" }, "message": "Migrate to NOTREACHED() in low-instance top dirs\n\nNOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.\nThe former is [[noreturn]] so this CL also performs dead-code removal\nafter the NOTREACHED().\n\nThis CL does not attempt to do additional rewrites of any surrounding\ncode, like:\n\nif (!foo) {\n NOTREACHED();\n}\n\nto CHECK(foo);\n\nThose transforms take a non-trivial amount of time (and there are\nthousands of instances). Cleanup can be left as an exercise for the\nreader.\n\nBug: 40580068\nLow-Coverage-Reason: OTHER Should-be-unreachable code\nChange-Id: I2b1f8d4f456e2686035098e67bd2dfde04eefbc0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872509\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1358092}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 89c82708f7afa9c16afca5e69a0c6294668ec7f9\n" }, { "commit": "5ee7d204200143a11e39d643f8b70dc6f0806fcd", "tree": "f5667b201009695f16eabcb57c299ff145ce6c63", "parents": [ "99920d06d97043103f9e601473dfabab95162b88" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Thu Sep 12 15:26:50 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 12 15:47:20 2024" }, "message": "Add SecretPortalKeyProvider\n\nThis change implements an OSCrypt async client using the Freedesktop\nSecret Service interface. Both gnome-keyring and KWallet expose this\ninterface, so we may eventually remove both of those synchronous\nbackends.\n\nChange-Id: I2462128bf4416e249044e73336961641929dde05\nBug: 40086962\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5792413\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Luc Nguyen \u003clucnguyen@google.com\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1354558}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 64808f96cd669c9430c98be18a22bcb2bea0af9d\n" }, { "commit": "99920d06d97043103f9e601473dfabab95162b88", "tree": "5b39d876185f87c732ebb043e9e7456ea39ce7f6", "parents": [ "3c0719de09f2c6667e2997d59335c158bc1fafc7" ], "author": { "name": "Chad Duffin", "email": "chadduffin@chromium.org", "time": "Mon Aug 05 16:39:42 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 05 16:47:19 2024" }, "message": "dbus: Fix dbus::MessageWriter::AppendString bug\n\nThis change fixes a bug in dbus::MessageWriter::AppendString where we\nwrongly write data that is beyond the bounds of the `std::string_view`\nparameter (but still within the bounds of the `std::string` it\nreferences). This bug exists because we internally convert the\n`std::string_view` to a `char*` which has no notion of size except for\nwhere it is null-terminated. The result is that we append the data from\nthe start of the `std::string_view` but to the end of the `std::string`\nthat it references.\n\nBug: None\nChange-Id: Iea864ca40106e386cd372aabab8225a6eafa1ef8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5742653\nCommit-Queue: Chad Duffin \u003cchadduffin@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1337353}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 61f3296548de41214ee39bca6293a5c6c21061c9\n" }, { "commit": "3c0719de09f2c6667e2997d59335c158bc1fafc7", "tree": "48ca0904ab7c8ed7eaaeb28da3859b300b30aa6b", "parents": [ "a5149a994d45880abdcaf123c0f41c1ca86b8430" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Fri Jul 19 04:53:40 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 19 05:06:40 2024" }, "message": "spanification: Add `#pragma allow_unsafe_buffers` to dbus/*\n\nThis is a preparation to fix each files.\nThis CL has no behavior changes.\n\nThis patch was fully automated using script:\nhttps://paste.googleplex.com/5614491201175552\n\nNote that in patchset2, change to:\n/build/config/unsafe_buffers_paths.txt\nwas reverted. Indeed, running too many (~3) CQ run touching this file is\nmaking the builder cache much slower. I will bundle every change to this\nfile in a subsequent CL. I will limit myself to 1-2 CQ run per day.\n\nSee internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nBug: 351564777\nChange-Id: I3cbfdcb56f5d0829ecf3fadd7b2118f56aec40c9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5718668\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1330034}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fe8f2a5f4979fba9aece40d675bcf91a08660e1e\n" }, { "commit": "a5149a994d45880abdcaf123c0f41c1ca86b8430", "tree": "08401270cecc981d9653921e8e2ad0ad8bc6cf38", "parents": [ "ca46241508967ddd50161aaea2e4c6573771455b" ], "author": { "name": "Satoru Takabayashi", "email": "satorux@chromium.org", "time": "Tue Jun 11 10:40:31 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 11 10:48:48 2024" }, "message": "dbus: Remove satorux@chromium.org from OWNERS\n\nsatorux no longer actively works on the code here.\n\nBug: none\nChange-Id: I8d7eb0e43a669c2945c6eef30b8a6449edfb3caa\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5619963\nAuto-Submit: Satoru Takabayashi \u003csatorux@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1313268}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1c82cc1682c012fa58a0a7ffc92ee8fd99d6b30c\n" }, { "commit": "ca46241508967ddd50161aaea2e4c6573771455b", "tree": "fffaafaf1852e906a98a545a1f7ddc20100e0df8", "parents": [ "1ba9ea59aacab6aab89ec2f874e817f50496dc2b" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Thu May 16 23:41:33 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 16 23:50:21 2024" }, "message": "Use NOTREACHED_IN_MIGRATION() in the rest of src/\n\nThis was generated by replacing \" NOTREACHED()\" with\n\" NOTREACHED_IN_MIGRATION()\" and running git cl format.\n\nThis prepares for making NOTREACHED() [[noreturn]] alongside\nNotReachedIsFatal migration of existing inventory.\n\nthird_party/crashpad is still excluded, needs to be changed upstream.\n\nBug: 40580068\nChange-Id: Ia5dbaddf53dba2fedefb67f1d428e8b24e9edffe\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545021\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nAuto-Submit: Peter Boström \u003cpbos@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1302314}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7843eba21442cc636a76d546ca6ea69aacfd621f\n" }, { "commit": "1ba9ea59aacab6aab89ec2f874e817f50496dc2b", "tree": "75c7c3279a1da5c33562f77481f9dd627c2797bb", "parents": [ "e9d2b21c1849562114ee65d145770560310e88e8" ], "author": { "name": "Alison Gale", "email": "agale@chromium.org", "time": "Sat Apr 27 00:39:58 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Apr 27 01:00:30 2024" }, "message": "Migrate TODOs referencing old crbug IDs to the new issue tracker IDs\n\nThe canonical bug format is TODO(crbug.com/\u003cid\u003e). TODOs of the\nfollowing forms will all be migrated to the new format:\n\n- TODO(crbug.com/\u003cold id\u003e)\n- TODO(https://crbug.com/\u003cold id\u003e)\n- TODO(crbug/\u003cold id\u003e)\n- TODO(crbug/monorail/\u003cold id\u003e)\n- TODO(\u003cold id\u003e)\n- TODO(issues.chromium.org/\u003cold id\u003e)\n- TODO(https://issues.chromium.org/\u003cold id\u003e)\n- TODO(https://issues.chromium.org/u/1/issues/\u003cold id\u003e)\n- TODO(bugs.chromium.org/\u003cold id\u003e)\n\nBug id mapping is sourced from go/chrome-on-buganizer-prod-issues.\nSee go/crbug-todo-migration for details.\n\n#crbug-todo-migration\n\nBug: b/321899722\nChange-Id: Ibc66b8c440e4bcdef414e77fef4d9874d2ea9951\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493800\nAuto-Submit: Alison Gale \u003cagale@chromium.org\u003e\nCommit-Queue: Alison Gale \u003cagale@chromium.org\u003e\nReviewed-by: Peter Boström \u003cpbos@chromium.org\u003e\nOwners-Override: Alison Gale \u003cagale@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1293330}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 770f3fce3719ee18c102ad0b1a347d82147fbb1a\n" }, { "commit": "e9d2b21c1849562114ee65d145770560310e88e8", "tree": "65b55e227e7814bfab525c51129ba50c7d6e4399", "parents": [ "1ab1fbf6bc4b0f0cc0b81724df83eb8a9f09dfce" ], "author": { "name": "Shintaro Kawamura", "email": "kawasin@google.com", "time": "Wed Mar 06 04:14:09 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 06 04:21:36 2024" }, "message": "dbus: Update comment of ObjectProxy::WaitForServiceToBeAvailable\n\nIt is important to make clear that callbacks are executed in which\nthread.\n\nAs ObjectProxy::RunWaitForServiceToBeAvailableCallbacks() asserts at its\nfirst line, WaitForServiceToBeAvailableCallback are called in the origin\nthread.\n\nBug: none\nChange-Id: I8e90254edc75040f08ecca48c3227e82ff26f1b9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340776\nReviewed-by: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Shin Kawamura \u003ckawasin@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1268883}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1d3f42a27d83347245fcf8e2f150ff55ccce77da\n" }, { "commit": "1ab1fbf6bc4b0f0cc0b81724df83eb8a9f09dfce", "tree": "fbef6ebcc37716d30b1e810990ee15147fb37a17", "parents": [ "c12f9a88efb05cc7020cc5343bfc7d014c4f090d" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Feb 29 19:39:05 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 29 19:46:40 2024" }, "message": "Cleanup: Format \u003coptional\u003e include order.\n\nThis is an automated patch. Please avoid assigning unrelated bug.\n #cleanup\n\nThis is a follow-up to @thestig comment:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/5009410/7/pdf/accessibility_helper.cc#11\n\nSeveral developers, including myself rewrote optional without properly\nreordering the #includes at the beginning.\nThis patches automatically fixes it.\n\nScript:\n-------\n\n```\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n | cut -f1 -d: \\\n | grep -v \\\n -e \"*win*\" \\\n -e \"third_party/*\" \\\n -e \"tools/*\" \\\n | grep \\\n -e \"\\.h\" \\\n -e \"\\.cc\" \\\n | sort \\\n | uniq \\\n | xargs sed -i \"s/$1/$2/g\"\n}\n\nreplace \"#include \u003coptional\u003e\" \"\"\ngit add -u\ngit commit -m \"remove optional\"\ngit revert HEAD --no-commit\ngit add -u\necho \"Formatting\":\necho \"IncludeBlocks: Regroup\" \u003e\u003e \".clang-format\"\necho \"IncludeIsMainRegex: \\\"(_(android|apple|chromeos|freebsd|fuchsia|fuzzer|ios|linux|mac|nacl|openbsd|posix|stubs?|win))?(_(unit|browser|perf)?tests?)?$\\\"\" \u003e\u003e \".clang-format\"\ngit add -u\ngit cl format --upstream\u003dHEAD\ngit checkout origin/main -- \".clang-format\"\ngit add -u\ngit commit -m \"revert with format\"\ngit reset --soft origin/main\ngit add -u\ngit commit -m \"Automated format\"\n```\n\ncleanup: This is a no-op patch formatting includes.\nBug: 40288126\nChange-Id: I5f61b1207c097a4c6b20a034f9d1b323975b1851\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5335142\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1267143}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5bc3326c91b582cbec543bc9896201a1c56bdebd\n" }, { "commit": "c12f9a88efb05cc7020cc5343bfc7d014c4f090d", "tree": "9d338db2e40766832db9859ff8e0eb5b5c9200bb", "parents": [ "6782be786bd0f71df3af66cc2e16524a7a02ff4c" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Fri Feb 09 14:01:52 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 09 14:10:18 2024" }, "message": "Rewrite std::set\u003cT*\u003e into std::set\u003craw_ptr\u003cT, SetExperimental\u003e\u003e\n\nThis patch was generated by running\n./tools/clang/rewrite_templated_container_fields/rewrite-multiple-platforms.sh\n\nAX-Relnotes: n/a.\nBug: 41486235\nChange-Id: If9280b93e10508add3c9842f2b2ae190bb65c364\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272231\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1258472}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 133b2d903fa57cfda1317bc589b349cf4c284b7c\n" }, { "commit": "6782be786bd0f71df3af66cc2e16524a7a02ff4c", "tree": "7f69d5d5d2c114ee5b642323cb9378288d920c76", "parents": [ "0f93bb1e38113012590df0ce91ea81a8ecc2e728" ], "author": { "name": "Jeff Yoon", "email": "jeffyoon@google.com", "time": "Thu Jan 25 16:51:37 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 25 16:58:51 2024" }, "message": "[buganizer] Migrate DIR_METADATA for dbus/\n\nMigrate all metadata files for dbus/ and mixins\nused by metadata files under dbus/.\n\nVerify components with http://b/components/{id} or at\ngo/chrome-on-buganizer-prod-components.\n\nBug: chromium:1518875\nChange-Id: I8dfec877e53f31b4fbd1a2bbf8b642372a65bb15\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235433\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Jeff Yoon \u003cjeffyoon@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1252146}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d9200444e19ee911bab65fe26dbe542921688596\n" }, { "commit": "0f93bb1e38113012590df0ce91ea81a8ecc2e728", "tree": "978353ce345a9ab91c3efab2b6fb9dec7e65716e", "parents": [ "e179a239b9ce5671e73540a8030c436598b5d41b" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Tue Dec 19 17:51:57 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Dec 19 18:03:04 2023" }, "message": "Convert MessageWriter APIs to base::span\n\nChange-Id: Ib24b299232e6f0c09556d4e9d6ccbf07c5efce96\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5126612\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1239219}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 71bf932284c234fbbfe9c8ff987fc0f9dff7658e\n" }, { "commit": "e179a239b9ce5671e73540a8030c436598b5d41b", "tree": "29850de2003d81b47982a73ca746f6fd51d39f09", "parents": [ "9ceaeb472645e6946931e8ab14c7faf1394f40af" ], "author": { "name": "Hyowon Kim", "email": "hyowon@igalia.com", "time": "Fri Nov 24 01:00:56 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 24 01:08:48 2023" }, "message": "Replace base::StringPiece in //dbus with std::string_view\n\nBug: 691162\nChange-Id: I37d4fed4cf78ada804b58525253b3f6f0300d9ff\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5040200\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Hyowon Kim \u003chyowon@igalia.com\u003e\nCr-Commit-Position: refs/heads/main@{#1228616}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: eb6a4c4c4e90ae1c9589f9216520ca40ec0c946e\n" }, { "commit": "9ceaeb472645e6946931e8ab14c7faf1394f40af", "tree": "4824f1e1cf34e3b7fff4b86c4cc7ea4c0cad1152", "parents": [ "70829a8c08597e9070440092ae32c62e5f2756e8" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Fri Nov 10 09:46:54 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 10 09:52:39 2023" }, "message": "Rename {absl \u003d\u003e std}::optional in minor top-level dirs\n\nAutomated patch, intended to be effectively a no-op.\n\nThis patch gather the changes for every top-level directories with less\nthan 150 files modified:\n # directory\n--- ---------------\n150 remoting\n98 gpu\n87 chromecast\n79 mojo\n70 storage\n65 fuchsia_web\n46 sandbox\n44 android_webview\n38 google_apis\n27 pdf\n25 printing\n20 headless\n13 ipc\n11 crypto\n10 sql\n3 dbus\n2 testing\n2 skia\n2 gin\n2 apps\n1 rlz\n1 codelabs\n\nContext:\nhttps://groups.google.com/a/chromium.org/g/cxx/c/nBD_1LaanTc/m/ghh-ZZhWAwAJ?utm_medium\u003demail\u0026utm_source\u003dfooter\n\nAs of https://crrev.com/1204351, absl::optional is now a type alias for\nstd::optional. We should migrate toward it.\n\nScript:\n```\n\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n\t\t| cut -f1 -d: \\\n\t\t| grep \\\n\t\t\t-e \"^codelabs\" \\\n\t\t\t-e \"^rlz\" \\\n\t\t\t-e \"^apps\" \\\n\t\t\t-e \"^gin\" \\\n\t\t\t-e \"^skia\" \\\n\t\t\t-e \"^testing\" \\\n\t\t\t-e \"^dbus\" \\\n\t\t\t-e \"^sql\" \\\n\t\t\t-e \"^crypto\" \\\n\t\t\t-e \"^ipc\" \\\n\t\t\t-e \"^headless\" \\\n\t\t\t-e \"^printing\" \\\n\t\t\t-e \"^pdf\" \\\n\t\t\t-e \"^google_apis\" \\\n\t\t\t-e \"^android_webview\" \\\n\t\t\t-e \"^sandbox\" \\\n\t\t\t-e \"^fuchsia_web\" \\\n\t\t\t-e \"^storage\" \\\n\t\t\t-e \"^mojo\" \\\n\t\t\t-e \"^chromecast\" \\\n\t\t\t-e \"^gpu\" \\\n\t\t\t-e \"^remoting\" \\\n\t\t| sort \\\n\t\t| uniq \\\n\t\t| grep \\\n\t\t\t-e \"\\.h\" \\\n\t\t\t-e \"\\.cc\" \\\n\t\t\t-e \"\\.mm\" \\\n\t\t\t-e \"\\.py\" \\\n\t | xargs sed -i \"s/$1/$2/g\"\n}\n\nreplace \"absl::make_optional\" \"std::make_optional\"\nreplace \"absl::optional\" \"std::optional\"\nreplace \"absl::nullopt\" \"std::nullopt\"\nreplace \"absl::in_place\" \"std::in_place\"\nreplace \"absl::in_place_t\" \"std::in_place_t\"\nreplace \"\\\"third_party\\/abseil-cpp\\/absl\\/types\\/optional.h\\\"\" \"\u003coptional\u003e\"\ngit cl format\n```\n\nCQ_INCLUDE_TRYBOTS\u003dluci.chrome.try:chromeos-betty-pi-arc-chrome\n\nBug: chromium:1500249\nChange-Id: I0eca8ff96f5712ba746ac8d8da93d03a86d8292c\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5009410\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1222826}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 59ac8227c5dd59754331b3f7f9f85e1a947f1242\n" }, { "commit": "70829a8c08597e9070440092ae32c62e5f2756e8", "tree": "c2fc2811c8db6da857b95c2daacf3cb3868a6d25", "parents": [ "2d13de3b7db3856282978d7ccf439b45393652e3" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Oct 03 17:31:51 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 03 17:41:37 2023" }, "message": "Enable wexit_time_destructors config in //dbus\n\nEnsure C++ code in this directory do not accidentally add exit time\ndestructors going forward.\n\nBug: 101600\nChange-Id: I1d3783c5d038ac3a5ad09ce02bad92f3380004e9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4907784\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1204732}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: db3334fb0299f4f0ee929537ec74022fe66837f4\n" }, { "commit": "2d13de3b7db3856282978d7ccf439b45393652e3", "tree": "ff44b1a52ddf100e914edfb93cef0d98e23292e4", "parents": [ "508ddd07a9ec8897cec2b0f2b513e8944fddfaa0" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Tue Sep 05 09:26:45 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 05 09:32:24 2023" }, "message": "Fix dangling pointers in DBus during Shutdown.\n\n@alimariam reported the dangling pointer detector found a new dangling\npointer when running tests on linux Workstation.\n\nThe error is:\n```\n The memory was freed at:\n #3 allocator_shim::internal::PartitionFree()\n #4 bluez::BluezDBusThreadManager::~BluezDBusThreadManager()\n #5 bluez::BluezDBusThreadManager::Shutdown()\n #6 ChromeBrowserMainPartsLinux::PostDestroyThreads()\n #7 content::BrowserMainLoop::ShutdownThreadsAndCleanUp()\n #8 content::BrowserMainRunnerImpl::Shutdown()\n #9 content::BrowserMain()\n #10 content::RunBrowserProcessMain()\n #11 content::ContentMainRunnerImpl::RunBrowser()\n #12 content::ContentMainRunnerImpl::Run()\n #13 content::RunContentProcess()\n #14 content::ContentMain()\n #15 ChromeMain\n\n The dangling raw_ptr was released at:\n #3 base::internal::RawPtrBackupRefImpl\u003c\u003e::ReleaseInternal()\n #4 dbus::ObjectManager::~ObjectManager()\n #5 std::__Cr::__tuple_impl\u003c\u003e::~__tuple_impl()\n #6 base::internal::BindState\u003c\u003e::Destroy()\n #7 base::[...]::LazilyDeallocatedDeque\u003c\u003e::Ring::~Ring()\n #8 base::[...]::TaskQueueImpl::UnregisterTaskQueue()\n #9 base::[...]::SequenceManagerImpl::UnregisterTaskQueueImpl()\n #10 base::sequence_manager::TaskQueue::ShutdownTaskQueue()\n #11 content::BrowserTaskQueues::~BrowserTaskQueues()\n #12 content::BrowserUIThreadScheduler::~BrowserUIThreadScheduler()\n #13 content::BrowserTaskExecutor::[...]::~UIThreadExecutor()\n #14 content::BrowserTaskExecutor::[...]::~UIThreadExecutor()\n #15 content::BrowserTaskExecutor::Shutdown()\n #16 content::ContentMainRunnerImpl::Shutdown()\n #17 content::RunContentProcess()\n #18 content::ContentMain()\n #19 ChromeMain\n```\n\nDiagnostic:\n- `bluez::BluezDBusThreadManager` owns a `dbus::Bus` as `system_bus`.\n- `dbus::Bus` owns:\n - The set of `dbus::ObjectManager` as `object_manager_table_`.\n - The DBus task runner as `dbus_task_runner_`.\n- The `dbus::ObjectManager` references `dbus::Bus` via `bus_`.\n\nSo far so good, the ownership is clear. The problem happens when calling\n`dbus::Bus::RemoveObjectManager`. Indeed this moves the ObjectManager\nout of `dbus::Bus` toward a callback to a new thread. This still works\ntransitively, because the dbus::Bus owns the thread. The problem happens\nafter a second transfer back to the original thread.\n\nIndeed, there is a race condition possible:\n\nBehavior without problems: -----------------------------------\n\n┌─────────────┐ ┌───────────┐\n│Origin thread│ │DBus thread│\n└──────┬──────┘ └─────┬─────┘\nRemoveObjectManager() │\n │────────────────────────────────\u003e│\n │ RemoveObjectManagerInternal()\n │\u003c────────────────────────────────│\nRemoveObjectManagerInternalHelper() │\n~ObjectManager() │\n │ ┌─────┴─────┐\nShutdown DBus Thread ─────────────\u003e│DBus thread│\nShutdown DBus Thread \u003c─────────────│DBus thread│\n │ └───────────┘\n ~Bus\n┌──────┴──────┐\n│Origin thread│\n└─────────────┘\n\nBehavior with problems: ----------------------------------------\n\n┌─────────────┐ ┌───────────┐\n│Origin thread│ │DBus thread│\n└──────┬──────┘ └─────┬─────┘\nRemoveObjectManager() │\n │────────────────────────────────\u003e│\n │ RemoveObjectManagerInternal()\n │ ┌────────────│\n │ │ ┌─────┴─────┐\nShutdown DBus Thread ─────────────\u003e│DBus thread│\nShutdown DBus Thread \u003c─────────────│DBus thread│\n │ │ └───────────┘\n ~Bus() │\n │ │\n │\u003c───────────────────┘\nRemoveObjectManagerInternalHelper()\n~ObjectManager()\n┌──────┴──────┐\n│Origin thread│\n└─────────────┘\n-----------------------------------------------------------------\n\nIn the second case: ~Bus() is called before ~ObjectManager().\n\nThe fix is a use `ObjectManager::Cleanup()` to cleanup the raw_ptr while\nthe object is still transitively owned by the object it referenced.\n\nBug: chromium:1478759\nFixed: chromium:1478759\nChange-Id: I4ac04d449ab8a7b860256c490f8ac878c1c5c7c5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839496\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1192343}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bcb156213bee63d24813d2203ef5c36f81785687\n" }, { "commit": "508ddd07a9ec8897cec2b0f2b513e8944fddfaa0", "tree": "4c786958c0f80515c0f6141510ed0498fd3ff26a", "parents": [ "85011e52fea20c42b7292c4a62972b70b1ee35ad" ], "author": { "name": "Ho Cheung", "email": "uioptt24@gmail.com", "time": "Wed Aug 16 16:29:27 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 16 16:36:18 2023" }, "message": "[dbus] Use base::Contains() instead of std::find() in //dbus\n\nUse base::Contains() instead of std::find() where appropriate in\n//dbus.\n\nBug: 561800\nChange-Id: Id31974ee5e7c559e5d1df6836586fda52ee228af\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4783169\nCommit-Queue: Ho Cheung \u003cuioptt24@gmail.com\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1184198}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 361ebe3b561c196adb2d35ce580a1251155e3f68\n" }, { "commit": "85011e52fea20c42b7292c4a62972b70b1ee35ad", "tree": "f36d11297457c84780cf9cc3228854f42e8feb2e", "parents": [ "28bd1a7ad7db522a0e2075426155de603b3d252a" ], "author": { "name": "Nikhil Nayunigari", "email": "nikhilcn@google.com", "time": "Fri Jul 28 01:41:56 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 28 01:48:44 2023" }, "message": "[CrOS Cellular] Emit DBus results for eSIM installation attempts\n\nThis CL makes changes to log DBus results as a new metric for all eSIM\ninstallation attempts. DBus results are only logged when we receive an\nunknown response code from Hermes.\n\nBug: b/293524299\nChange-Id: Id946c0a061dd31f1498a8d09eed937ed16c99711\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4714407\nReviewed-by: Chad Duffin \u003cchadduffin@chromium.org\u003e\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Nikhil Nayunigari \u003cnikhilcn@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1176393}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1ede90c26d1a6b01f825caea9f38b9ff5024270c\n" }, { "commit": "28bd1a7ad7db522a0e2075426155de603b3d252a", "tree": "88ecdc8058e389ada6deb232e519d1580f9d0586", "parents": [ "3a31089d773112cd468f5d9b3fd63330e0e81bb5" ], "author": { "name": "Pâris", "email": "pmeuleman@chromium.org", "time": "Wed Jul 19 09:00:43 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 19 09:10:06 2023" }, "message": "Rename DanglingAcrossTasks to AcrossTasksDanglingUntriaged\n\nFollowing up on https://chromium-review.googlesource.com/c/chromium/src/+/4567353/comments/67bd2f0d_b10f9056\nAdd back DanglingUntriaged into the name of this trait.\nKeep the name consistent with other traits.\n\nChange-Id: I2702f843d9e81b87656ca31fd4c9ba19943d44d9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4675808\nCommit-Queue: Pâris Meuleman \u003cpmeuleman@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1172247}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e6361d070be0adc585ebbff89fec76e2df4ad768\n" }, { "commit": "3a31089d773112cd468f5d9b3fd63330e0e81bb5", "tree": "00069cc8675fe302b4239201247611d9d733564b", "parents": [ "eb4edf33508f0b8986ebed7b987de43933746877" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Fri Jul 14 02:17:58 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 14 02:27:03 2023" }, "message": "Merge ObjectProxy::CallMethodAndBlock{,WithErrorDetails}.\n\nWe had two variation of methods and the gap was one function takes\nerror as output arg, while the other does not.\n\nThis CL unifies these two by using base::expected recently added.\n\nBUG\u003d1459945\nTEST\u003dTryjob\n\nChange-Id: I8be049aa1f9a2b2833f55571fa3e0bed37a97dc8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670865\nReviewed-by: Kyle Horimoto \u003ckhorimoto@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1170299}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f1f723353c6ed4d33694e8f2fad1b983f813006c\n" }, { "commit": "eb4edf33508f0b8986ebed7b987de43933746877", "tree": "3ab1ea01ad3a3f74b7a38d497bc69cd2d0d4f6dd", "parents": [ "0eab7c903e48b79593ed6004eb33c8cabce6a1cd" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Thu Jul 06 11:18:10 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 06 11:23:24 2023" }, "message": "Get rid of Error out param from SendWithReplyAndBlock.\n\nTo make it clearer what is input/output, and also let callers access\nerrors only for error cases.\n\nBUG\u003d1459945\nTEST\u003dRan tryjob\n\nChange-Id: I9ecb129fbf6c7ac142604e29585b7bc8a61dfca0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4666670\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1166444}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ac7a3c54d0c4a22fdef4ff6a06ea86d2eec899ec\n" }, { "commit": "0eab7c903e48b79593ed6004eb33c8cabce6a1cd", "tree": "d4f928d4af09f75faca2ca25ea8d8c45e14be491", "parents": [ "955f06930fb68d37a0382593afa862efd12402e4" ], "author": { "name": "Hidehiko Abe", "email": "hidehiko@chromium.org", "time": "Thu Jul 06 07:34:38 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 06 07:44:35 2023" }, "message": "Introduce dbus::Error.\n\nAnd hide DBusError from outside of dbus/.\n\nBUG\u003d1459945\nTEST\u003dTryjob\n\nChange-Id: Iea55971dd4d714a4139675a56e73b86755dd6eaf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664079\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Hidehiko Abe \u003chidehiko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1166347}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3afb59a10d2d130f17195d2d611195ee439c917e\n" }, { "commit": "955f06930fb68d37a0382593afa862efd12402e4", "tree": "44ee730c83decce85b7d99458ee4526570a6b5cc", "parents": [ "4b1a1279b9c055955148c96931cd356ceb3ee323" ], "author": { "name": "Pâris", "email": "pmeuleman@chromium.org", "time": "Thu Jun 29 18:23:48 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 29 18:40:55 2023" }, "message": "Annotate all Across tasks dangling raw_ptrs\n\nThis follows up on https://crrev.com/c/4567353 and annotates all\nraw_ptrs that were detected as dangling across tasks on the CQ in the\nfollowing CL https://crrev.com/c/4166936.\n\nChange-Id: I8ac81276b72c315d7624008cf7421a419b7786ea\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4650611\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Pâris Meuleman \u003cpmeuleman@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1164246}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 508dce9dea93d32b154ed6d6d67dd29d336c4e1e\n" }, { "commit": "4b1a1279b9c055955148c96931cd356ceb3ee323", "tree": "04a71ca3e5036ee95ff85d56db40ff2b1681f82c", "parents": [ "8d2f6f3339b2d43b50442311cda43d2bddae4b57" ], "author": { "name": "Pâris", "email": "pmeuleman@chromium.org", "time": "Tue Jun 27 08:12:51 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 27 08:21:08 2023" }, "message": "Annotate Cross task dangling pointers detected on Linux builds\n\nThis adds the DanglingAcrossTasks keyword and annotates raw_ptrs that\nare \"dangling cross task\", i.e. that are freed and released in\ndifferent tasks.\nThese are more likely to allow UAFs and therefore are prioritized\nover other dangling raw_ptr (Those remaining with DanglingUntriaged).\n\nProtocol used:\n1. Apply automatic dangling pointer annotation: crrev.com/c/4474553\n2. Disable \"DanglingUntriaged\":\n``` base/allocator/partition_allocator/pointers/raw_ptr.h:\nconstexpr auto DanglingUntriaged \u003d base::RawPtrTraits::kEmpty ```\n3. Configure Dangling pointer detection for cross tasks detection and logging only.\n4. Run all tests using https://docs.google.com/document/d/1AMMERcqy0eafFWopUCHYsIKIKEp3J8DFxqW9UIbzIHo/edit?pli\u003d1\u0026resourcekey\u003d0-e12-tlqsWfAOkle97uWw3w\n5. Concatenate and filter output:\n``` cat output_* | sort -nr | uniq | sed -e \u0027s/\\(.\\)Found/\\1\\nFound/g\u0027 | grep -a -e \"../../\" | sed \u0027s_^.*\\.\\./\\.\\./__\u0027 | sort | uniq \u003e test_output_all\n6. Apply the annotation using https://docs.google.com/document/d/1SGMZAaoEb6J0-NQO5V07TShxGAL5bxVN08TylBOrSCw/edit?usp\u003dsharing\n\nChange-Id: If176e8f7269ec4a95976e351e9b35a5cb8e4c699\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567353\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nAuto-Submit: Pâris Meuleman \u003cpmeuleman@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCommit-Queue: Pâris Meuleman \u003cpmeuleman@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1162824}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4332a2f3be882f937dcb8ae8e205d910d786b20a\n" }, { "commit": "8d2f6f3339b2d43b50442311cda43d2bddae4b57", "tree": "46341a43a6ddd6106a795abc910b6ead1610b0d7", "parents": [ "ccdf2bd0a36a456d8561075aca4b5747a54c6d3b" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Thu Jun 01 15:02:25 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 01 15:09:07 2023" }, "message": "DanglingPointer: annotate for unittests base+linux [1/N]\n\nThe DanglingPointerDetector is configured only when the test enters the\nContentMain function. See https://crbug.com/1400059\n\nI would like to configure it no matter the kind of test. For this to\nhappen, we need to annotate every pre-existing dangling pointers.\n\nThis patch annotates the ones you can find by running targets depending\non the GoogleTest library.\n\nStatistic:\n\nThis adds 1776 new DanglingUntriaged. Among them:\n- 1288 are in unittests.\n- 488 are in implementation.\n\nTo produce those numbers, I used the command:\n```bash\ngit diff annotate-linux origin/main -- \"*test*\" | grep \"DanglingUntriaged\" | wc -l\n```\n\nThis patch has been generated by:\n\n1. Apply the \"auto-annotator\" patch:\n https://chromium-review.googlesource.com/c/chromium/src/+/4474553\n\n2. Compile the compiler again:\n ```bash\n ./tools/clang/scripts/build.py\n ```\n\n3. List and run all the targets. You can use a bash script like:\n https://docs.google.com/document/d/1AMMERcqy0eafFWopUCHYsIKIKEp3J8DFxqW9UIbzIHo\n\n4. Concatenate output, filter by \"Found dangling ptr\", sort, remove\n duplicate.\n\n5. Apply the rewriter script from:\n https://github.com/ArthurSonzogni/chrome-dangling-ptr-apply-edit\n\n6. Revert the \"auto-annotate\" patch.\n\n7. Apply `git cl format`\n\nAX-Relnotes: n/a.\nBug: chromium:1400059\nChange-Id: I217d5c0b925da5176fc53baf95919a3690f1e9a3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4570424\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1151859}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e98d214c48dd94a2b4363b384e952a32258b9487\n" }, { "commit": "ccdf2bd0a36a456d8561075aca4b5747a54c6d3b", "tree": "fed5cefe553427fbdcece9e645666ddccc41cc34", "parents": [ "3f55de10f29eadd3f5f33d88108c6a24fe18dd1f" ], "author": { "name": "Claudio DeSouza", "email": "cdesouza@igalia.com", "time": "Tue May 02 03:43:00 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 02 03:49:47 2023" }, "message": "Replace base::GUID uses with base::Uuid (222/N)\n\n`base::GUID` has been renamed, and is set to be removed. This CL is\npart of a batch of changes replacing all uses of `base::GUID`, with\n`base::Uuid`, and its associated counterparts.\n\nAdditionally, deprecated functions in `base/uuid.h` are also having\ntheir uses removed wherever they occur.\n\nChanges for path: /dbus\n\nThis CL was uploaded by git cl split.\n\nR\u003dhashimoto@chromium.org\n\nBug: 1428566\nChange-Id: I106776d7ab02a3ebc3b9b9eaf2fd4bb0133eee06\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4483705\nAuto-Submit: Claudio DeSouza \u003ccdesouza@igalia.com\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1138152}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e77e4c4e79ec3c753306b708d3a324626a20a155\n" }, { "commit": "3f55de10f29eadd3f5f33d88108c6a24fe18dd1f", "tree": "e3c8baaab8489f2a2325c4b174633d4497eb6c78", "parents": [ "70fce449fdb69c37dbea96308c5d5107e101893f" ], "author": { "name": "Sergii Bykov", "email": "sbykov@google.com", "time": "Fri Apr 14 14:46:09 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 14 14:51:52 2023" }, "message": "[Code Health] Remove expired DBus histograms\n\nBug: 1384273\nChange-Id: I1b079076016370049b585da700883d3187e7a119\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4417678\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Ryan Hansberry \u003chansberry@chromium.org\u003e\nCode-Coverage: Findit \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCommit-Queue: Sergii Bykov \u003csbykov@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1130444}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 44e49bca2d18d1e7e22a0dcec451fe011a1ebd73\n" }, { "commit": "70fce449fdb69c37dbea96308c5d5107e101893f", "tree": "903bc2b756ad5ea424619665ba52287d7ad73728", "parents": [ "b57c13b4c81ef5e7ac97a97eadf8d9f6d0a3a804" ], "author": { "name": "Ari Chivukula", "email": "arichiv@chromium.org", "time": "Fri Mar 03 20:01:26 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 03 20:08:46 2023" }, "message": "Remove expired histograms DBus.ExportedMethodHandleSuccess, DBus.ExportedMethodHandleTime, DBus.SignalSendTime\n\nThese histograms haven\u0027t been recorded since M85 so removal seems to be\nthe correct path here. This is a code-health task.\n\nBug: 1384732\nChange-Id: I25f14eec343fb76fdc95e3684bc6db30fa93cbc1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307349\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: David Schinazi \u003cdschinazi@chromium.org\u003e\nAuto-Submit: Ari Chivukula \u003carichiv@chromium.org\u003e\nReviewed-by: David Schinazi \u003cdschinazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1112930}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e8030fd67f62e7a8abfb8dab73663ad80bbad3c6\n" }, { "commit": "b57c13b4c81ef5e7ac97a97eadf8d9f6d0a3a804", "tree": "eed426cf3e3da9d75ede55acbba5984441ad4919", "parents": [ "c0b7285598db801a775e66f8eb9437d141d4e26d" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Wed Jan 11 01:03:29 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 11 01:08:57 2023" }, "message": "Update header includes for /base/functional in /d*, /e*, /f*\n\nbind.h, callback.h, callback_forward.h, and callback_helpers.h\nmoved into /base/functional/. Update the include paths to\ndirectly include them in their new location.\n\nBug: 1364441\nChange-Id: I6ce44f5813ff87215cb0df1d13bb649885a54c6a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4152775\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1091122}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bb9cd02c17a2e8a8bdeca3712d357ca3d15a95bf\n" }, { "commit": "c0b7285598db801a775e66f8eb9437d141d4e26d", "tree": "1dda3cef2ab505a7283cf324eee5ea4172355812", "parents": [ "bbdab93f8ac7ae121c0fe975575fde6d431764fb" ], "author": { "name": "Sean Maher", "email": "spvw@chromium.org", "time": "Mon Jan 09 21:42:28 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jan 09 21:47:20 2023" }, "message": "task posting v3: remove includes of runner handles and IWYU task runners\n\nTurns out there\u0027s a lot of includes, so these will have to be removed\nbefore deleting the implementation of the task runner handles.\n\nTo allow the deletion of the task runner handle headers, add\nthe sequenced/thread task runner handles where they are used in\nthe codebase with scripts.\n\nThis was done with an automated change, with a few touchups afterwards.\nThe code for the mass-refactor changes are here:\npython:\nhttps://paste.googleplex.com/5534570878337024\nshell:\nhttps://paste.googleplex.com/6466750748033024\n\nIn terms of touchups:\n- add sequenced/thread task runner handles to\n the third_party/blink/public/DEPS, because multiple files were using\n it transitively anyways.\n- rewrite certain parts of the codebase which used\n ThreadTaskRunnerHandles instead of CurrentDefaultHandles.\n- fix a compile issue with forward-declaration in\n extensions/browser/extension_file_task_runner.h.\n\nAX-Relnotes: n/a.\nBug: 1026641\nChange-Id: I737ef32aee4e77c21eaa3a2bdc403a28322cf1b7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133323\nOwners-Override: Gabriel Charette \u003cgab@chromium.org\u003e\nCommit-Queue: Sean Maher \u003cspvw@chromium.org\u003e\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1090532}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e672a665ffa8fe4901184f03922e2cc548399da5\n" }, { "commit": "bbdab93f8ac7ae121c0fe975575fde6d431764fb", "tree": "4f9d88b6a08e5c61d9abede22ba14ece15eb3e1b", "parents": [ "785cb5990c0477a970f57763da74c6cde3389303" ], "author": { "name": "Joseph Park", "email": "josephjoopark@chromium.org", "time": "Wed Jan 04 23:42:39 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 04 23:49:40 2023" }, "message": "Update comment to use correct base::Value types\n\nBug: 1291670\nChange-Id: I0a03f516f61a1cba89b454ccdaaa7dd3589ec146\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133527\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Joseph Park \u003cjosephjoopark@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1089022}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0451c7be18f1b2283a6f389c23157cb53596df71\n" }, { "commit": "785cb5990c0477a970f57763da74c6cde3389303", "tree": "b3856269e0ac0142287f6347ba9591a8ee5d4d9a", "parents": [ "1c3a1d74cc59d7225358b17f8cc04bacd4823cf1" ], "author": { "name": "Ali Hijazi", "email": "ahijazi@chromium.org", "time": "Wed Dec 07 09:33:58 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 07 09:51:20 2022" }, "message": "DanglingPtr: Mark all of them as untriaged [20/N]\n\nThis patch is a no-op with all the common build flags.\n\nAdd the \"DanglingUntriaged\" raw_ptr annotation. It indicates a raw_ptr\nbecomes dangling, and it should be triaged/fixed. This will also disable\ndangling detection for those pointers, once enabled.\n\nThese were identified by running the lacros-arm-generic-rel CQ bot with\nDPD activated (both build + runtime here: https://crrev.com/c/3941825)\n\nBug: 1291138\nChange-Id: I794fc28f0a9ace8b2cf5dfd14e9391896ac1fd55\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4083425\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nOwners-Override: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Ali Hijazi \u003cahijazi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1080246}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4d98c3e55f21cc695102cdfe89d38b9a870c0896\n" }, { "commit": "1c3a1d74cc59d7225358b17f8cc04bacd4823cf1", "tree": "d2b0ec59cb3787ec543a9bc46fc62dc2e8d487af", "parents": [ "263d56b8bb37d54afa1a787760ee7c5596205aa0" ], "author": { "name": "Keishi Hattori", "email": "keishi@chromium.org", "time": "Tue Nov 29 20:14:11 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 29 20:18:18 2022" }, "message": "[BRP] Apply raw_ptr rewriter for linux\n\nRewrites generated by running the raw_ptr rewriter (linux)\non 5abc121d7b703bae6909920d65f0ed8021c2eaa4\n\nPS1: generated rewrite\nPS2: exclude ui/qt\nPS4: exclude net/cert/pki\n\nAX-Relnotes: n/a.\nChange-Id: Ic03defbaf4e1f651ec850381c0686b226434f87f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4063630\nOwners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCommit-Queue: Keishi Hattori \u003ckeishi@chromium.org\u003e\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1077037}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 71ad757a3b22a551f3bfc433750c28ef16f262d0\n" }, { "commit": "263d56b8bb37d54afa1a787760ee7c5596205aa0", "tree": "649d97202597c5d3e39e79644d19ca4146550e7f", "parents": [ "b098b0c2418986ba5258928c991b9e7eb8c36036" ], "author": { "name": "Matt Menke", "email": "mmenke@chromium.org", "time": "Tue Nov 29 01:26:52 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 29 01:33:18 2022" }, "message": "Migrate dbus/values_util.cc to new base::Value APIs.\n\nBug: 1187001\nChange-Id: I53858d3f8ac497beb2751d1a7e25f389cfd6a070\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060621\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Matt Menke \u003cmmenke@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1076573}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d5b6a14df2ea7541597277ea9a30f65e7f3e8fd2\n" }, { "commit": "b098b0c2418986ba5258928c991b9e7eb8c36036", "tree": "bbc4f759078fea1c9873e7128e336adecb816d7c", "parents": [ "6332cdeef1686671ca5e963cbe16424f75da67ba" ], "author": { "name": "Sean Maher", "email": "spvw@chromium.org", "time": "Mon Nov 28 18:13:41 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 28 18:18:54 2022" }, "message": "Task posting v3: refactor base::PostTaskAndReplyWithResult\n\nChange all instances of base::PostTaskAndReplyWithResult(task_runner\nto task_runner-\u003ePostTaskAndReplyWithResult(.\n\nThis also removes includes of base/task/task_runner_util.h, but only\nin the files with \u0027base::PostTaskAndReplyWithResult\u0027 which don\u0027t refer\nto PostTaskAndReplyWithResult in other places.\n\nCode was refactored with the following scripts:\npython script:\nhttps://paste.googleplex.com/5117849478627328\nshell script:\nhttps://paste.googleplex.com/4961540519231488\n\nBug: 1026641\nChange-Id: Ifb34b3b9078440dda5902b0d694cb8d3f315dfe7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892903\nCommit-Queue: Sean Maher \u003cspvw@chromium.org\u003e\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nOwners-Override: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1076288}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a539a158cb6ad26c470cbfa81efa16b3f926cba7\n" }, { "commit": "6332cdeef1686671ca5e963cbe16424f75da67ba", "tree": "949f76fa134b8256a9a7cccf92582e0572d89c2a", "parents": [ "69b8a2ef299d4bc4e838c7b736ce37d7dc7e4c98" ], "author": { "name": "Sean Maher", "email": "spvw@chromium.org", "time": "Mon Nov 14 15:53:25 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 14 16:01:11 2022" }, "message": "task posting v3: moving away from SequencedTaskRunnerHandle\n\nTo continue the migration away from TaskRunnerHandles, the codebase\nwas refactored using the following scripts:\nshell script:\nhttps://paste.googleplex.com/4673967729147904\npython:\nhttps://paste.googleplex.com/5302682490241024\n\nThis will do a few sed-like modifications, changing calls to methods of\nSequencedTaskRunnerHandle to calls to methods of\nSequencedTaskRunner::CurrentDefaultHandle, and swapping includes.\n\nBug: 1026641\nAX-Relnotes: n/a.\nChange-Id: I49e50a2bd1e78b00e7c067219fff96d2e0bc0b46\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3983373\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nOwners-Override: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1071032}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 52fa5a7f263b37149bcfbac06da00fec5abcc416\n" }, { "commit": "69b8a2ef299d4bc4e838c7b736ce37d7dc7e4c98", "tree": "efe55797a26ba42a9713a18a69401d454cf8856b", "parents": [ "5256d5fcb2a81149e13932eb38e31f84a7de1186" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Tue Sep 13 19:40:31 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 13 19:55:53 2022" }, "message": "Update copyright headers in dbus/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c34.\n\nNo-Try: true\nBug: 1098010\nChange-Id: Id0e774f0a2778c9651c064cabd38146f92989536\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3894315\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Mark Mentovai \u003cmark@chromium.org\u003e\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1046513}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f75e37fb60399778deddbea422659925a52269a4\n" }, { "commit": "5256d5fcb2a81149e13932eb38e31f84a7de1186", "tree": "a428bf52996e0791be33b55821339313622fd561", "parents": [ "9fd9a23f735fbbce7f0858ee140f80e1aacd5317" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Fri Aug 05 23:44:08 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 13 19:54:45 2022" }, "message": "Fix typos for the word \"propagated\".\n\nFix this typo across the code base to quell Tricium SpellChecker\nwarnings.\n\nChange-Id: I8d1faee3117d121a0b16e857843fb1cbe8252858\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810768\nOwners-Override: Erik Staab \u003cestaab@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Erik Staab \u003cestaab@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1032172}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2b75f48f841748abcd18caf7aa74dc1dc34ef45c\n" }, { "commit": "9fd9a23f735fbbce7f0858ee140f80e1aacd5317", "tree": "c1ab4f1be7bda83eacd6266ba10663fb3d94a085", "parents": [ "4b6c209f31582c3fe83fa810e499e80dafe98823" ], "author": { "name": "Nan Lin", "email": "linnan@chromium.org", "time": "Wed Aug 03 21:47:46 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 03 21:57:45 2022" }, "message": "Reland \"[Code Health] Replace base::DictionaryValue in device/bluetooth/dbus\"\n\nThis is a reland of commit 1a7ead85cd0847b6a6955414aad8dc28b34393f0\n\nOriginal change\u0027s description:\n\u003e [Code Health] Replace base::DictionaryValue in device/bluetooth/dbus\n\u003e\n\u003e This CL also updates utility functions in dbus/value_utils.* to take\n\u003e base::ValueView so that base::Value::Dict can be passed in.\n\u003e\n\u003e Bug: 1187061\n\u003e Change-Id: I2a1081dd6e7d1def255733b62b5aa3ce547dca47\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3738509\n\u003e Commit-Queue: Nan Lin \u003clinnan@chromium.org\u003e\n\u003e Reviewed-by: Sonny Sasaka \u003csonnysasaka@chromium.org\u003e\n\u003e Reviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1023368}\n\nBug: 1187061\nChange-Id: I6b2a5716c7cb09aa039c7f7a5668555560508fd3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3806433\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nReviewed-by: Sonny Sasaka \u003csonnysasaka@chromium.org\u003e\nCommit-Queue: Nan Lin \u003clinnan@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1031214}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 49d6dae845e82406764ea7409a9177471c7f193a\n" }, { "commit": "4b6c209f31582c3fe83fa810e499e80dafe98823", "tree": "92be8745474a73ef80953243a3694d941501444f", "parents": [ "de953e9672503e7c130af16161a4d59546fc7d5d" ], "author": { "name": "Nan Lin", "email": "linnan@chromium.org", "time": "Thu Jul 21 17:33:08 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 21 17:44:22 2022" }, "message": "Revert \"[Code Health] Replace base::DictionaryValue in device/bluetooth/dbus\"\n\nThis reverts commit 1a7ead85cd0847b6a6955414aad8dc28b34393f0.\n\nReason for revert: crbug.com/1346257\n\nOriginal change\u0027s description:\n\u003e [Code Health] Replace base::DictionaryValue in device/bluetooth/dbus\n\u003e\n\u003e This CL also updates utility functions in dbus/value_utils.* to take\n\u003e base::ValueView so that base::Value::Dict can be passed in.\n\u003e\n\u003e Bug: 1187061\n\u003e Change-Id: I2a1081dd6e7d1def255733b62b5aa3ce547dca47\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3738509\n\u003e Commit-Queue: Nan Lin \u003clinnan@chromium.org\u003e\n\u003e Reviewed-by: Sonny Sasaka \u003csonnysasaka@chromium.org\u003e\n\u003e Reviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1023368}\n\nBug: 1187061\nChange-Id: Ic3b4d5367198f3bc75cb87b63690087f547bba18\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3780447\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Srinivas Sista \u003csrinivassista@chromium.org\u003e\nCommit-Queue: Nan Lin \u003clinnan@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1026847}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ec8cdf3681e584e9fdc515a823a06b20a3fe6d56\n" }, { "commit": "de953e9672503e7c130af16161a4d59546fc7d5d", "tree": "d67a4e0c7621ddc1f2bbd02d4f24bedf3865fb4d", "parents": [ "4b9c066cebe18b8e08770e6d884ddadcc145c6f9" ], "author": { "name": "Nan Lin", "email": "linnan@chromium.org", "time": "Tue Jul 12 20:03:06 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 12 20:10:42 2022" }, "message": "[Code Health] Replace base::DictionaryValue in device/bluetooth/dbus\n\nThis CL also updates utility functions in dbus/value_utils.* to take\nbase::ValueView so that base::Value::Dict can be passed in.\n\nBug: 1187061\nChange-Id: I2a1081dd6e7d1def255733b62b5aa3ce547dca47\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3738509\nCommit-Queue: Nan Lin \u003clinnan@chromium.org\u003e\nReviewed-by: Sonny Sasaka \u003csonnysasaka@chromium.org\u003e\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1023368}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1a7ead85cd0847b6a6955414aad8dc28b34393f0\n" }, { "commit": "4b9c066cebe18b8e08770e6d884ddadcc145c6f9", "tree": "92be8745474a73ef80953243a3694d941501444f", "parents": [ "58db2108092bd6290c33888f087faf086c17d21f" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Mon Jun 27 09:38:01 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 27 09:49:05 2022" }, "message": "DanglingPtr: Mark all of them as untriaged [2/N]\n\nThis is a small extension of:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/3687960\n\nThis annotates dangling raw_ptr with \"DanglingUntriaged\".\nIt indicates a raw_ptr becomes dangling, and it should be triaged/fixed.\n\nThis annotates the one firing during content_browsertests again, because new ones were added in:\nhttps://source.chromium.org/chromium/chromium/src/+/f28f4f8f90c4494c9bc9f34a28f5dcc215caa077\n\nBug\u003d1291138\n\nChange-Id: I6aca38ecb605ad7be3fded96cfbd5ddbb4762f69\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3720659\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1018148}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b99722f49f32577016b4ded725fee854ccf8cf55\n" }, { "commit": "58db2108092bd6290c33888f087faf086c17d21f", "tree": "7840a759bae5ad18c6079cd378cec3bd5396d8ba", "parents": [ "966dee0db847da6b499a7a94015e855246322555" ], "author": { "name": "Keishi Hattori", "email": "keishi@chromium.org", "time": "Tue Jun 21 11:32:15 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 21 11:44:55 2022" }, "message": "Rewrite raw pointer fields to use raw_ptr\u003cT\u003e for linux\n\nThis reapplies the rewrite_raw_ptr_fields rewriter on Linux platform.\n\nThis change is a merge of the following changes:\nPS1 raw_ptr rewrite generated by\n rewrite-multiple-platforms.sh linux\n on ae73da96bbea9eb8a1e1babc0ce720eb3c321ff0\nPS2 manual build fix by adding .get()\nPS4 revert rewrite of ArrayDataViewImpl fields\nPS6,PS8, PS11 manual build fix\n - add BreakpadInfo default constructor\n - fix nc test error message regex\n - Add missing .get()\nPS13 Fix #include position\n\nAX-Relnotes: n/a.\nBug: 1073933\nChange-Id: I9fbb18f98fef4d55cf2ed74f0aab8d1db6f354a1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715469\nReviewed-by: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nOwners-Override: Keishi Hattori \u003ckeishi@chromium.org\u003e\nCommit-Queue: Keishi Hattori \u003ckeishi@chromium.org\u003e\nOwners-Override: Bartek Nowierski \u003cbartekn@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1016130}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f28f4f8f90c4494c9bc9f34a28f5dcc215caa077\n" }, { "commit": "966dee0db847da6b499a7a94015e855246322555", "tree": "ae18309256874a3520a5cb445ee3c6c2b4d62fb9", "parents": [ "e2b832806eee5a5db259137ca55e4b69ad39ee27" ], "author": { "name": "Gabriel Charette", "email": "gab@chromium.org", "time": "Fri Apr 01 18:58:52 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 01 19:23:21 2022" }, "message": "[base] Undo erroneous IWYU of time.h in presence of base::Thread\n\n@QA: This CL is a no-op.\n\nCaused by incorrectly covering base::Thread when using regex\n\"base::(Time|Thread)(Ticks|Delta)?\\b\"\n\nThis script removed base/time/time.h if:\n 1) \"base::Thread\" is present\n 2) There is no (Time|ThreadTicks|Days|Hours|Minutes|Seconds|\n Milliseconds|Microseconds|Nanoseconds|Hertz)\n string in the file (no base:: prefix required to skip removal)\n\nBug: 1026641\nChange-Id: I9df5e8beccc74054bf9bfff12320a1d4e0295b62\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3563202\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nAuto-Submit: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#988045}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 494bf1e595e8ec1560a1c18c6eb55e9851208dc1\n" }, { "commit": "e2b832806eee5a5db259137ca55e4b69ad39ee27", "tree": "3004f5c320d81b22f770dc50e82b59a5fbaf1294", "parents": [ "13aa8e0bf7809b394b1fa2cd7362172335979a22" ], "author": { "name": "Gabriel Charette", "email": "gab@chromium.org", "time": "Thu Mar 31 00:44:22 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 31 00:57:28 2022" }, "message": "[base] IWYU for base::Time\n\nThis CL is a no-op.\n\nOnly fixing instances where base::Time (and Ticks/Delta) is used in\na statement (i.e. not as a parameter to avoid adding includes in mere\noverrides). Skipping pointer and reference qualified instances.\n\ni.e. matches this regex:\n\u0027(\\n *[^/\\n][^/\\n][^/\\n]*base::(Time|Thread)(Ticks|Delta)?\\b[^*\u0026][^)]*;)\u0027\n\nand skipping files that have any existing fwd-decl for any of the\nvariants.\n\nThis is a prereq to remove unused base/task/post_task.h includes in\nhttps://chromium-review.googlesource.com/c/chromium/src/+/3555247\n\nBug: 1026641\nChange-Id: I87b43a8dc92bdceb67f4bd59b327b54813aa72a6\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557354\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nAuto-Submit: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#987283}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d87f10f4671473938a344e7d02ba330018f8a48b\n" }, { "commit": "13aa8e0bf7809b394b1fa2cd7362172335979a22", "tree": "e68c437e4451f66b2ab14e6fdb0abbf30baeb042", "parents": [ "d236797cb483a18fd691eb1d12417ce9b82ef78d" ], "author": { "name": "David Sanders", "email": "dsanders11@ucsbalum.com", "time": "Thu Mar 17 07:36:44 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 17 07:48:04 2022" }, "message": "Add missing includes of waitable_event.h\n\nForward declarations were used when possible in headers\n\nBug: 1300573\nChange-Id: Id7b2a428fa0f92eeacf974e0159644fa7299e9d8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3528197\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#982074}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 10242c1163d550aa39472c2a2199f4e3ef3dde99\n" }, { "commit": "d236797cb483a18fd691eb1d12417ce9b82ef78d", "tree": "02d638872073f3a7ce6edd638454fd83eacfa11a", "parents": [ "d0bc5452ed4881db11ce9c0308206ea1d1b2952d" ], "author": { "name": "David Sanders", "email": "dsanders11@ucsbalum.com", "time": "Fri Mar 04 06:28:03 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 04 06:37:41 2022" }, "message": "Fix typos in //dbus/bus.h\n\nChange-Id: Iba484301445ece9e105c0023e3af6cb3ae84b8d0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501275\nReviewed-by: Satoru Takabayashi \u003csatorux@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: David Sanders \u003cdsanders11@ucsbalum.com\u003e\nCr-Commit-Position: refs/heads/main@{#977522}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 880aecb5d7827de78a34aa27a4b5dbd892e491c7\n" }, { "commit": "d0bc5452ed4881db11ce9c0308206ea1d1b2952d", "tree": "04ea47e7ffd9ae44878f6d8c095dd93ef8b9c6b7", "parents": [ "94b5163c727003150a40a41e254eafdeb9cd3df7" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Sat Feb 26 09:14:33 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Feb 26 09:24:33 2022" }, "message": "Migrate base::{size,empty,data} to STL equivalents in //dbus.\n\nBug: 1299695\nChange-Id: I6ee717b9c155abc84560b5c34603b660f65ec552\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3490663\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#975445}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e0a0baa600690b1bb6b9f2c17364ffd225afaaf7\n" }, { "commit": "94b5163c727003150a40a41e254eafdeb9cd3df7", "tree": "a88987a02d31587017b439d8c6fd889e93fe1ba7", "parents": [ "4e5b1595f9dbed405b0704b28966be4f6db5523e" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Thu Feb 03 17:39:57 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 03 17:50:26 2022" }, "message": "Migrate base::Value::GetList() to base::Value::GetListDeprecated(): 2/N.\n\nGetList() will be reimplemented in a future CL with an updated\nsignature, so existing uses need to be renamed out of the way.\n\nUnlike TakeList() and TakeDict(), GetList() is used quite widely. This\nCL migrates a number of uses using the following set of automated steps:\n\nsed -i \"s|\\.GetList()|.GetListDeprecated()|g\" \\\n $(git gs \"GetList()\" --name-only)\ngit checkout -- base/values.cc base/values.h\ngit checkout -- base/values_unittest.cc third_party/dom_distiller_js\ngit checkout -- tools/clang\ngit cl format\n\nBug: 1291666\nChange-Id: I0413b4857cbf38943333988e36da53f44aab7a15\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435727\nReviewed-by: danakj chromium \u003cdanakj@chromium.org\u003e\nCommit-Queue: danakj chromium \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj chromium \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#966793}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 91148c1c1e318eb5e5a4b9340fe59e036a3ed15f\n" }, { "commit": "4e5b1595f9dbed405b0704b28966be4f6db5523e", "tree": "8a9644dc76c559d282cecb4b54ee0b1454dd5e40", "parents": [ "84fda1d1fd0940774695245906badbfda4f89982" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Tue Jan 11 07:55:09 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jan 11 08:05:27 2022" }, "message": "Modernize usage of base::Value in //dbus\n\nbase::Value refactoring doc:\nhttps://docs.google.com/document/d/1CwYuMXnVQsRsghwVzEkWj9GZzfERputSLQaKx5xLhjQ\n\nR\u003dhashimoto\n\nBug: 1187001\nChange-Id: Ia5907236f125ce530b451bc7f214715fea865791\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3367747\nAuto-Submit: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#957457}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4e92ab0d584fd9c653779009d90ad28eba884ddd\n" }, { "commit": "84fda1d1fd0940774695245906badbfda4f89982", "tree": "e2ed9da0eae45642769d460154c4baa1183079a3", "parents": [ "494950183a15b8ac832d7c4f547e1f1ad06d972d" ], "author": { "name": "Viktor Semeniuk", "email": "vsemeniuk@google.com", "time": "Wed Dec 22 14:30:24 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 22 14:40:38 2021" }, "message": "[Code Health] Replace Value::GetAsList with GetList\n\nThis is part of the great base::Value refactoring, and fixes same\nremaining uses in dbus/values_util.cc of GetAsList.\n\nBug: 1187009\nChange-Id: Ib9d706d8c3f50d42b3166539b606aec6fb8e14d3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3351971\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Viktor Semeniuk \u003cvsemeniuk@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#953525}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 78efb67fbd7d351be6fe92693909c097a4aab9b6\n" }, { "commit": "494950183a15b8ac832d7c4f547e1f1ad06d972d", "tree": "193dddd3ae430f4ea439fa7cc1d5ec380aef84ab", "parents": [ "4f0fddbc1c9dd0b20fc0b9e6f5a1ec923bac9416" ], "author": { "name": "Xiyuan Xia", "email": "xiyuan@google.com", "time": "Thu Dec 02 16:37:31 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 02 16:48:53 2021" }, "message": "dbus: Remove ObjectProxy crash debugging code\n\nThe crashes seem to be caused by memory corruption from\nother parts of code. And they stopped since M97 (from field\nand from lab). Assuming the issue is fixed and clean up the\ndebugging code.\n\nBug: 1211451, b:192617139\nChange-Id: I88f6cb0c06d825353aed118d3b5eecafb315a694\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312038\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#947519}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4ca2766fe8dbd41f9c87b18b1588331fd2d87e03\n" }, { "commit": "4f0fddbc1c9dd0b20fc0b9e6f5a1ec923bac9416", "tree": "0da04d3d45a4e5f9ba1ee1fad0a5afbbddd190ff", "parents": [ "e060fb76cc7476491c8548f6ea271249cbb456d9" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Fri Nov 12 03:40:24 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 12 03:51:27 2021" }, "message": "Remove most remaining unused \"base/macros.h\"\n\nRemoves `#include \"base/macros.h\"` from remaining .cc, .h and .mm files\nthat do not contain `ignore_result(` and do not trigger pre-commit or\npre-upload errors.\n\nBug: 1010217\nNo-Try: true\nChange-Id: I4cc5207b3deafa7901764d2e633bbb1ad43cfb73\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276692\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#941054}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5666ff4f5077a7e2f72902f3a95f5d553ea0d88d\n" }, { "commit": "e060fb76cc7476491c8548f6ea271249cbb456d9", "tree": "e196f50d8c1ab0f630aaa67534b41b796a8f3f56", "parents": [ "ac2545523872e88ba53f69964f600cda4e3d983f" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Fri Nov 05 01:12:30 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 05 01:22:59 2021" }, "message": "Remove all DISALLOW_COPY_AND_ASSIGNs\n\nThis replaces all remaining DISALLOW_COPY_AND_ASSIGN() instances with\ntheir expanded counterparts.\n\nThe macro definitions and IWYU are left as a separate change. The former\nto prevent unintended large reverts and the latter is easier once all\nDISALLOW_ macros are gone.\n\nBug: 1010217\nChange-Id: I0e2fd43f4060628c09420709010aab2c84b87148\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259964\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#938612}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 896f13791f32e90dc08379498e17a181d4afcf5f\n" }, { "commit": "ac2545523872e88ba53f69964f600cda4e3d983f", "tree": "25d3bf731537356b40e0beac2489302155586790", "parents": [ "8979cdf06d7199428f01c0a76a466539ab40a368" ], "author": { "name": "Patrick Monette", "email": "pmonette@chromium.org", "time": "Fri Oct 15 19:13:42 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 15 19:24:25 2021" }, "message": "Replace base/task/ temporary forward headers with their final locations\n\nNote to QA: This merely changes includes and should not be blamed\nfor files it touched.\n\nBug: 1255932\nChange-Id: I1ce4e31efd5792ebf2080812e665cae838a54972\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226943\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nOwners-Override: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#932153}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 643cdf61903e99f27c3d80daee67e217e9d280e0\n" }, { "commit": "8979cdf06d7199428f01c0a76a466539ab40a368", "tree": "4036388e1799d5e6bdd855dacb73389227b95f8d", "parents": [ "8983186ac5cf4af56bc3c76a5a68d71dd83fbb41" ], "author": { "name": "Ryo Hashimoto", "email": "hashimoto@chromium.org", "time": "Wed Oct 13 03:10:18 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 13 03:19:10 2021" }, "message": "dbus: Make Bus::Option movable\n\nCopy/move ctor and operator\u003d() must be explicitly declared together.\nhttps://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types\n\nBUG\u003d1257224\nTEST\u003dbuild\n\nChange-Id: Ia8b0f6f667426cfeb69b7fb4ccfa835e2961c07c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218830\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#930902}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 020d6092695b3e3259e3bbec5e778192e26a2575\n" }, { "commit": "8983186ac5cf4af56bc3c76a5a68d71dd83fbb41", "tree": "db808fe7c3be676f682eab50aa7adffff7d0f84f", "parents": [ "4e08a969c015d5ce45d8cbbdb00a46b8d86f1290" ], "author": { "name": "Andres Medina", "email": "medinaandres@google.com", "time": "Mon Oct 11 20:32:18 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Oct 11 20:43:29 2021" }, "message": "[dbus] Added constructor for complex class.\n\nBug: 1257224\nTest: Passed clang build checks.\nChange-Id: I8a9d9fb5145ab53fb6009e6494cd470fd78c8745\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205394\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Andres Medina \u003cmedinaandres@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#930269}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 577b6b006023a846dee0edce5b8d59c20ab87040\n" }, { "commit": "4e08a969c015d5ce45d8cbbdb00a46b8d86f1290", "tree": "bf44b628623dfae80829b2551e2b4d54d317f07f", "parents": [ "d921dd1288d96a3aeee91a2c9840cfc875e4ae00" ], "author": { "name": "Patrick Monette", "email": "pmonette@chromium.org", "time": "Fri Oct 08 20:27:23 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 08 20:35:39 2021" }, "message": "Replace task-related headers to their equivalent in base/task/\n\nThis CL was generated by using tools/git/move_source_file.py to change\nthe includes for those files:\nbase/bind_post_task.h\nbase/deferred_sequenced_task_runner.h\nbase/post_task_and_reply_with_result_internal.h\nbase/sequenced_task_runner.h\nbase/sequenced_task_runner_helpers.h\nbase/single_thread_task_runner.h\nbase/task_runner.h\nbase/task_runner_util.h\nbase/updateable_sequenced_task_runner.h\n\nThen formatted using \"git cl format\". DEPS files were fixed with a\nsimple search and replace script.\n\nBug: 1255932\nChange-Id: I0d9b5ddd9260fde5e4581e6c6e0080bdb0ed2c44\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209175\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nOwners-Override: Gabriel Charette \u003cgab@chromium.org\u003e\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#929867}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3d7d70920a92c08f6a16597f9f44bb28ac98d9a4\n" }, { "commit": "d921dd1288d96a3aeee91a2c9840cfc875e4ae00", "tree": "82ec15d652ac59dca9a812ecca3b0bc295de2115", "parents": [ "575ae34bfd0381ebac2c62ea73985825f279e449" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Sat Oct 02 03:06:35 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Oct 02 03:14:49 2021" }, "message": "Migrate \"base::TimeDelta::FromX\" to \"base:X\".\n\nAll changes were done automatically with git grep, sed, xargs, etc.\n\nNo-Presubmit: true\nNo-Try: true\nBug: 1243777\nChange-Id: I7cc197e9027f7837cd36afc67a209079f85ec364\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198824\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Peter Boström \u003cpbos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#927512}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e5a38eddbdf45d7563a00d019debd11b803af1bb\n" }, { "commit": "575ae34bfd0381ebac2c62ea73985825f279e449", "tree": "bf62d57b72bd65f8ba18f2d2147cb3efaf0c090a", "parents": [ "c3e2795d9ee05ed97b807d642a106b11c3610725" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Fri Oct 01 00:37:41 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 01 00:50:26 2021" }, "message": "Update base::DoNothing() / base::NullCallback() to use a type tag.\n\nThis allows both helpers to be used in contexts where the original\nhelper required templated arguments to be explicitly specified,\ngenerally leading to more concise code.\n\nHowever, since base::DoNothing() only returns a type tag now, it can no\nlonger be used as a functor with base::BindOnce/base::BindRepeating.\nIn general, this seems to be a net neutral to slight positive change:\nthe lambda version is actually shorter—though some might argue less\nreadable—and it generates more efficient code since running the callback\nnow jumps through one less thunk.\n\nBug: 1252980\nChange-Id: I6b72230fe9d583865ff3d40fc51025f6195ebbc4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180101\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#927031}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e0fc463ca6d8dedd64bb520779aa367c0831581b\n" }, { "commit": "c3e2795d9ee05ed97b807d642a106b11c3610725", "tree": "09f301c8dc7b8d3386d5e1b9d2692b31dbba2c98", "parents": [ "e2d64d02590adf0e8b6672f6192ffaf6ee91bb3e" ], "author": { "name": "Nodir Turakulov", "email": "nodir@chromium.org", "time": "Tue Sep 28 06:50:47 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 28 07:01:24 2021" }, "message": "[dirmd] Use metadata mixins\n\nUse the new \"mixins\" feature in dirmd.\nDerive mixins from file:// links in OWNERS files.\n\nThis CL is machine-generated, in two parts.\n\nPart 1: use mixins.\n\n1. Save current metadata to JSON files, in ORIGINAL and REDUCED forms.\n dirmd read -form original \u003e ~/tmp/dirmd/original.json\n dirmd read -form reduced \u003e ~/tmp/dirmd/reduced.json\n2. Run mixins.py.\n Source code: https://gist.github.com/nodirg/b59d3df338a72a8944f957c5b3a15e22\n\nThe script finds related directories, connected by file:// links\nin OWNERS files. For those directories that have the same base\nname, e.g.\n components/autofill\n chrome/android/java/src/org/chromium/chrome/browser/autofill\nif importing the \"parent\" to the \"child\" reduces metadata, or adds\nmissing metadata, extract the common metadata to COMMON_METADATA\nand import it in both directories.\n\nPart2: deduplicate metadata.\nApply same instructions as in\nhttps://chromium-review.googlesource.com/c/chromium/src/+/2795985/16\n\nBug: 1179786\nChange-Id: I2e6378004ce433e02f1c9360b09eb72354083bf6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2897943\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nReviewed-by: Fred Mello \u003cfredmello@chromium.org\u003e\nOwners-Override: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCommit-Queue: Nodir Turakulov \u003cnodir@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#925648}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: de11715e63f49274f3fab352f2367699348ba255\n" }, { "commit": "e2d64d02590adf0e8b6672f6192ffaf6ee91bb3e", "tree": "06eb0bcae7d11fdfa0a88760c06c056f5bc88df9", "parents": [ "850259ea563283e8d87654f2b8b438dcd9ef94de" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Tue Sep 28 00:28:00 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 28 00:37:27 2021" }, "message": "Script remove more DISALLOW_COPY_AND_ASSIGNs\n\nThis applies a script previously used for large directories on all\nremaining (smaller) directories as a single chunk.\n\nThis replaces DISALLOW_COPY_AND_ASSIGN with explicit constructor deletes\nwhere a local script is able to detect its insertion place (~Foo() is\npublic \u003d\u003e insert before this line).\n\nThis is incomplete as not all classes have a public ~Foo() declared, so\nnot all DISALLOW_COPY_AND_ASSIGN occurrences are replaced.\n\nIWYU cleanup is left as a separate pass that is easier when these macros\ngo away.\n\nBug: 1010217\nChange-Id: I572936462f763e1dd15dd88cdcf451ee14b34dd1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182480\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#925533}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c68c5aad6c5f2cbbda3efc5a1e6dd647bbc55108\n" }, { "commit": "850259ea563283e8d87654f2b8b438dcd9ef94de", "tree": "88f5de2da3174fb1391b680b090c846c90731e3d", "parents": [ "fd3578dff88591ef9f19ddb885278e0de914c991" ], "author": { "name": "Abhishek Pandit-Subedi", "email": "abhishekpandit@chromium.org", "time": "Tue Aug 17 00:37:01 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 17 00:47:11 2021" }, "message": "dbus: Add IsInterfaceRegistered to ObjectManager\n\nThis change adds a new public method to check whether a specific\ninterface is currently registered with ObjectManager. It will be used\nmainly for testing.\n\nBUG\u003db:193712484\nTEST\u003dautoninja -c out/Default chrome\n\nChange-Id: I46b0ad58afd7334693393b1c9a0291bb94a58dd0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3089691\nCommit-Queue: Abhishek Pandit-Subedi \u003cabhishekpandit@chromium.org\u003e\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#912402}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 94ccec0eace4bfddd4153c3fb1abeb58ad6659c9\n" }, { "commit": "fd3578dff88591ef9f19ddb885278e0de914c991", "tree": "96edb52ce10451e09eaf4b26671b695c718614d8", "parents": [ "f5d2fee64b123cc86ee536a093fb41830e57bdfd" ], "author": { "name": "Gabriel Charette", "email": "gab@chromium.org", "time": "Wed Jul 21 00:49:28 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 21 00:56:03 2021" }, "message": "Use scopers instead of SetIOAllowed() where scope is trivial\n\nThere are few enough SetIOAllowed() calls left for it to be reasonable\nto make it private+friend for the few use cases left!\n\nFirst step here to avoid using it when a scope is well-defined.\n\nBug: 766678\nChange-Id: I83117c0973a79243034dc6e7040d827eb2988c17\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911076\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nAuto-Submit: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#903726}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ad3304295703105516ab3f57e51fbb3f0d414bc4\n" }, { "commit": "f5d2fee64b123cc86ee536a093fb41830e57bdfd", "tree": "a5f8d8531f6f8e50cb2b27d1752c2ca4305e235f", "parents": [ "5b64e4bb350ef23b7b5456a798627f9b5b997705" ], "author": { "name": "Maggie Cai", "email": "mxcai@google.com", "time": "Tue Jul 13 01:54:21 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 13 02:03:07 2021" }, "message": "[CodeHealth] Remove the ListValue usage from ValuesUtilTest.\n\nThis CL removes the deprecated ListValue usages from ValuesUtilTest.\n\nBUG\u003d1187102, 1187099\n\nChange-Id: Iab8d8168dffdb10d5dc83c5581b3f216725981ce\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3019985\nReviewed-by: Steven Bennetts \u003cstevenjb@chromium.org\u003e\nCommit-Queue: Maggie Cai \u003cmxcai@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#900779}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a3e82c4de2256e8ac311bea4bd197055947e82b3\n" }, { "commit": "5b64e4bb350ef23b7b5456a798627f9b5b997705", "tree": "80d244dc33c09997aa5af0dcbb4e12fd5effe023", "parents": [ "4abd9609e1c4d2ddd3def079e0ba750e8b98457b" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Thu Jul 08 03:43:28 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 08 03:52:26 2021" }, "message": "Swap base/stl_util.h to base/cxx17_backports.h in many files.\n\nFiles that use base::size() and base::data() should use\ncxx17_backports.h directly, instead of getting it transitively through\nstl_util.h.\n\nBug: 1210983\nChange-Id: Icc5f425c23ef4e69283293e0d0d6d733fe3b4ba1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2974072\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#899418}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d4a2f8e1ed461d8fc05ed88d1ae2dc94c9773825\n" }, { "commit": "4abd9609e1c4d2ddd3def079e0ba750e8b98457b", "tree": "fecdd5d0997558e7227d5753a030e67984423444", "parents": [ "83a661dc22bbce6610a85bbd0763bb0f534b3c1f" ], "author": { "name": "Xiyuan Xia", "email": "xiyuan@google.com", "time": "Thu Jun 17 15:08:39 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 17 15:18:25 2021" }, "message": "dbus: CHECK whether ReplyCallbackHolder lose callback\n\nAdd CHECK() along the dbus call code path where ReplyCallbackHolder\nis used to find our whether response callback is lost somehow.\n\nAnd move DEBUG_ALIAS_FOR_CSTR before the LOG(FATAL) crash.\n\nBug: 1211451\nChange-Id: I7f29313892f400e8b88a37453950a9791e052998\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967203\nReviewed-by: Ryo Hashimoto \u003chashimoto@chromium.org\u003e\nCommit-Queue: Xiyuan Xia \u003cxiyuan@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#893439}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b03b25e90816a6f0188172c46f88d1312de0284b\n" } ], "next": "83a661dc22bbce6610a85bbd0763bb0f534b3c1f" }