| commit | 7501daaf24ce599510c95308ce3df581960f6173 | [log] [tgz] |
|---|---|---|
| author | Jan Wilken Dörrie <jdoerrie@chromium.org> | Thu Aug 27 23:54:22 2020 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Aug 27 23:57:15 2020 |
| tree | e93f0570efebc80148e0305eda5412d878366d42 | |
| parent | 4611e1edda0a43b5f9a7034174e3ad2ee65a3720 [diff] |
[base] CHECK_LE(pos, size()) in BasicStringPiece::substr This change adds a CHECK_LE(pos, size()) in BasicStringPiece::substr. This attempts to model standard library behavior, since std::basic_string_view::substr throws an out_of_range exception in this case. Reference: https://wg21.link/string.view.ops#itemdecl:2 TBR=dcheng Bug: 1049498 Change-Id: Ie5c946b8cd1b2cb9d7022bfcd5fa2a89372ec31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372445 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802440} GitOrigin-RevId: 846ae441cf24759286ef0ee386b0a3bd922851e9